New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603620 link

Starred by 9 users

[General] Reach GAR level 1 for MD Settings

Project Member Reported by tbuck...@chromium.org, Apr 14 2016

Issue description

From lpalmaro on contrast issues:
All text on all pages must meet an absolute min contrast level of 4.5:1, and I spot a lot of instances where this is not the case. For example, the text on the About UI that says "Open the Help App" and "Google Chrome is made possible....". It seems that all of the supporting info is too light (for context, I can't read it unless I zoom way in), but there are other instances where this seems to be the case, too. Similarly, the blue used in the "Add a Device" buttons and other similar ones. Please check contrast on each page. Here is one tool to check contrast [1], but there are many out there, including as part of the Chrome accessibility developer tools audit (extension).

[1] http://webaim.org/resources/contrastchecker/
Cc: dschuyler@chromium.org dbeam@chromium.org bettes@chromium.org
This is partly a bug on the mocks (where it shows low-contrast text), but we should be using the specs instead of the mocks for color values.

I guess the AI is for the devs to check these things on the implemented pages (particularly in the common styles), and either fix or file bugs on bettes@ for the issues we find.

Comment 4 by dbeam@chromium.org, Apr 21 2016

bettes@: this is not just about the style, but also how all users can accomplish tasks successfully (whether using mouse, keyboard, screen reader, blind, sighted, w/ a tremor, etc.)
Labels: MD-Settings-General
Labels: -MD-Settings-General Hotlist-MD-Settings-General
Cc: nyerramilli@chromium.org tkonch...@chromium.org
 Issue 621821  has been merged into this issue.
 Issue 622755  has been merged into this issue.
Cc: tbuck...@chromium.org
 Issue 621402  has been merged into this issue.
 Issue 622276  has been merged into this issue.
Labels: -Hotlist-MD-Settings-General Hotlist-MD-Settings-PageA11y
Blockedon: 627215
Cc: ranjitkan@chromium.org
 Issue 626891  has been merged into this issue.
Blockedon: 627970
Blockedon: 629446
Blockedon: 628172
Blockedon: 628165
I sincerely hope that this, and other accessibility bugs will be looked at and addressed before md-settings goes live. There are still many unlabeled buttons, and a keyboard user or a switch user cannot begin to navigate the UI as most controls are not even in the tab order. Thanks.
Cc: lpalmaro@chromium.org

Comment 20 by chaok@google.com, Aug 8 2016

Old/classic-is broadly accessible/usable, so GAR-4, and I am surprised to see md-settings regresse and target GAR-1?
I don't think old options is GAR 4
Blockedon: 633492
Blockedon: 633915

Comment 24 by chaok@google.com, Oct 3 2016

Who's best owner?
Owner: hcarmona@chromium.org
Status: Assigned (was: Available)
hcarmona@ for now

Comment 26 by chaok@google.com, Dec 13 2016

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!
Blockedon: 675385
Blockedon: 675393
Blockedon: 675395
Blockedon: 633858
Blockedon: 671375
Blockedon: -671375
Blocking: 671375

Comment 33 by chaok@google.com, Jan 26 2017

NextAction: 2017-01-26

Comment 34 by dbeam@chromium.org, Mar 27 2017

Blockedon: -626880
Blockedon: 710691
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2e5c72ba330412f724b23e2b79d302460060ef

commit ff2e5c72ba330412f724b23e2b79d302460060ef
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Apr 13 04:16:31 2017

MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG= 603620 , 626882 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2810003003
Cr-Commit-Position: refs/heads/master@{#464293}

[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/app/settings_strings.grdp
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/site_settings/media_picker.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/site_settings/media_picker.js
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 37 by dbeam@chromium.org, Apr 20 2017

hcarmona@: all the blockers for this bug are now fixed.  can we mark this fixed?  have we reached GAR1 yet?
Status: Fixed (was: Assigned)
SGTM, marking as fixed.

Sign in to add a comment