libwebp.gyp ignores order_profiling |
|||||
Issue descriptionWhen order_profiling=1 all files (except a very small selection) need to be compiled with '-finstrument-functions' compiler flag. However, for some historical reasons libwebp.gyp wants to stay below the instrumentation radar. With GN the instrumentation is not avoided. Nothing breaks in the pipeline with GN. So we should clean up the GYP build to match.
,
Apr 14 2016
It's not clear if this falls under Chrome startup performance (Removing Performance-Startup). If it does, feel free to re-add the label.
,
Apr 14 2016
order_profiling pipeline is one of the main optimizations for startup performance on Android. It was used before on ChromeOS, but no longer.
,
Apr 15 2016
If it's working with GN, I doubt it's worth looking at the GYP. It'll likely be deleted in a couple of months.
,
Apr 15 2016
re #4: it is a small change: https://codereview.chromium.org/1889513005/ Also makes sure that nobody tries to take unneeded GYP stuff into GN (I don't know how this process works - just extra safety).
,
Apr 15 2016
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d91056b63c00b0911f426859ef907e9f70ee627 commit 6d91056b63c00b0911f426859ef907e9f70ee627 Author: pasko <pasko@chromium.org> Date: Fri Apr 15 09:49:33 2016 Make libwebp.gyp respect order_profiling mode Currently when order_profiling=1 build flag is set GN would instrument all libwebp targets and produce the 'orderfile' containing libwebp functions. This change brings the GYP build on par with GN build with respect to treating the order_profiling flag. Reasons for having a special case in GYP are historical and probably not relevant any more. Performance impact on the GYP build will probably be negligible. It just feels good to simplify things. BUG= 603618 Review URL: https://codereview.chromium.org/1889513005 Cr-Commit-Position: refs/heads/master@{#387564} [modify] https://crrev.com/6d91056b63c00b0911f426859ef907e9f70ee627/third_party/libwebp/libwebp.gyp
,
Apr 15 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pasko@chromium.org
, Apr 14 2016