Add stress tests for MemoryCache |
||||||
Issue descriptionThere are intermittent failures in the webgl_conformance tests on the win_chromium_rel_ng trybot apparently caused by some change to Blink's memory cache. Some failing builds: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/205042 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/205032 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/205011 https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/205010 The tests which fail are random. The stack trace is: [ RUN ] WebglConformance.conformance_programs_gl_getshadersource Backtrace: blink::MemoryCache::pruneLiveResources [0x61DA6126+182] blink::MemoryCache::didProcessTask [0x61DA3A16+118] scheduler::WebThreadBase::TaskObserverAdapter::DidProcessTask [0x638BFE48+8] scheduler::TaskQueueManager::ProcessTaskFromWorkQueue [0x638CF070+1744] scheduler::TaskQueueManager::DoWork [0x638CE1D0+560] base::internal::Invoker<base::IndexSequence<0,1,2>,base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall scheduler::TaskQueueManager::*)(base::TimeTicks,bool)>,void __cdecl(scheduler::TaskQueueManager *,base::TimeTicks,bool),base::Wea [0x638CF6AF+79] base::debug::TaskAnnotator::RunTask [0x61013607+247] base::MessageLoop::RunTask [0x60FE281B+1211] base::MessageLoop::DoWork [0x60FE1E13+547] base::MessagePumpDefault::Run [0x61015CCB+299] base::MessageLoop::RunHandler [0x60FE2357+103] base::RunLoop::Run [0x61015ED9+41] base::MessageLoop::Run [0x60FE22E2+98] content::RendererMain [0x625CF37A+1338] content::RunNamedProcessTypeMain [0x60FBB194+260] content::ContentMainRunnerImpl::Run [0x60FBB063+275] content::ContentMain [0x60FB8453+35] ChromeMain [0x60F141DB+107] MainDllLoader::Launch [0x0017756C+748] wWinMain [0x00176D31+577] __scrt_common_main_seh [0x001DE889+253] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255) BaseThreadInitThunk [0x7577336A+18] RtlInitializeExceptionChain [0x77A492B2+99] RtlInitializeExceptionChain [0x77A49285+54] These crashes likely started in the past 24 hours. We urgently need to track down the CL which caused them and revert it. Brandon, as pixel wrangler can you look through the Blink change log since yesterday and try to find a culprit CL? Blocking Issue 603462 -- not 100% sure it's related, as no CLs have landed for that bug.
,
Apr 14 2016
Oh, phew. I've been investigating other flaky crashes yesterday that had already slipped through the CQ, and hadn't realized these were all for the same CL that hadn't been committed yet. Thanks for pointing that out. Let me leave this assigned to you and blocking the other bug so that it's permanently recorded that this sort of error happened.
,
Apr 14 2016
FYI This kind of test failures in Web GL tests are sometimes seen (mainly when trying draft CLs) due to changes to MemoryCache: a certain pattern of MemoryCache use and pruning occurs in Web GL tests, which exposes MemoryCache bugs in the draft CLs.
,
Apr 14 2016
Good to know that these tests are helping catch bugs. Do you think that more targeted stress tests are warranted, that would more reliably catch these sort of MemoryCache bugs?
,
Apr 21 2016
Removed WebGL label (this is not a WebGL-related bug), unblock Issue 603462 (because the test failure in my draft CL were fixed already), and renamed the issue. I expect Issue 603462 will reduce the need for stress tests by simplifying MemoryCache.
,
Apr 24 2017
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue. The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
Should we maybe close this now? (And file a new one if we still have the need for it?)
,
Apr 25 2017
Sounds OK to me. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hirosh...@chromium.org
, Apr 14 2016