New issue
Advanced search Search tips

Issue 603562 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-X

Blocking:
issue 671916



Sign in to add a comment

MacViewsBrowser: base::Window::IsMaximized() / Maximize() doesn't make much sense on Mac OS X

Reported by mbl...@yandex-team.ru, Apr 14 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/601.5.17 (KHTML, like Gecko) Version/9.1 Safari/601.5.17

Steps to reproduce the problem:
On Windows / Linux IsMaximized() returns true when the window occupies the entire work_area of the display it's on.

But on Mac OS X it doesn't make much sense, as normally applications implement Zoom and Fullscreen features, where Fullscreen moves the window to a separate Space, and Zoom resizes the window to fit the content.

Discussion that started this issue:
https://codereview.chromium.org/1747803003/diff/200001/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc#newcode920

What is the expected behavior?

What went wrong?
I think that IsMaximized / Maximize functions should be #ifdef'd out on Mac OS X, so all places that use it could be explicitly audited for their use.

Did this work before? N/A 

Chrome version:   Channel: n/a
OS Version: OS X 10.11.4
Flash Version:

Comment 1 by meh...@chromium.org, Apr 14 2016

Components: Internals>Views

Comment 2 by ccameron@chromium.org, Apr 15 2016

Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by tapted@chromium.org, Dec 6 2017

Blocking: 671916
Status: Available (was: Assigned)
Thanks for all of these! I'll do a big triage of  Issue 671916  blockers when the current phase is complete. See go/macviewstracking

Comment 4 by ellyjo...@chromium.org, Apr 2 2018

Cc: tapted@chromium.org
Labels: -Via-Wizard MacViews-Cleanup M-X
Owner: ----
MacViews triage: this is a cleanup bug and is M-X.

Comment 5 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews

Comment 6 by robliao@chromium.org, Jul 12

Labels: Group-MacOS_Platform_Integration_and_Participation

Comment 7 by jmukthavaram@google.com, Nov 27

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
***UI Mass Triage ***
Adding labels for expert review.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de4762785e0e8a03ae83f1c834b002cfbc0a868

commit 9de4762785e0e8a03ae83f1c834b002cfbc0a868
Author: Peter Kasting <pkasting@chromium.org>
Date: Thu Jan 03 20:22:59 2019

Enable disabled tests in c/b/ui/views/tabs/.

Bug:  331924 , 603562,  626761 ,  837219 
Change-Id: If2695993d98dc00168c367c3c171b99a96eb7bc5
Reviewed-on: https://chromium-review.googlesource.com/c/1351809
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619736}
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_frame.cc
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_frame.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/9de4762785e0e8a03ae83f1c834b002cfbc0a868/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h
►

Sign in to add a comment