New issue
Advanced search Search tips

Issue 603536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 436283



Sign in to add a comment

bluetooth: Can't tap "Pair" in Android N multi-window mode

Project Member Reported by fbeaufort@chromium.org, Apr 14 2016

Issue description

Version: Chrome Dev 51.0.2704.5
OS: Android N Developer Preview (2nd release) - http://developer.android.com/preview/index.html
Device: Nexus 6

What steps will reproduce the problem?
(1) Open YouTube and Chrome in multi-window mode next to each other
(2) Open a tab to https://webbluetoothcg.github.io/demos/playbulb-candle/
(3) Make sure a nearby PLAYBULB Candle device is broadcasting its presence
(4) Click "Connect" button
(5) Pick "PLAYBULB Candle"

What is the expected output?
Click on the "PAIR" button.

What do you see instead?
I can't reach the "PAIR" button as you can see in the screenshots below
 
Screenshot_20160414-091806.png
1.4 MB View Download
Screenshot_20160414-091821.png
1.8 MB View Download
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af63104f71ad62bd89ba5c8bc61fde5c421fdd4c

commit af63104f71ad62bd89ba5c8bc61fde5c421fdd4c
Author: jyasskin <jyasskin@chromium.org>
Date: Tue May 31 23:12:48 2016

Set the Bluetooth chooser list height to cut through the middle of a list item.

This isn't the perfect fix, but it's easy and doesn't require us to
figure out how to draw shadows.

This also uses the DecorView's height instead of the WindowManager's Display's height in order to work well in multi-window mode.

BUG= 614300 , 603536 

Review-Url: https://codereview.chromium.org/2018213002
Cr-Commit-Position: refs/heads/master@{#396966}

[modify] https://crrev.com/af63104f71ad62bd89ba5c8bc61fde5c421fdd4c/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/af63104f71ad62bd89ba5c8bc61fde5c421fdd4c/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
[modify] https://crrev.com/af63104f71ad62bd89ba5c8bc61fde5c421fdd4c/chrome/android/java/src/org/chromium/chrome/browser/UsbChooserDialog.java
[modify] https://crrev.com/af63104f71ad62bd89ba5c8bc61fde5c421fdd4c/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

Owner: jyasskin@chromium.org
Status: Fixed (was: Available)
I think r396966 fixed this, but I've only tested it on an Android N tablet, not a phone. Because of issue 616227, you have to close and re-open the dialog to get it to change size, but at least you can get to the Pair button at all.
Indeed! Thank you Jeffrey!
It works great on Android N DP3. See attached images below.
Screenshot_20160601-142855.png
442 KB View Download
Screenshot_20160601-142848.png
928 KB View Download

Sign in to add a comment