New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603507 link

Starred by 38 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Display:table height issue

Reported by are.lel...@gmail.com, Apr 14 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Create an element with display:table;height:100%
2. Create a child with display:table-row;height:100%
3. Create a grandchild with height:100%

What is the expected behavior?
The grandchild should get the correct height.

What went wrong?
The grandchild only get the content height.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Previous version of chrome.

Does this work in other browsers? Yes 

Chrome version: 50.0.2661.75  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
 
code.PNG
32.8 KB View Download
chrome not ok.PNG
28.0 KB View Download
IE OK.PNG
13.0 KB View Download

Comment 1 Deleted

Comment 2 by sailor...@gmail.com, Apr 14 2016

Possible similar bug. In attach sample code.
table_cell_textarea_height.html
695 bytes View Download

Comment 3 by sailor...@gmail.com, Apr 14 2016

This is regression. In Chrome < 50 all was fine.
I'm also getting this bug. Now it has similar behaviour as IE9. For temporary workaround I suggest calculate remain height with JS.
I'm getting this bug as well. Hope it will be fixed quickly.
Components: Blink>Layout>Table
I believe this is the same issue I am seeing for the text & placeholder in the text box. See http://jsbin.com/bezufu/edit?html,css,output for an example.
Screen Shot 2016-04-14 at 4.15.15 PM.png
12.0 KB View Download
Components: -Blink
Hello, this is affecting many web scripts, please fix ASAP

Comment 10 Deleted

Comment 11 by hdr...@gmail.com, Apr 15 2016

As a temporary fix, if the grandchild div has display: table-cell, it uses the height: 100%

Comment 12 by gami...@gmail.com, Apr 18 2016

"As a temporary fix, if the grandchild div has display: table-cell, it uses the height: 100%"
=> Not enough.

Because the problem starts when you have a block inside that table-cell.
=> see this testcase http://jsfiddle.net/rp9htqks/

Since Chrome 50, you have to specify height:100% (c/paste from parent tr height) on the table-cell as well.
It used to work in previous versions of Chrome, and still work in Firefox.

Given the #353580 patch description, this part of the behaviour was not supposed to change.

Comment 13 by e...@chromium.org, Apr 18 2016

Owner: dgro...@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: dgro...@chromium.org
 Issue 603963  has been merged into this issue.
Cc: cbiesin...@chromium.org
 Issue 603835  has been merged into this issue.
Labels: -OS-Windows -Type-Bug -Pri-2 OS-All Pri-1 Type-Bug-Regression
Hi All, Will this be fixed and if so when can we expect to see it hit the stable release?
Thanks,
Gary

Comment 18 by o...@openerp.com, Apr 19 2016

As a complement to the OP, this regression was bisected in  issue 604173  and looks like an unintended side-effect of commit 8876584335b48c99cf8df552ef4d8efebb131041.

Unfortunately it breaks a very popular CSS technique (aka the "holy grail" layout) for rendering a fixed growable header above a scrollable area taking the rest of the screen, that worked in all browsers until Chrome 50!

Here is a simple demo of this layout: http://jsfiddle.net/257zsmaz/

For the record, the workaround discussed above (setting "display: table-cell" on the direct child of the table-row) is illustrated in the updated fiddle: http://jsfiddle.net/257zsmaz/1/
and that workaround *breaks the layout* in IE9+!

@dgrogan: Please note that even though the above commit (for issue 353580) was supposed to make Blink behave like Firefox, Firefox has no problem with both layouts:
   - http://jsfiddle.net/pCx89/4/ (test case for issue 353580, no red square in FF)
   - http://jsfiddle.net/257zsmaz/ (header+scrollable layout, works in FF and IE, broken in Chrome 50)

Thanks!
I'm going to revert this change (huzzah!) but am not yet sure when you'll see it in the stable release. You'll see the progress on this bug though.
Is anyone find solution for this problem?? till now I can't use Odoo? 
Cc: manoranj...@chromium.org ligim...@chromium.org
Labels: Merge-Request-50

Comment 23 by tin...@google.com, Apr 19 2016

Labels: -Merge-Request-50 Merge-Approved-50
Given the user impact and it's a revert per Comment 19, merge approved for M50 (branch 2661). Pls go ahead merge asap.
Labels: TE-Verified-M50 TE-Verified-50.0.2661.86
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.4 using chrome version  50.0.2661.86.Able to see the expected result as per reporters comment.
Please find the attached screen shot for the same.

Adding TE-Verified.

Thanks,
603507.png
63.8 KB View Download

Comment 26 by o...@openerp.com, Apr 21 2016

Thanks @dgrogan for the quick revert!
Good news, the build with the commit reverted (50.0.2661.86) is already available as stable release on both Mac and Linux platforms. Windows/iOS should have it soon, hopefully.

Comment 27 by phistuck@gmail.com, Apr 21 2016

Note that iOS is unrelated to this issue, as it does not use Blink. You probably meant Android.

Comment 28 by o...@openerp.com, Apr 21 2016

@phistuck oh you're right, iOS should not be affected by the issue due to its use of WebKit, and Android stable still has Chrome 49, so it's not affected (yet). Thanks for the correction!

Comment 29 by e...@chromium.org, Apr 21 2016

 Issue 605257  has been merged into this issue.
Project Member

Comment 30 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3d77052c868e6f31cb4da867f641e64f47ab3e2

commit a3d77052c868e6f31cb4da867f641e64f47ab3e2
Author: dgrogan <dgrogan@chromium.org>
Date: Thu Apr 21 21:06:28 2016

Revert "Treat percent-height div inside auto-height cells as auto"

This reverts commit 8876584335b48c99cf8df552ef4d8efebb131041.

Even though this aligned us better with the spec and FF in some cases, it
broke too many others.

E.g. it broke http://jsfiddle.net/dgrogan/rp9htqks/6/ - Edge, Chrome 49
and FF all have a green square, chrome 50.0.2661.75 does not.

Compare to the test case that originally spurred this change
http://jsfiddle.net/pCx89/4/

BUG= 603507 ,353580

Review URL: https://codereview.chromium.org/1899053002

Cr-Commit-Position: refs/heads/master@{#388899}

[modify] https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/58b579ece9fcbc9d38ea9c186b4898685067d3ae/third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto-expected.txt
[delete] https://crrev.com/58b579ece9fcbc9d38ea9c186b4898685067d3ae/third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto.html
[modify] https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/a3d77052c868e6f31cb4da867f641e64f47ab3e2/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Comment 31 by bpoz...@gmail.com, Apr 22 2016

Thank you for acknowledging the impact of this issue and reverting quickly!
As odo@ said in comment 26, the revert landed in the 50.0.2661.86 version, which is already available on mac and linux. 50.0.2661.87 is slowly being distributed to windows now. Android is still on 49.x so will never have this problem hit stable.

Sorry for the breakage, everyone.
Labels: Merge-Request-51
Adding Merge-Request-51. As I think you're aware, this has passed through both a stable and canary release and I'd like to merge it the current beta.

Comment 34 by e...@chromium.org, Apr 22 2016

Status: Fixed (was: Assigned)

Comment 35 by tin...@google.com, Apr 22 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Please merge your change to M51 branch 2704 before 5:00 PM PST Monday (04/25/16) so we can take it for next week M51 Beta candidate cut. Thank you.
Project Member

Comment 37 by bugdroid1@chromium.org, Apr 22 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a12f4d422ff4389e32aa29414aa62b263c5eb24

commit 1a12f4d422ff4389e32aa29414aa62b263c5eb24
Author: David Grogan <dgrogan@chromium.org>
Date: Fri Apr 22 20:55:33 2016

Revert "Treat percent-height div inside auto-height cells as auto"

This reverts commit 8876584335b48c99cf8df552ef4d8efebb131041.

Even though this aligned us better with the spec and FF in some cases, it
broke too many others.

E.g. it broke http://jsfiddle.net/dgrogan/rp9htqks/6/ - Edge, Chrome 49
and FF all have a green square, chrome 50.0.2661.75 does not.

Compare to the test case that originally spurred this change
http://jsfiddle.net/pCx89/4/

BUG= 603507 ,353580

Review URL: https://codereview.chromium.org/1899053002

Cr-Commit-Position: refs/heads/master@{#388899}
(cherry picked from commit a3d77052c868e6f31cb4da867f641e64f47ab3e2)

Review URL: https://codereview.chromium.org/1916573002 .

Cr-Commit-Position: refs/branch-heads/2704@{#193}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/1a12f4d422ff4389e32aa29414aa62b263c5eb24/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/42ff73aced2b6eaf4b8ee508be4504c09e5b45aa/third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto-expected.txt
[delete] https://crrev.com/42ff73aced2b6eaf4b8ee508be4504c09e5b45aa/third_party/WebKit/LayoutTests/fast/table/div-height-inside-auto-table-cell-is-auto.html
[modify] https://crrev.com/1a12f4d422ff4389e32aa29414aa62b263c5eb24/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/1a12f4d422ff4389e32aa29414aa62b263c5eb24/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/1a12f4d422ff4389e32aa29414aa62b263c5eb24/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/1a12f4d422ff4389e32aa29414aa62b263c5eb24/third_party/WebKit/LayoutTests/platform/linux/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/1a12f4d422ff4389e32aa29414aa62b263c5eb24/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Thanks for fixing this so quickly!

Comment 39 by e...@chromium.org, Apr 26 2016

 Issue 606631  has been merged into this issue.

Comment 40 Deleted

Project Member

Comment 41 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0651543bd5ca7827297b751d492ceb22412576

commit ef0651543bd5ca7827297b751d492ceb22412576
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 19 23:48:12 2016

Auto-rebaseline for r394892

https://chromium.googlesource.com/chromium/src/+/3ad270df9

BUG= 603507 
TBR=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/1999433003 .

Cr-Commit-Position: refs/heads/master@{#394909}

[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/mac/fast/table/split-table-section-before-anonymous-block-4-expected.txt
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-2-expected.png
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-2-expected.txt
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-4-expected.png
[modify] https://crrev.com/ef0651543bd5ca7827297b751d492ceb22412576/third_party/WebKit/LayoutTests/platform/win/fast/table/split-table-section-before-anonymous-block-4-expected.txt

Sign in to add a comment