New issue
Advanced search Search tips

Issue 603466 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'SIGN IN TO CHROME' link vanishes after entering long profile name in chrome://md-settings.

Reported by rk...@etouch.net, Apr 14 2016 
Chrome Version: 51.0.2704.7 (Official Build) a8bebc2b0cd3e3018b7c9f6ac698f04dd226abba-refs/branch-heads/2704@{#48}(32/64 bit)
OS: Windows, Linux, Mac
 
Precondition: Enable 'Material design in the browser's top chrome' by selecting 'Material' option.

What steps will reproduce the problem?
(1) Launch chrome,navigate to chrome://md-settings
(2) Click on 'Profile Avtar' icon, enter long profile name in text field  and click on back arrow near to the 'Edit person'.
(3) Observe the 'SIGN IN TO CHROME' link.

'SIGN IN TO CHROME' link vanishes after entering long profile name in field.

'SIGN IN TO CHROME' link should not vanish after entering long profile name in field.

This is a regression issue,broken in 'M-49', below is bisect info:

Good Build: 49.0.2615.0
Bad Build: 49.0.2616.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/7b5d43b0e9474238a48be623cab9c5fa95ae2f42..4670776e23949822d6fc9ae94db5eeda1d007a7e?pretty=fuller&n=100

Suspecting: r368181
Actual_Result.mp4
561 KB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/566aabfccaef722eeb0cd45c0b078ee9e99e5441

commit 566aabfccaef722eeb0cd45c0b078ee9e99e5441
Author: tommycli <tommycli@chromium.org>
Date: Thu Aug 18 16:30:21 2016

Settings People: Prevent long profile names from clobbering buttons.

BUG= 603466 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2256963002
Cr-Commit-Position: refs/heads/master@{#412851}

[modify] https://crrev.com/566aabfccaef722eeb0cd45c0b078ee9e99e5441/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/566aabfccaef722eeb0cd45c0b078ee9e99e5441/chrome/browser/resources/settings/settings_shared_css.html

Comment 2 by tommycli@chromium.org, Aug 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment