New issue
Advanced search Search tips

Issue 603431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

querySelector(All) looking up multiple IDs in wrong scope

Reported by r...@opera.com, Apr 14 2016

Issue description

One of the code paths in the selector query code looks up IDs in the document scope instead of the tree-scope for the shadow tree when querying inside a shadow tree.

 
multi-id.html
362 bytes View Download

Comment 1 by hayato@chromium.org, Apr 14 2016

Owner: hayato@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f363d853d714ebd13fb0abb951cddc83451912a

commit 9f363d853d714ebd13fb0abb951cddc83451912a
Author: hayato <hayato@chromium.org>
Date: Fri Apr 15 08:31:09 2016

Fix querySelectorAll for multiple Ids in a shadow tree

One of the code paths in the selector query code looks up IDs in the document scope
instead of the tree-scope for the shadow tree when querying inside a shadow tree.

This CL is separated CL from https://codereview.chromium.org/1883083002

BUG= 603431 

Review URL: https://codereview.chromium.org/1892743002

Cr-Commit-Position: refs/heads/master@{#387561}

[add] https://crrev.com/9f363d853d714ebd13fb0abb951cddc83451912a/third_party/WebKit/LayoutTests/shadow-dom/query-selector.html
[modify] https://crrev.com/9f363d853d714ebd13fb0abb951cddc83451912a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

Comment 3 by hayato@chromium.org, Apr 15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment