New issue
Advanced search Search tips

Issue 603428 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Chrome: Crash Report - content::WebURLLoaderImpl::setLoadingTaskRunner

Project Member Reported by tkonch...@chromium.org, Apr 14 2016

Issue description

Product name: Chrome
Magic Signature: content::WebURLLoaderImpl::setLoadingTaskRunner

Current link:
crash.corp.google.com/browse?q=product.name%3D'Chrome'%20AND%20product.version%3D'52.0.2708.0'%20AND%20custom_data.ChromeCrashProto.ptype%3D'renderer'%20AND%20ReportID%3D'327ff2cc00000000'%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D'content%3A%3AWebURLLoaderImpl%3A%3AsetLoadingTaskRunner'&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#3


Search properties:
product.name: Chrome
product.version: 52.0.2708.0
custom_data.chromecrashproto.ptype: renderer
reportid: 327ff2cc00000000

Metadata :
Product Name: Chrome
Product Version: 52.0.2708.0
Report ID: 327ff2cc00000000
Report Time: Thu, 14 Apr 2016 07:39:11 GMT
Uptime: 23000 ms
Cumulative Uptime: 0 ms
User Email: 
OS Name: Windows NT
OS Version: 10.0.10586 0
CPU Architecture: amd64
CPU Info: family 21 model 16 stepping 1

Stack Trace:
Thread 0 CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 ] MAGIC SIGNATURE THREAD
0x00007ff9fb4465fa	(chrome_child.dll -web_url_loader_impl.cc:1137 )	content::WebURLLoaderImpl::setLoadingTaskRunner(blink::WebTaskRunner *)
0x00007ff9f90cd5ef	(chrome_child.dll -resourceloader.cpp:106 )	blink::ResourceLoader::start(blink::ResourceRequest &)
0x00007ff9f90245e9	(chrome_child.dll -resource.cpp:265 )	blink::Resource::load(blink::ResourceFetcher *)
0x00007ff9f9d97a95	(chrome_child.dll -remotefontfacesource.cpp:177 )	blink::RemoteFontFaceSource::beginLoadIfNeeded()
0x00007ff9f9d8da38	(chrome_child.dll -cssfontface.cpp:158 )	blink::CSSFontFace::load(blink::FontDescription const &)
0x00007ff9f9d8d83a	(chrome_child.dll -cssfontface.cpp:139 )	blink::CSSFontFace::load()
0x00007ff9f9d8d3f2	(chrome_child.dll -cssfontface.cpp:71 )	blink::CSSFontFace::fontLoaded(blink::RemoteFontFaceSource *)
0x00007ff9f9d976dc	(chrome_child.dll -remotefontfacesource.cpp:99 )	blink::RemoteFontFaceSource::fontLoaded(blink::FontResource *)
0x00007ff9f90d818e	(chrome_child.dll -fontresource.cpp:178 )	blink::FontResource::checkNotify()
0x00007ff9f9024c35	(chrome_child.dll -resource.cpp:334 )	blink::Resource::error(blink::Resource::Status)
0x00007ff9f90cdaa8	(chrome_child.dll -resourceloader.cpp:203 )	blink::ResourceLoader::cancel(blink::ResourceError const &)
0x00007ff9f90cdeeb	(chrome_child.dll -resourceloader.cpp:274 )	blink::ResourceLoader::didReceiveResponse(blink::WebURLLoader *,blink::WebURLResponse const &,blink::WebDataConsumerHandle *)
0x00007ff9fb4442f3	(chrome_child.dll -web_url_loader_impl.cc:682 )	content::WebURLLoaderImpl::Context::OnReceivedResponse(content::ResourceResponseInfo const &)
0x00007ff9fa6a574c	(chrome_child.dll -resource_dispatcher.cc:174 )	content::ResourceDispatcher::OnReceivedResponse(int,content::ResourceResponseHead const &)
0x00007ff9fa6a2df9	(chrome_child.dll -ipc_message_templates.h:121 )	IPC::MessageT<ResourceMsg_ReceivedResponse_Meta,std::tuple<int,content::ResourceResponseHead>,void>::Dispatch<content::ResourceDispatcher,content::ResourceDispatcher,void,void ( content::ResourceDispatcher::*)(int,content::ResourceResponseHead const &)>(IPC::Message const *,content::ResourceDispatcher *,content::ResourceDispatcher *,void *,void ( content::ResourceDispatcher::*)(int,content::ResourceResponseHead const &))
0x00007ff9fa6a4a7e	(chrome_child.dll -resource_dispatcher.cc:503 )	content::ResourceDispatcher::DispatchMessageW(IPC::Message const &)
0x00007ff9fa6a4e77	(chrome_child.dll -resource_dispatcher.cc:124 )	content::ResourceDispatcher::OnMessageReceived(IPC::Message const &)
0x00007ff9fa6b0320	(chrome_child.dll -resource_scheduling_filter.cc:31 )	content::`anonymous namespace'::DispatchMessageTask::run
0x00007ff9fb433ff5	(chrome_child.dll -permission_dispatcher.cc:220 )	content::PermissionDispatcher::RunPermissionCallbackOnWorkerThread(std::unique_ptr<blink::WebCallbacks<blink::WebPermissionStatus,void>,std::default_delete<blink::WebCallbacks<blink::WebPermissionStatus,void> > >,blink::WebPermissionStatus)
0x00007ff9fa32a6bd	(chrome_child.dll -bind_internal.h:372 )	base::internal::Invoker<base::IndexSequence<0>,base::internal::BindState<base::internal::RunnableAdapter<void (*)(std::unique_ptr<mojo::edk::NodeController,std::default_delete<mojo::edk::NodeController> >)>,void ,base::internal::PassedWrapper<std::unique_ptr<mojo::edk::NodeController,std::default_delete<mojo::edk::NodeController> > > >,base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void (*)(std::unique_ptr<mojo::edk::NodeController,std::default_delete<mojo::edk::NodeController> >)> >,void >::Run(base::internal::BindStateBase *)
0x00007ff9f8b6c053	(chrome_child.dll -task_annotator.cc:51 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &)
0x00007ff9fb4648ca	(chrome_child.dll -task_queue_manager.cc:289 )	scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue *,scheduler::internal::TaskQueueImpl::Task *)
0x00007ff9fb46406a	(chrome_child.dll -task_queue_manager.cc:201 )	scheduler::TaskQueueManager::DoWork(base::TimeTicks,bool)
0x00007ff9fb4631ea	(chrome_child.dll -bind_internal.h:334 )	base::internal::InvokeHelper<1,void,base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)> >::MakeItSo<base::WeakPtr<scheduler::TaskQueueManager>,base::TimeTicks const &,bool const &>(base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)>,base::WeakPtr<scheduler::TaskQueueManager>,base::TimeTicks const &,bool const &)
0x00007ff9fb464ca1	(chrome_child.dll -bind_internal.h:372 )	base::internal::Invoker<base::IndexSequence<0,1,2>,base::internal::BindState<base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)>,void ,base::WeakPtr<scheduler::TaskQueueManager>,base::TimeTicks &,bool>,base::internal::InvokeHelper<1,void,base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)> >,void >::Run(base::internal::BindStateBase *)
0x00007ff9f8b6c053	(chrome_child.dll -task_annotator.cc:51 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &)
0x00007ff9f8b273bf	(chrome_child.dll -message_loop.cc:479 )	base::MessageLoop::RunTask(base::PendingTask const &)
0x00007ff9f8b28051	(chrome_child.dll -message_loop.cc:600 )	base::MessageLoop::DoWork()
0x00007ff9f8b6e1b1	(chrome_child.dll -message_pump_default.cc:33 )	base::MessagePumpDefault::Run(base::MessagePump::Delegate *)
0x00007ff9f8b6dbfe	(chrome_child.dll -run_loop.cc:35 )	base::RunLoop::Run()
0x00007ff9f8b266b0	(chrome_child.dll -message_loop.cc:295 )	base::MessageLoop::Run()
0x00007ff9fa71ee45	(chrome_child.dll -renderer_main.cc:219 )	content::RendererMain(content::MainFunctionParams const &)
0x00007ff9fa02fa5a	(chrome_child.dll -content_main_runner.cc:381 )	content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x00007ff9fa02f8ab	(chrome_child.dll -content_main_runner.cc:742 )	content::ContentMainRunnerImpl::Run()
0x00007ff9fa02ce4b	(chrome_child.dll -content_main.cc:20 )	content::ContentMain(content::ContentMainParams const &)
0x00007ff9f9f9af45	(chrome_child.dll -chrome_main.cc:84 )	ChromeMain
0x00007ff75ac9c6b1	(chrome.exe -main_dll_loader_win.cc:183 )	MainDllLoader::Launch(HINSTANCE__ *)
0x00007ff75ac9b859	(chrome.exe -chrome_exe_main_win.cc:268 )	wWinMain
0x00007ff75acda649	(chrome.exe -exe_common.inl:255 )	__scrt_common_main_seh
0x00007ffa28758101	(KERNEL32.dll + 0x00018101 )	BaseThreadInitThunk
0x00007ffa2af0c5b3	(ntdll.dll + 0x0005c5b3 )	RtlUserThreadStart

This crash got regressed in 52.0.2708.0 with 2 instances from 2 different client IDs as of now.

Effecting all OS as below

1	Chrome	        72.79%	99	
2	Chrome_Android	24.26%	33	
3	Chrome_ChromeOS	0.74%	1	
4	Chrome_Linux	1.47%	2	
5	Chrome_Mac	0.74%	1	
Total:	                100.00%	136	

Link to the builds:
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3AWebURLLoaderImpl%3A%3AsetLoadingTaskRunner%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D

CL : https://chromium.googlesource.com/chromium/src/+log/52.0.2707.0..52.0.2708.0?pretty=fuller&n=10000

Possible suspect : https://codereview.chromium.org/1829403002

Please reassign if this is not related to your change.


 
Project Member

Comment 1 by ClusterFuzz, Apr 14 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5373511907934208

Fuzzer: inferno_webbot
Job Type: android_asan_chrome_x86
Platform Id: android:gce_x86:m

Crash Type: UNKNOWN READ
Crash Address: 0x00000000
Crash State:
  content::WebURLLoaderImpl::setLoadingTaskRunner
  blink::ResourceLoader::start
  blink::Resource::load
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=android_asan_chrome_x86&range=325315:325342

Minimized Testcase (0.09 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97-enaCbTvj9vV_2cIpdOyX-TKK4H61Z5Elu7TEDuhS2pXQRUO7tVhAfZM9x33QdIfLCei5yO-4u1NnL4ANxggqzzs1O5C6pHHUKwlfMY0xgAz8tM_zpGl2ErKj7gcvawaidH4yMCteOhey1m4MdQ6YpyGs5A
<script>
window.open("http://qupid.com");
window.location = "http://voxox.com";</script></html>


Additional requirements: Requires Gestures

Filer: tkonchada

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta
This effects all OS as below
1	Chrome	        77.17%	169	
2	Chrome_Android	15.07%	33	
3	Chrome_ChromeOS	0.46%	1	
4	Chrome_Linux	1.37%	3	
5	Chrome_Mac	5.94%	13	
           Total:	100.00%	219

Canary triggered 8hrs ago. 
Instances are increased. Hence increasing the priority
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 14 2016

Labels: Fracas
Users experienced this crash on the following builds:

Win Canary 52.0.2708.0 -  17.12 CPM, 107 reports, 83 clients (signature content::WebURLLoaderImpl::setLoadingTaskRunner)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Cc: japhet@chromium.org
Labels: -ReleaseBlock-Beta ReleaseBlock-Dev
Owner: dcheng@chromium.org
dcheng@, could you please look into this change (https://chromium.googlesource.com/chromium/src.git/+/c864f52514c7e8cf9992a524e0294b1cc32c1db5) if possible?

This is a top#1 renderer crash on Latest Canary#52.0.2708.0 with '249 crash instances in Win' & '30 crash instances on Mac'.

Thank you!

Comment 5 by dcheng@chromium.org, Apr 14 2016

Cc: -japhet@chromium.org dcheng@chromium.org
Owner: japhet@chromium.org
My patch is a no-op. This looks like it might be https://codereview.chromium.org/1829403002

Comment 6 by keishi@chromium.org, Apr 15 2016

Components: -Blink Blink>Fonts

Comment 8 by japhet@chromium.org, Apr 15 2016

Labels: -Restrict-View-Google -ReleaseBlock-Dev
The CL listed above should fix the crash, so dropping ReleaseBlock.

I'm going to leave this open to track replacing the hacky fix with a better-organized fix.
Project Member

Comment 9 by ClusterFuzz, Apr 16 2016

ClusterFuzz has detected this issue as fixed in range 325844:325861.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5373511907934208

Fuzzer: inferno_webbot
Job Type: android_asan_chrome_x86
Platform Id: android:gce_x86:m

Crash Type: UNKNOWN READ
Crash Address: 0x00000000
Crash State:
  content::WebURLLoaderImpl::setLoadingTaskRunner
  blink::ResourceLoader::start
  blink::Resource::load
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=android_asan_chrome_x86&range=325315:325342
Fixed: https://cluster-fuzz.appspot.com/revisions?job=android_asan_chrome_x86&range=325844:325861

Minimized Testcase (0.09 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv97-enaCbTvj9vV_2cIpdOyX-TKK4H61Z5Elu7TEDuhS2pXQRUO7tVhAfZM9x33QdIfLCei5yO-4u1NnL4ANxggqzzs1O5C6pHHUKwlfMY0xgAz8tM_zpGl2ErKj7gcvawaidH4yMCteOhey1m4MdQ6YpyGs5A
<script>
window.open("http://qupid.com");
window.location = "http://voxox.com";</script></html>


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)
Marking 'Fixed' as per c#9.

Thank you!
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b689eeb4cc9dc5636a8db73c79a2674a154e967

commit 5b689eeb4cc9dc5636a8db73c79a2674a154e967
Author: japhet <japhet@chromium.org>
Date: Thu Jun 09 21:28:03 2016

Refactoring starting a resource load

Move most of Resource::load to a new ResourceFetcher::startLoad,
which is well-positioned to verify that FetchContext is still
valid. This also means that deferred loads call ResourceFetcher
to actually start the load, just as they called ResourceFetcher
to initialize the load.

BUG= 603428 

Review-Url: https://codereview.chromium.org/1889973002
Cr-Commit-Position: refs/heads/master@{#399017}

[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/LayoutTests/http/tests/loading/promote-img-in-viewport-priority-expected.txt
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/LayoutTests/inspector/elements/styles-1/css-outline-expected.txt
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/css/CSSImageValue.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/FetchContext.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceLoader.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ScriptResource.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b689eeb4cc9dc5636a8db73c79a2674a154e967

commit 5b689eeb4cc9dc5636a8db73c79a2674a154e967
Author: japhet <japhet@chromium.org>
Date: Thu Jun 09 21:28:03 2016

Refactoring starting a resource load

Move most of Resource::load to a new ResourceFetcher::startLoad,
which is well-positioned to verify that FetchContext is still
valid. This also means that deferred loads call ResourceFetcher
to actually start the load, just as they called ResourceFetcher
to initialize the load.

BUG= 603428 

Review-Url: https://codereview.chromium.org/1889973002
Cr-Commit-Position: refs/heads/master@{#399017}

[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/LayoutTests/http/tests/loading/promote-img-in-viewport-priority-expected.txt
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/LayoutTests/inspector/elements/styles-1/css-outline-expected.txt
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/css/CSSImageValue.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/FetchContext.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ResourceLoader.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/fetch/ScriptResource.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/5b689eeb4cc9dc5636a8db73c79a2674a154e967/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f550e093c40365f4c2d777e53f0ab1f46ddc6361

commit f550e093c40365f4c2d777e53f0ab1f46ddc6361
Author: gabadie <gabadie@chromium.org>
Date: Tue Jun 21 17:52:29 2016

Fixes blink.net's Resource trace event.

https://codereview.chromium.org/1889973002/ changed the
id of the blink.net's Resource async BEGIN trace event,
but forgot to change the id of the associated END and
STEP_INTO trace event, resulting to bug in trace offline
processing could not pair all the events of the same
resource together.

BUG= 582080 , 603428 

Review-Url: https://codereview.chromium.org/2080663005
Cr-Commit-Position: refs/heads/master@{#401037}

[modify] https://crrev.com/f550e093c40365f4c2d777e53f0ab1f46ddc6361/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Sign in to add a comment