New issue
Advanced search Search tips

Issue 603424 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 436884
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Border of Print preview is not visible

Reported by jshan...@etouch.net, Apr 14 2016

Issue description

Chrome Version: 51.0.2704.7 a8bebc2b0cd3e3018b7c9f6ac698f04dd226abba-refs/branch-heads/2704@{#48} 64 bit
OS: Mac Retina

Steps:
1. Launch Chrome and open NTP.
2. Give Print command and observe the print preview border.

Actual: Border of Print preview is not visible.

Expected: Border of Print preview should be visible.

This is a regression issue broken in M-46, below is bisect info

Good build: 46.0.2479.0
Bad build: 46.0.2480.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/69a68c76ec6d27e8b27eeb0851bbc3247b700a3b..87c301252978ea7b06b95b1ec03f51e4309bd0bc?pretty=fuller&n=100

Blink URL:
https://chromium.googlesource.com/chromium/blink/+log/f2395b6..d47b538?pretty=fuller&n=100

Suspecting: 200333? from blink

Please help to re-assign if your change is not the cause for this issue.

Note: This is Mac Retina-10.11.4 specific issue not seen on other OS like Mac(10.11.4),(10.10.5), Linux and Windows
 
Actual_result.jpg
466 KB View Download
Expected_result.jpg
519 KB View Download
Owner: erikc...@chromium.org
My change was also reverted in this range, so it can't be it. Maybe it's the 10.10 SDK? I could see that changing the default shadow applied to popovers.
Cc: tapted@chromium.org
Seems likely. 

Comment 3 by tapted@chromium.org, Apr 15 2016

Mergedinto: 436884
Status: Duplicate (was: Assigned)
Dang it - my retina macbook usually stays at home. We might just have to call [NSWindow invalidateShadow] at the appropriate time, but I can't test that on my lo-dpi screens. There's a bit more history in  Issue 436884 

Sign in to add a comment