New issue
Advanced search Search tips

Issue 603402 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 583318



Sign in to add a comment

Remove dependency on build/util/version.gypi in build/isolate.gypi (at least for Android)

Project Member Reported by kjellander@chromium.org, Apr 14 2016

Issue description

The dependency on https://code.google.com/p/chromium/codesearch#chromium/src/build/util/version.gypi (which in turn requires a file chrome/VERSION) in Chromium's https://code.google.com/p/chromium/codesearch#chromium/src/build/isolate.gypi makes it hard to reuse this for client projects.

One might argue that client projects shouldn't depend on these things, but from WebRTC's perspective, we've historically been using the Chromium Android test toolchain via https://code.google.com/p/chromium/codesearch#chromium/src/testing/android/native_test.gyp. It's been working well for us until we now started implementing swarming support.
For Android, we get the problem via https://code.google.com/p/chromium/codesearch#chromium/src/base/base.gyp&l=1662, which is loaded when you depend on native_test.gyp.

One workaround for now is to create a dummy chrome/VERSION, but ideally the version stuff shouldn't need to be in the isolate.gypi.
If the version_full variable needs to be passed, maybe it can just have a default value in isolate.gypi instead and be set outside of isolate.gypi instead, for the use cases that needs it.

It seems it was added in https://codereview.chromium.org/140263002 to be able to run chrome.exe on Windows...
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bd30208bc2aa105f34a9abe23f27192c62ae26

commit a4bd30208bc2aa105f34a9abe23f27192c62ae26
Author: kjellander <kjellander@chromium.org>
Date: Thu Apr 14 14:27:24 2016

isolate.gypi: Only load build/util/version.gypi for Windows.

It was added back in https://codereview.chromium.org/140263002 in
order to load chrome.exe on Windows.

BUG= 603402 

Review URL: https://codereview.chromium.org/1891763002

Cr-Commit-Position: refs/heads/master@{#387309}

[modify] https://crrev.com/a4bd30208bc2aa105f34a9abe23f27192c62ae26/build/isolate.gypi

Status: Fixed (was: Untriaged)
The dependency is now there only for Windows, which is the only platform needing it.

Sign in to add a comment