New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603384 link

Starred by 1 user
Status: Fixed
Owner:
benwells@chromium.org
Closed: Jul 2016
Cc:
█ raymes@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add new metrics for permission prompts

Project Member Reported by benwells@chromium.org, Apr 14 2016 
The current metrics don't tell us everything we need to know.

In particular:
- what's the total number of permissions type questions shown, including things like registerProtocolHandler
- understanding, and accounting for coalesced permission prompts
- getting some insight and verification of other lower level metrics which don't seem to be adding up.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d

commit 46b02faec924adb3bdf9d4e62e8d878edc7cdc2d
Author: benwells <benwells@chromium.org>
Date: Wed Apr 20 02:37:02 2016

Add a new metric for how many times permissions prompts are shown.

BUG= 603384 

Review URL: https://codereview.chromium.org/1884073002

Cr-Commit-Position: refs/heads/master@{#388407}

[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/chrome_quota_permission_context.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/download/download_permission_request.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/download/download_permission_request.h
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/permissions/permission_bubble_request_impl.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/permissions/permission_bubble_request_impl.h
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/ui/website_settings/permission_bubble_manager.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/ui/website_settings/permission_bubble_request.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/ui/website_settings/permission_bubble_request.h
[add] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/chrome/browser/ui/website_settings/permission_ui_uma_util.cc
[modify] https://crrev.com/46b02faec924adb3bdf9d4e62e8d878edc7cdc2d/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/893ab263c7a8bfe016013e773d32271b444c47f3

commit 893ab263c7a8bfe016013e773d32271b444c47f3
Author: benwells <benwells@chromium.org>
Date: Wed May 04 20:01:14 2016

Add metrics for coalesced permission prompts.

The metrics track how many requests each prompt contains, and which
types of permission requests are getting merged.

BUG= 603384 

Review-Url: https://codereview.chromium.org/1926003002
Cr-Commit-Position: refs/heads/master@{#391606}

[modify] https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9961477c3819f4fd2ed3ec597287aee83957d709

commit 9961477c3819f4fd2ed3ec597287aee83957d709
Author: benwells <benwells@chromium.org>
Date: Wed May 25 04:20:18 2016

Add metrics for permission prompt acceptance / denial

BUG= 603384 

Review-Url: https://codereview.chromium.org/1977693003
Cr-Commit-Position: refs/heads/master@{#395800}

[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/chrome/browser/ui/website_settings/mock_permission_bubble_request.cc
[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/chrome/browser/ui/website_settings/mock_permission_bubble_request.h
[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/chrome/browser/ui/website_settings/permission_bubble_manager.cc
[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
[delete] https://crrev.com/2c61d9cab028721b5ba37a900747a53775301be2/chrome/browser/ui/website_settings/permission_ui_uma_util.cc
[modify] https://crrev.com/9961477c3819f4fd2ed3ec597287aee83957d709/tools/metrics/histograms/histograms.xml

Comment 5 by benwells@chromium.org, May 25 2016

Labels: M-53

Comment 6 by benwells@chromium.org, May 25 2016

Labels: -M-53 Merge-Request-52 M-52

Comment 7 by tin...@google.com, May 26 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)

Comment 8 by ligim...@chromium.org, May 26 2016 

Please have a the CL merged by EOD tomorrow (05/27), so it gets tested for dev channel scheduled on 06/02.
Project Member

Comment 9 by bugdroid1@chromium.org, May 27 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10cc015f16a368c003ab43d7b8ad75f5bb206d21

commit 10cc015f16a368c003ab43d7b8ad75f5bb206d21
Author: Ben Wells <benwells@chromium.org>
Date: Fri May 27 06:33:18 2016

Add metrics for permission prompt acceptance / denial

BUG= 603384 

Review-Url: https://codereview.chromium.org/1977693003
Cr-Commit-Position: refs/heads/master@{#395800}
(cherry picked from commit 9961477c3819f4fd2ed3ec597287aee83957d709)

Review URL: https://codereview.chromium.org/2017873002 .

Cr-Commit-Position: refs/branch-heads/2743@{#98}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/chrome/browser/ui/website_settings/mock_permission_bubble_request.cc
[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/chrome/browser/ui/website_settings/mock_permission_bubble_request.h
[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/chrome/browser/ui/website_settings/permission_bubble_manager.cc
[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc
[delete] https://crrev.com/c989ff489dfa64c8839fb343276fc463baff6c09/chrome/browser/ui/website_settings/permission_ui_uma_util.cc
[modify] https://crrev.com/10cc015f16a368c003ab43d7b8ad75f5bb206d21/tools/metrics/histograms/histograms.xml

Comment 10 by benwells@chromium.org, Jul 5 2016

Labels: ben-triage-needed

Comment 11 by benwells@chromium.org, Jul 6 2016

Status: Fixed (was: Assigned)
The planned metrics have been in for a while.
►

Sign in to add a comment