New issue
Advanced search Search tips

Issue 603373 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Sign in to add a comment

MacViews: [tracker] "Phase 2": WebUI Cocoa Dialogs

Project Member Reported by tapted@chromium.org, Apr 14 2016

Issue description

Chrome Version       : 51.0.2700.0

See http://go/macviews-release-plan

Tracker bug to wire up the Views versions of WebUI-styled Cocoa dialogs, behind a new --mac-views-webui-dialogs flag. The WebUI-styled Cocoa dialogs are:

 - Collected/blocked cookies UI
 - Device permissions
 - Extension install
 - HTTP auth
 - One-click signin
 - "Card unmask prompt"
 - Website settings dialog

 
Labels: -Hotlist-MacViews Proj-MacViews

Comment 3 by tapted@chromium.org, Apr 21 2016

Blockedon: 605374
Blockedon: 605657
Labels: Phase2
Blocked on 605657 = "Extension install dialog ready to go"

Comment 5 by tapted@chromium.org, May 12 2016

Blockedon: 611280
Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d

commit d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d
Author: tapted <tapted@chromium.org>
Date: Thu May 26 03:26:24 2016

Expose the MacViewsWebUIDialogs feature flag to chrome://flags

Currently it's enabled via --enable=features=MacViewsWebUIDialogs, but
we want to allow changing it in chrome://flags as well.

Replace the old-style --enable-mac-views-dialogs switch for other dialog
types with a feature flag as well to be consistent. Now it is
--enable-features=MacViewsNativeDialogs.

BUG= 603373 

Review-Url: https://codereview.chromium.org/2004043003
Cr-Commit-Position: refs/heads/master@{#396100}

[modify] https://crrev.com/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d/chrome/app/generated_resources.grd
[modify] https://crrev.com/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d/chrome/browser/about_flags.cc
[modify] https://crrev.com/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d/chrome/browser/ui/browser_dialogs_mac.cc
[modify] https://crrev.com/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d1cb0bfdddf26dc5f7d4eb0a8a4c8bcf2f0cee5d/chrome/common/chrome_switches.h

Project Member

Comment 7 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by tapted@chromium.org, Jul 22 2016

Blocking: 630473

Comment 9 by tapted@chromium.org, Jul 25 2016

Blocking: 603386
Blockedon: 623447
Blockedon: 646792
Blockedon: 647574
Blockedon: -564915
Blocking: -603386
Labels: -M-54 M-57
Blockedon: -564914
Labels: -M-57 -MovedFrom-53 MacViews-Dialogs
This bug is obsolete since our launch plan changed, but I'm going to leave it open for bookkeeping purposes.
Status: WontFix (was: Available)
The bugs previously tracked by this bug are now directly included in the bug list, so I'm closing this tracking bug.

Sign in to add a comment