Issue 603369 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	sky@chromium.org
Closed:	Mar 2017
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
mash Proj-Mustash VerifyIn-60 VerifyIn-61

Make mash use ash wm code

Project Member Reported by sky@chromium.org, Apr 14 2016

Issue description

Much of the code in ash/wm is needed for mash. We should create a porting layer so that it can be used with aura or mus.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e30f068fbe64e9bb851981504dd381b5881f38b

commit 1e30f068fbe64e9bb851981504dd381b5881f38b
Author: sky <sky@chromium.org>
Date: Thu Apr 14 21:19:16 2016

WorkspaceLayoutManagerDelegate -> WorkspaceLayoutManagerBackdropDelegate

And adds a WorkspaceLayoutManagerDelegate that is used for fullscreen
and shelf state. I suspect mash won't use ShelfLayoutManager and mash
won't use ash::Shell. WorkspaceLayoutManagerDelegate is intended to
provide said functionality.

BUG= 603369 
TEST=covered by tests
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1888153002

Cr-Commit-Position: refs/heads/master@{#387427}

[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/ash.gyp
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/root_window_controller.cc
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/always_on_top_controller.cc
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/always_on_top_controller_unittest.cc
[add] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/common/workspace/workspace_layout_manager_delegate.h
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/maximize_mode/workspace_backdrop_delegate.h
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/workspace/workspace_layout_manager.h
[rename] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/workspace_controller.cc
[modify] https://crrev.com/1e30f068fbe64e9bb851981504dd381b5881f38b/ash/wm/workspace_controller.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef7e545261b648ee5502d50a468327fd4c00f3e

commit aef7e545261b648ee5502d50a468327fd4c00f3e
Author: sky <sky@chromium.org>
Date: Fri Apr 15 00:22:53 2016

Moves WmEvent to ash/wm/common

TBR as trivial move.

BUG= 603369 
TEST=covered by tests
R=oshima@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1892703002

Cr-Commit-Position: refs/heads/master@{#387489}

[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/ash.gyp
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/frame/caption_buttons/frame_size_button.cc
[rename] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/common/wm_event.cc
[rename] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/common/wm_event.h
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/default_state.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/lock_layout_manager.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/lock_window_state.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/video_detector_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/window_state.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/window_util.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/aef7e545261b648ee5502d50a468327fd4c00f3e/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d5646fee7b3f77b11f6a2365647049c0606445a

commit 8d5646fee7b3f77b11f6a2365647049c0606445a
Author: sky <sky@chromium.org>
Date: Fri Apr 15 17:03:46 2016

Adds WmWindow and converts WindowState to use it

This is the first step in creating a porting layer so that ash/wm can
be used with both mus and aura.

BUG= 603369 
R=oshima@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1890713002

Cr-Commit-Position: refs/heads/master@{#387626}

[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_commands_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_delegate.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/ash.gyp
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/focus_cycler.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/root_window_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shelf/shelf_window_watcher_item_delegate.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/shell/toplevel_window.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/ash_focus_rules_unittest.cc
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/aura/wm_root_window_controller_aura.cc
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/aura/wm_root_window_controller_aura.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/aura/wm_window_aura.cc
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_event.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_root_window_controller.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_screen_util.cc
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_screen_util.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_window.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_window_observer.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/common/wm_window_property.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/default_state.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/drag_details.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/drag_details.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/gestures/shelf_gesture_handler.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/immersive_fullscreen_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/lock_layout_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/lock_window_state.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/panels/panel_window_event_handler.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/resize_shadow_and_cursor_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/stacking_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/video_detector.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/video_detector_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_positioner.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_resizer.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_state.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_state.h
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_state_aura.cc
[add] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_state_aura.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_state_util.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_util.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_util.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/wm_types.h
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/chromeos/events/event_rewriter.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/notifications/fullscreen_notification_blocker.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/accelerator_controller_browsertest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/chrome_views_delegate.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/frame/browser_frame_ash.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/8d5646fee7b3f77b11f6a2365647049c0606445a/components/exo/shell_surface.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ea9033b5df6d83eca85760ef5c284156d13b48b

commit 8ea9033b5df6d83eca85760ef5c284156d13b48b
Author: sky <sky@chromium.org>
Date: Fri Apr 15 18:03:17 2016

Moves WmTypes to ash/wm/common

BUG= 603369 
TEST=none
R=oshima@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1891283002

Cr-Commit-Position: refs/heads/master@{#387641}

[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/ash.gyp
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/common/wm_event.h
[rename] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/common/wm_types.cc
[rename] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/common/wm_types.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/drag_details.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/window_state.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/window_state_observer.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/8ea9033b5df6d83eca85760ef5c284156d13b48b/ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6078624276db684b84b6f1a3c9da536d05012c2

commit d6078624276db684b84b6f1a3c9da536d05012c2
Author: sky <sky@chromium.org>
Date: Fri Apr 15 20:07:41 2016

Adds WmLayoutManager and the aura wrapper AuraLayoutManagerAdapter

No tests as ash_unittests is going to end up testing this by virtue
of converting some of the ash LayoutManagers to be WmLayoutManagers
and installing on aura::Windows.

BUG= 603369 
TEST=none
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1894593002

Cr-Commit-Position: refs/heads/master@{#387686}

[modify] https://crrev.com/d6078624276db684b84b6f1a3c9da536d05012c2/ash/ash.gyp
[add] https://crrev.com/d6078624276db684b84b6f1a3c9da536d05012c2/ash/wm/aura/aura_layout_manager_adapter.cc
[add] https://crrev.com/d6078624276db684b84b6f1a3c9da536d05012c2/ash/wm/aura/aura_layout_manager_adapter.h
[add] https://crrev.com/d6078624276db684b84b6f1a3c9da536d05012c2/ash/wm/common/wm_layout_manager.h

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f9242260c2077161b4c3dd7e14112544c122a97

commit 5f9242260c2077161b4c3dd7e14112544c122a97
Author: sky <sky@chromium.org>
Date: Tue Apr 19 20:36:54 2016

Minor style cleanup in DockedWindowLayoutManager

Moves WindowWithHeight to .cc, removes '_' from struct member names
and removes accessors.

BUG= 603369 
TEST=none
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/1896233002

Cr-Commit-Position: refs/heads/master@{#388299}

[modify] https://crrev.com/5f9242260c2077161b4c3dd7e14112544c122a97/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/5f9242260c2077161b4c3dd7e14112544c122a97/ash/wm/dock/docked_window_layout_manager.h

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984c189ec33e36d863147f278e8f4db10cae691a

commit 984c189ec33e36d863147f278e8f4db10cae691a
Author: sky <sky@chromium.org>
Date: Wed Apr 20 00:00:34 2016

Removes aura dependencies from WindowPositioner

This introduces WmGlobals. I would have liked to not have a static
Get(), but it's necessitated by some places not having
context. Hopefully I can change that later.

I'm not moving WindowPositioner to common yet as it uses
window_state. Once I move that I can move WindowPositioner.

For the time being I'm keeping the tests in ash as they need aura and
I don't want ash/wm/common depending upon aura.

BUG= 603369 
TEST=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1900443002

Cr-Commit-Position: refs/heads/master@{#388366}

[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/accelerators/accelerator_delegate.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/ash.gyp
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/default_user_wallpaper_delegate.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/desktop_background/desktop_background_view.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/shell.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/shell.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/shell/toplevel_window.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/system/toast/toast_overlay.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/system/user/user_view.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/test/ash_test_helper.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/test/cursor_manager_test_api.cc
[add] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/aura/wm_globals_aura.cc
[add] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/aura/wm_window_aura.h
[add] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/common/window_positioning_utils.cc
[add] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/common/window_positioning_utils.h
[add] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/common/wm_globals.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/common/wm_root_window_controller.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/common/wm_window.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/default_state.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_positioner.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_positioner.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_resizer.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_state.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_util.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_util.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/chrome/browser/ui/ash/window_positioner_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/chrome/browser/ui/window_sizer/window_sizer_ash.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/chrome/browser/ui/window_sizer/window_sizer_common_unittest.h
[modify] https://crrev.com/984c189ec33e36d863147f278e8f4db10cae691a/ui/platform_window/win/win_window.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f961b35641fe148963c4d4e3dc061180f56a1bf6

commit f961b35641fe148963c4d4e3dc061180f56a1bf6
Author: sky <sky@chromium.org>
Date: Wed Apr 20 00:53:50 2016

Removes most of aura dependencies from DefaultState

The last remaining bit is for docking, which will come later.

BUG= 603369 
TEST=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1901773002

Cr-Commit-Position: refs/heads/master@{#388385}

[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/ash.gyp
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/root_window_controller.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/aura/wm_window_aura.h
[add] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_animation_types.h
[add] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_parenting_utils.cc
[add] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_parenting_utils.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_positioning_utils.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_positioning_utils.h
[rename] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_state_util.cc
[rename] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/window_state_util.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/wm_globals.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/wm_root_window_controller.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/wm_window.h
[rename] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/common/workspace/workspace_types.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/default_state.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/lock_window_state.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/window_animations.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/window_animations.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/window_util.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/window_util.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/workspace_controller.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/ash/wm/workspace_controller.h
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc
[modify] https://crrev.com/f961b35641fe148963c4d4e3dc061180f56a1bf6/chrome/browser/ui/ash/solid_color_user_wallpaper_delegate.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d587a661ed37629f2809e526c0cbfd4869ff92

commit a6d587a661ed37629f2809e526c0cbfd4869ff92
Author: sky <sky@chromium.org>
Date: Wed Apr 20 02:58:05 2016

Removes most aura dependencies from WindowResizer

Last remaining one is for DockedWindowLayoutManager, which will be
converted later.

BUG= 603369 
TEST=covered by other tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1898223002

Cr-Commit-Position: refs/heads/master@{#388414}

[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/ash.gyp
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/display/screen_ash.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/display/screen_position_controller.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/display/shared_display_edge_indicator.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/drag_drop/drag_drop_tracker.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/drag_drop/drag_drop_tracker.h
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/screen_util.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/shelf/shelf_view.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/shell.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/aura/wm_root_window_controller_aura.h
[add] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/common/root_window_finder.cc
[rename] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/common/root_window_finder.h
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/common/wm_globals.h
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/common/wm_root_window_controller.h
[delete] https://crrev.com/6a18734145371ec315fb356119e63fb3c0661437/ash/wm/coordinate_conversion.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/default_window_resizer.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/default_window_resizer.h
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/stacking_controller.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/window_resizer.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/window_resizer.h
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/a6d587a661ed37629f2809e526c0cbfd4869ff92/chrome/browser/ui/views/tabs/window_finder_ash.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/085a2833a750add15969c26819dfafd1ec610ebe

commit 085a2833a750add15969c26819dfafd1ec610ebe
Author: sky <sky@chromium.org>
Date: Wed Apr 20 19:40:46 2016

Makes aura::LayoutManager be destroyed before properties

I want to store some state in properties that needs to be valid from
the LayoutManagers destructor. This means the LayoutManager needs to
be destroyed before owned properties.

BUG= 603369 
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1910483002

Cr-Commit-Position: refs/heads/master@{#388556}

[modify] https://crrev.com/085a2833a750add15969c26819dfafd1ec610ebe/ui/aura/window.cc
[modify] https://crrev.com/085a2833a750add15969c26819dfafd1ec610ebe/ui/aura/window_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bfa2cfa9b8f568db97602926871f48afabf16bf

commit 6bfa2cfa9b8f568db97602926871f48afabf16bf
Author: sky <sky@chromium.org>
Date: Wed Apr 20 20:08:50 2016

Removes most aura dependencies from DockedWindowResizer

Remaining dependencies are necessitated by DockedWindowLayoutManager.

BUG= 603369 
TEST=covered by other tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1901593004

Cr-Commit-Position: refs/heads/master@{#388564}

[modify] https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf/ash/wm/common/wm_window.h
[modify] https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/6bfa2cfa9b8f568db97602926871f48afabf16bf/ash/wm/dock/docked_window_resizer.h

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7af881b9e91331d387ea22c63db69b99e46836

commit 3f7af881b9e91331d387ea22c63db69b99e46836
Author: sky <sky@chromium.org>
Date: Thu Apr 21 19:30:03 2016

Converts DockedWindowLayoutManager to common ash/wm types

There are still a couple of aura specific values here
(ShellObserver). I will tackle that next.

BUG= 603369 
TEST=none
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/1907863002

Cr-Commit-Position: refs/heads/master@{#388847}

[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/ash.gyp
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/root_window_controller.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/shell.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/aura_layout_manager_adapter.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/aura/wm_window_aura.h
[add] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_activation_observer.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_globals.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_root_window_controller.h
[add] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_snap_to_pixel_layout_manager.cc
[add] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_snap_to_pixel_layout_manager.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_window.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/common/wm_window_observer.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/default_state.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/window_resizer.cc
[modify] https://crrev.com/3f7af881b9e91331d387ea22c63db69b99e46836/ash/wm/workspace/workspace_window_resizer.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f528c0c5fa5e60ace877d7a6981bf08d7e93540

commit 4f528c0c5fa5e60ace877d7a6981bf08d7e93540
Author: sky <sky@chromium.org>
Date: Fri Apr 22 16:51:01 2016

Converts DockedWindowLayoutManager to use WmRootWindowControllerObserver

And removes the last bit of aura and shell it was using.

BUG= 603369 
TEST=covered by tests
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/1911833002

Cr-Commit-Position: refs/heads/master@{#389141}

[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/ash.gyp
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/common/wm_root_window_controller.h
[add] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/common/wm_root_window_controller_observer.h
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/common/wm_window.h
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/4f528c0c5fa5e60ace877d7a6981bf08d7e93540/ash/wm/dock/docked_window_layout_manager.h

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f

commit 5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f
Author: sky <sky@chromium.org>
Date: Fri Apr 22 22:11:24 2016

Makes WorkspaceWindowResizer use ash/wm/common types

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/1913473002

Cr-Commit-Position: refs/heads/master@{#389263}

[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/ash.gyp
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/common/wm_globals.h
[add] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/common/wm_window_tracker.h
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/window_resizer.h
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/workspace/workspace_window_resizer.h
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f/components/exo/shell_surface.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0f419e6b05cc72dee473ef7145c976dd93b930

commit ef0f419e6b05cc72dee473ef7145c976dd93b930
Author: sky <sky@chromium.org>
Date: Fri Apr 22 23:32:57 2016

Makes PhantonWindowController use ash/wm/common types

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1909273003

Cr-Commit-Position: refs/heads/master@{#389299}

[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/wm/common/wm_window.h
[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/wm/workspace/phantom_window_controller.h
[modify] https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930/ash/wm/workspace/workspace_window_resizer.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad031502362573a9fe05c53c8f0776e5f7009dba

commit ad031502362573a9fe05c53c8f0776e5f7009dba
Author: sky <sky@chromium.org>
Date: Mon Apr 25 19:40:31 2016

Makes Panel related classes use ash/wm/common types

Specifically the layoutmanager and windowresizer implementations. And
this removes GetAuraTarget() from WmWindowResizer.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1918883002

Cr-Commit-Position: refs/heads/master@{#389540}

[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/ash.gyp
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/root_window_controller.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/aura/wm_window_aura.h
[add] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/common/wm_display_observer.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/common/wm_globals.h
[add] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/common/wm_overview_mode_observer.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/common/wm_window.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/common/wm_window_property.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/drag_window_resizer.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/panels/panel_window_resizer.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/window_resizer.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/window_resizer.h
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba/ash/wm/workspace_controller_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b

commit ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b
Author: sky <sky@chromium.org>
Date: Tue Apr 26 04:47:57 2016

Removes WindowState::aura_window()

And minimizes dependencies in a couple of other places.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1921883002

Cr-Commit-Position: refs/heads/master@{#389698}

[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/root_window_controller.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/shell.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/common/root_window_finder.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/common/window_state_util.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/common/wm_window.h
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/common/wm_window_tracker.h
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/default_state.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/default_state.h
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/lock_window_state.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/window_resizer.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/window_state.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/window_state.h
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/ca4122695afc6d3aeb1b27df91b64fcf3ebfc77b/chrome/browser/ui/window_sizer/window_sizer_ash.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019ff29c7c3a1725571d7b3b67cf908a08f32ffc

commit 019ff29c7c3a1725571d7b3b67cf908a08f32ffc
Author: sky <sky@chromium.org>
Date: Tue Apr 26 19:40:59 2016

Refactors DockedWindowLayoutManager in terms of ash/wm/common

Last remaining bit is shell ids.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1914093002

Cr-Commit-Position: refs/heads/master@{#389852}

[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/ash.gyp
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/mus/shelf_delegate_mus.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/root_window_controller.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/app_list_button.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/overflow_button.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_alignment_menu.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_button.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_constants.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_constants.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_layout_manager_observer.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_locking_manager.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_locking_manager.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_locking_manager_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_types.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_util.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_util.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_widget.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shell.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/shell.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/cast/tray_cast.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/network/tray_network.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/network/tray_vpn.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/power/tray_power.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/date/tray_date.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/date/tray_date.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/status_area_widget.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/status_area_widget.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/status_area_widget_delegate.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/system_tray.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/system_tray.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/system_tray_item.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/tray/tray_utils.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/user/tray_user.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/user/tray_user.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/user/tray_user_separator.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/aura/wm_root_window_controller_aura.h
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/aura/wm_shelf_aura.cc
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/aura/wm_shelf_aura.h
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/common/shelf/wm_shelf.h
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/common/shelf/wm_shelf_constants.cc
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/common/shelf/wm_shelf_constants.h
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/common/shelf/wm_shelf_observer.h
[add] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/common/shelf/wm_shelf_types.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/common/wm_root_window_controller.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/window_animations.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/chrome/browser/chromeos/first_run/steps/tray_step.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/chrome/browser/ui/ash/chrome_launcher_prefs.h
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc
[modify] https://crrev.com/019ff29c7c3a1725571d7b3b67cf908a08f32ffc/mash/shelf/public/interfaces/shelf_constants.mojom

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b856eb2b11c1894a1240a7026414b1a3800606d7

commit b856eb2b11c1894a1240a7026414b1a3800606d7
Author: sky <sky@chromium.org>
Date: Tue Apr 26 21:13:25 2016

Starts splitting out shell window ids

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1920153003

Cr-Commit-Position: refs/heads/master@{#389884}

[modify] https://crrev.com/b856eb2b11c1894a1240a7026414b1a3800606d7/ash/shell_window_ids.h
[add] https://crrev.com/b856eb2b11c1894a1240a7026414b1a3800606d7/ash/wm/common/wm_shell_window_ids.h
[modify] https://crrev.com/b856eb2b11c1894a1240a7026414b1a3800606d7/ash/wm/common/wm_window.h
[modify] https://crrev.com/b856eb2b11c1894a1240a7026414b1a3800606d7/ash/wm/dock/docked_window_layout_manager.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75677b509555d99657d0b6f5570587b5c8dc1610

commit 75677b509555d99657d0b6f5570587b5c8dc1610
Author: sky <sky@chromium.org>
Date: Tue Apr 26 22:41:59 2016

Moves handful of files to ash/wm/common

These files are now ash and ui/aura/Window free.
Also adds DEPS file to make sure don't add dependencies back. I didn't
updated namespaces, will do that separately.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/1921353002

Cr-Commit-Position: refs/heads/master@{#389927}

[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_commands_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_delegate.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/ash.gyp
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/display/screen_position_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/focus_cycler.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/frame/default_header_painter_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/frame/frame_border_hit_test_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/root_window_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_layout_manager_observer.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_widget.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_window_watcher_item_delegate.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/shell/toplevel_window.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/aura/wm_window_aura.cc
[add] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/DEPS
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/background_animator.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/background_animator.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/default_state.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/default_state.h
[add] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/dock/dock_types.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/dock/docked_window_layout_manager.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/dock/docked_window_layout_manager.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/dock/docked_window_layout_manager_observer.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/drag_details.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/drag_details.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/shelf/wm_shelf_observer.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_resizer.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_resizer.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_state.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_state.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_state_delegate.cc
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_state_delegate.h
[rename] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_state_observer.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/common/window_state_util.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/default_window_resizer.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/default_window_resizer.h
[delete] https://crrev.com/0950cefe4e9c89fd11c4077123b9084c8173fdd9/ash/wm/dock/dock_types.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/dock/docked_window_resizer.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/drag_window_resizer.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/gestures/shelf_gesture_handler.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/immersive_fullscreen_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/lock_layout_manager.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/lock_window_state.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/lock_window_state.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/maximize_mode/maximize_mode_window_manager.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/maximize_mode/maximize_mode_window_state.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/mru_window_tracker.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/mru_window_tracker_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_window_event_handler.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_window_resizer.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/resize_handle_window_targeter.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/resize_shadow_and_cursor_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/stacking_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/video_detector.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/video_detector_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_cycle_list.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_positioner.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_properties.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_state_aura.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_util.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_window_resizer.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/chromeos/events/event_rewriter.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/notifications/fullscreen_notification_blocker.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/accelerator_controller_browsertest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/ash/window_positioner_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/chrome_views_delegate.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/frame/browser_frame_ash.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/status_bubble_views.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/window_sizer/window_sizer_ash.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/components/exo/shell_surface.cc
[modify] https://crrev.com/75677b509555d99657d0b6f5570587b5c8dc1610/components/exo/shell_surface.h

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f19e8f16f92ff230944da6bb451e1553e0615a

commit e6f19e8f16f92ff230944da6bb451e1553e0615a
Author: sky <sky@chromium.org>
Date: Wed Apr 27 00:11:48 2016

Moves DefaultWindowResizer to common.

And nukes unnecessary include.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1921973004

Cr-Commit-Position: refs/heads/master@{#389950}

[modify] https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a/ash/ash.gyp
[rename] https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a/ash/wm/common/default_window_resizer.cc
[rename] https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a/ash/wm/common/default_window_resizer.h
[modify] https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/e6f19e8f16f92ff230944da6bb451e1553e0615a/ash/wm/workspace/workspace_window_resizer.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f216cf9913e98a67270ac36b451a9291cdeb3fc

commit 9f216cf9913e98a67270ac36b451a9291cdeb3fc
Author: sky <sky@chromium.org>
Date: Wed Apr 27 02:48:19 2016

Moves DefaultContainer and PanelContainer to wm_shell_window_ids

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1921423002

Cr-Commit-Position: refs/heads/master@{#389976}

[modify] https://crrev.com/9f216cf9913e98a67270ac36b451a9291cdeb3fc/ash/shell_window_ids.h
[modify] https://crrev.com/9f216cf9913e98a67270ac36b451a9291cdeb3fc/ash/wm/common/wm_shell_window_ids.h
[modify] https://crrev.com/9f216cf9913e98a67270ac36b451a9291cdeb3fc/ash/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/9f216cf9913e98a67270ac36b451a9291cdeb3fc/ash/wm/workspace/workspace_window_resizer.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dc7d0496343775c344899a2ad5742865f81a93b

commit 4dc7d0496343775c344899a2ad5742865f81a93b
Author: sky <sky@chromium.org>
Date: Thu Apr 28 04:15:22 2016

Makes WorkspaceLayoutManager use ash/wm/common types

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1923983003
Cr-Commit-Position: refs/heads/master@{#390297}

[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/ash.gyp
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/root_window_controller.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/shell_window_ids.h
[delete] https://crrev.com/452ce11289633ebc3e5b1fffe17d99702bef6496/ash/switchable_windows.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/always_on_top_controller.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/always_on_top_controller.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/aura/wm_window_aura.h
[add] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/fullscreen_window_finder.cc
[add] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/fullscreen_window_finder.h
[add] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/switchable_windows.cc
[rename] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/switchable_windows.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_globals.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_root_window_controller.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_screen_util.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_screen_util.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_shell_window_ids.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_window.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/common/wm_window_observer.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/maximize_mode/workspace_backdrop_delegate.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/maximize_mode/workspace_backdrop_delegate.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/mru_window_tracker.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/stacking_controller.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/workspace_controller.cc
[modify] https://crrev.com/4dc7d0496343775c344899a2ad5742865f81a93b/ash/wm/workspace_controller.h

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f50fdc4f34f4893640554620c86d600ce0a129c

commit 2f50fdc4f34f4893640554620c86d600ce0a129c
Author: sky <sky@chromium.org>
Date: Thu Apr 28 05:56:13 2016

Moves more code to ash/wm/common

These classes all only depend upon ash/wm/common

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/1926913002
Cr-Commit-Position: refs/heads/master@{#390311}

[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/ash.gyp
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/root_window_controller.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/shell.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/shell/toplevel_window.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/test/ash_test_base.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/always_on_top_controller_unittest.cc
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/always_on_top_controller.cc
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/always_on_top_controller.h
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/window_positioner.cc
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/window_positioner.h
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/workspace/workspace_layout_manager.cc
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/workspace/workspace_layout_manager.h
[rename] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/common/workspace/workspace_layout_manager_backdrop_delegate.h
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/maximize_mode/workspace_backdrop_delegate.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/maximize_mode/workspace_backdrop_delegate.h
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/stacking_controller.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/ash/wm/workspace_controller.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/chrome/browser/ui/ash/window_positioner_unittest.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/chrome/browser/ui/window_sizer/window_sizer.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/chrome/browser/ui/window_sizer/window_sizer_ash.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/2f50fdc4f34f4893640554620c86d600ce0a129c/components/exo/touch_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa1ae588e0fcda6bda31557a32b4848d8018530a

commit fa1ae588e0fcda6bda31557a32b4848d8018530a
Author: sadrul <sadrul@chromium.org>
Date: Fri Apr 29 00:03:07 2016

mus/ash: WmRootWindowController can be null in mus.

ash_sysui ideally wouldn't need to create the ShelfLayoutManager, but it's too
deeply ingrained to take out right now. When running in ash_sysui, the shelf
widget's 'root window' is not one of the root-windows ash::Shell instance knows
about, so it doesn't have a WmRootWindowController. So check for its existence
before adding an observer to it.

BUG= 603369 
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/1916913007
Cr-Commit-Position: refs/heads/master@{#390541}

[modify] https://crrev.com/fa1ae588e0fcda6bda31557a32b4848d8018530a/ash/shelf/shelf_layout_manager.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9a6deb3e1eed2ce58db453df82d61a35e645a8a

commit a9a6deb3e1eed2ce58db453df82d61a35e645a8a
Author: sky <sky@chromium.org>
Date: Fri Apr 29 01:15:38 2016

Refactors WindowResizers to use ash/wm/common

And some support classes that need to be moved to common as well.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1929023002
Cr-Commit-Position: refs/heads/master@{#390551}

[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/ash.gyp
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/metrics/user_metrics_recorder.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/root_window_controller.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shelf/shelf.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shelf/shelf_types.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shelf/shelf_util.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shelf/shelf_util.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/shell_window_ids.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/date/tray_date.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/tray/system_tray.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/tray/tray_item_view.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/user/tray_user.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/aura/wm_shelf_aura.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/aura/wm_shelf_aura.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/shelf/wm_shelf.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/shelf/wm_shelf_observer.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/shelf/wm_shelf_types.h
[add] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/shelf/wm_shelf_util.cc
[add] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/shelf/wm_shelf_util.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/wm_globals.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/wm_shell_window_ids.h
[add] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/common/wm_user_metrics_action.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/a9a6deb3e1eed2ce58db453df82d61a35e645a8a/ash/wm/workspace/workspace_window_resizer.cc

Project Member

Comment 27 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a737f30a0f5426c1c0da7a58f18a6b18563ced

commit 28a737f30a0f5426c1c0da7a58f18a6b18563ced
Author: sky <sky@chromium.org>
Date: Mon May 02 15:44:31 2016

Moves windowsresizers to ash/wm/common

And supporting code needed for the resizers/layoutmanagers.

BUG= 603369 
TEST=covered by tests

Review-Url: https://codereview.chromium.org/1933303002
Cr-Commit-Position: refs/heads/master@{#390953}

[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/ash.gyp
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/root_window_controller.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/dock/docked_window_resizer.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/dock/docked_window_resizer.h
[add] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/panels/OWNERS
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/panels/panel_layout_manager.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/panels/panel_layout_manager.h
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/panels/panel_window_resizer.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/panels/panel_window_resizer.h
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/magnetism_matcher.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/magnetism_matcher.h
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/phantom_window_controller.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/phantom_window_controller.h
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/two_step_edge_cycler.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/two_step_edge_cycler.h
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/workspace_window_resizer.cc
[rename] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/common/workspace/workspace_window_resizer.h
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/workspace/magnetism_matcher_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/28a737f30a0f5426c1c0da7a58f18a6b18563ced/ash/wm/workspace_controller_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff6a8ce84327c9b0b89e669258db5ef7454bbcef

commit ff6a8ce84327c9b0b89e669258db5ef7454bbcef
Author: sky <sky@chromium.org>
Date: Mon May 02 21:15:38 2016

Refactors MultiWindowResizeController to use ash/wm/common

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1936223002
Cr-Commit-Position: refs/heads/master@{#391050}

[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/ash.gyp
[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/common/wm_root_window_controller.h
[rename] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/common/workspace/multi_window_resize_controller.cc
[rename] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/common/workspace/multi_window_resize_controller.h
[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/ff6a8ce84327c9b0b89e669258db5ef7454bbcef/ash/wm/workspace/workspace_event_handler.h

Project Member

Comment 29 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e75ae988eae1ac44cd1eb7082addd4208707cf

commit 56e75ae988eae1ac44cd1eb7082addd4208707cf
Author: sky <sky@chromium.org>
Date: Tue May 03 21:12:24 2016

Nukes WmWindow::SetName()

Instead it should be passed through InitParams.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1950573002
Cr-Commit-Position: refs/heads/master@{#391355}

[modify] https://crrev.com/56e75ae988eae1ac44cd1eb7082addd4208707cf/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/56e75ae988eae1ac44cd1eb7082addd4208707cf/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/56e75ae988eae1ac44cd1eb7082addd4208707cf/ash/wm/common/wm_window.h
[modify] https://crrev.com/56e75ae988eae1ac44cd1eb7082addd4208707cf/ash/wm/common/workspace/phantom_window_controller.cc

Project Member

Comment 30 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c77113596b97c9d7687f1489465465643ca057e

commit 1c77113596b97c9d7687f1489465465643ca057e
Author: sky <sky@chromium.org>
Date: Wed May 04 03:12:58 2016

Makes ash/wm/common a library

I had a handful of functions that won't work as a library, so I had to
add a WmLookup to handle the mapping.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org
TBR=garykac@chromium.org

Review-Url: https://codereview.chromium.org/1943603002
Cr-Commit-Position: refs/heads/master@{#391431}

[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/BUILD.gn
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/ash.gyp
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_globals_aura.h
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_lookup_aura.cc
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_lookup_aura.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_shelf_aura.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/aura/wm_window_aura.h
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/BUILD.gn
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/DEPS
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/always_on_top_controller.h
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/ash_wm_common.gyp
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/ash_wm_common_export.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/background_animator.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/default_window_resizer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/dock/docked_window_layout_manager.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/dock/docked_window_layout_manager_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/dock/docked_window_resizer.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/dock/docked_window_resizer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/drag_details.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/fullscreen_window_finder.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/panels/panel_layout_manager.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/panels/panel_layout_manager.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/panels/panel_window_resizer.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/panels/panel_window_resizer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/root_window_finder.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/root_window_finder.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/shelf/wm_shelf.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/shelf/wm_shelf_constants.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/shelf/wm_shelf_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/shelf/wm_shelf_util.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/switchable_windows.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_animation_types.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_parenting_utils.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_positioner.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_positioning_utils.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_resizer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_state.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_state_delegate.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_state_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/window_state_util.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_activation_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_display_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_event.h
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_globals.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_globals.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_layout_manager.h
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_lookup.cc
[add] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_lookup.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_overview_mode_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_root_window_controller.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_root_window_controller_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_screen_util.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_shell_window_ids.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_snap_to_pixel_layout_manager.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_types.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_window.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_window_observer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/wm_window_property.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/magnetism_matcher.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/multi_window_resize_controller.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/phantom_window_controller.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/phantom_window_controller.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/two_step_edge_cycler.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/workspace_layout_manager.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/workspace_layout_manager_backdrop_delegate.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/workspace_layout_manager_delegate.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/common/workspace/workspace_window_resizer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/drag_window_resizer.h
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/ash/wm/window_state_aura.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/chrome/browser/ui/ash/window_positioner_unittest.cc
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/chrome/chrome_browser_ui_views.gyp
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/components/exo.gypi
[modify] https://crrev.com/1c77113596b97c9d7687f1489465465643ca057e/remoting/remoting_host.gypi

Project Member

Comment 31 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cd4549a5a5e04deffc3780ecc52d52b0ea685f0

commit 2cd4549a5a5e04deffc3780ecc52d52b0ea685f0
Author: sky <sky@chromium.org>
Date: Thu May 05 00:03:10 2016

Removes unnecessary function in WmWindow

This become unnecessary at some point, but was never removed.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1949113003
Cr-Commit-Position: refs/heads/master@{#391704}

[modify] https://crrev.com/2cd4549a5a5e04deffc3780ecc52d52b0ea685f0/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/2cd4549a5a5e04deffc3780ecc52d52b0ea685f0/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/2cd4549a5a5e04deffc3780ecc52d52b0ea685f0/ash/wm/common/wm_window.h

Project Member

Comment 32 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab

commit cb51abf81b0437f5768d1b1de48f41d6e8bc1fab
Author: sky <sky@chromium.org>
Date: Thu May 05 18:24:48 2016

Refactors StackingController::GetDefaultParent to ash/wm/common

This way I can use it in mus too.

I'm not clear that the windowmanager should handle system modals or
lock screen stuff. But for the near term we likely need it for sys_ui.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1954523002
Cr-Commit-Position: refs/heads/master@{#391847}

[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/root_window_controller.cc
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/root_window_controller.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/shell_window_ids.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/BUILD.gn
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/ash_wm_common.gyp
[add] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/container_finder.cc
[add] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/container_finder.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/wm_globals.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/wm_shell_window_ids.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/common/wm_window.h
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/stacking_controller.cc
[modify] https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab/ash/wm/stacking_controller.h

Project Member

Comment 33 by bugdroid1@chromium.org, May 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99526c41079e7de62a26a9c2cb9619a78f4df60a

commit 99526c41079e7de62a26a9c2cb9619a78f4df60a
Author: sky <sky@chromium.org>
Date: Sat May 07 00:03:27 2016

Initial cut of ash/wm/common classes for mus

Tons of NOTIMPLEMENTS, but the basics are there. This is not wired to
anything yet.

BUG= 603369 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1954933002
Cr-Commit-Position: refs/heads/master@{#392210}

[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/components/mus/public/interfaces/window_manager_constants.mojom
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/BUILD.gn
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/DEPS
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/mus_layout_manager_adapter.cc
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/mus_layout_manager_adapter.h
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_globals_mus.cc
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_globals_mus.h
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_lookup_mus.cc
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_lookup_mus.h
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_root_window_controller_mus.cc
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_root_window_controller_mus.h
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_window_mus.cc
[add] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/bridge/wm_window_mus.h
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/property_util.cc
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/property_util.h
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/public/interfaces/container.mojom
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/root_window_controller.cc
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/root_window_controller.h
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/mash/wm/window_layout.cc
[modify] https://crrev.com/99526c41079e7de62a26a9c2cb9619a78f4df60a/ui/views/mus/platform_window_mus.cc

Project Member

Comment 34 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b444acaa9b30c266084bb42b4dbb91f34bc13f00

commit b444acaa9b30c266084bb42b4dbb91f34bc13f00
Author: msw <msw@chromium.org>
Date: Mon May 09 20:32:11 2016

Fix mash shelf alignment change layout regression.

Perform ShelfLayout when the alignment changes in mash.
Fixes a regression from https://codereview.chromium.org/1923983003

BUG= 603369 
TEST=Mash shelf lays out correctly after alignment changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/1964633002
Cr-Commit-Position: refs/heads/master@{#392415}

[modify] https://crrev.com/b444acaa9b30c266084bb42b4dbb91f34bc13f00/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b444acaa9b30c266084bb42b4dbb91f34bc13f00/ash/shelf/shelf_layout_manager.h

Comment 35 by mfomitchev@chromium.org, May 12 2016

Labels: -mustash mash

Project Member

Comment 36 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a86a4fa7177958444cf81a0678859387c1ea738

commit 9a86a4fa7177958444cf81a0678859387c1ea738
Author: sky <sky@chromium.org>
Date: Fri May 13 22:03:26 2016

Changes container names and adds a couple of more

I think these names help clarify containment a bit more than the old
names. The new ones are to mirror those of ash.

This also adds mapping between ash ids and mash ids and centralizes
containers that can have active children.

BUG= 603369 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1980593002
Cr-Commit-Position: refs/heads/master@{#393656}

[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/ash/mus/sysui_application.cc
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/BUILD.gn
[add] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/container_ids.cc
[add] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/container_ids.h
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/property_util.cc
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/public/interfaces/container.mojom
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/root_window_controller.cc
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/root_window_controller.h
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/user_window_controller_impl.cc
[modify] https://crrev.com/9a86a4fa7177958444cf81a0678859387c1ea738/mash/wm/window_manager.cc

Project Member

Comment 37 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79157b8712eec171942e96021fcfd0f363e06631

commit 79157b8712eec171942e96021fcfd0f363e06631
Author: sky <sky@chromium.org>
Date: Mon May 16 23:11:46 2016

Copies workspace_layout_manager_unittest to mash

This is a straight copy (minus some includes not allowed by DEPS), and
it doesn't run. I'm copying this separately to make it easy to see
what changes as I get tests in this file working.

BUG= 603369 
TEST=none
R=jamescook@chromium.org
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1987473002
Cr-Commit-Position: refs/heads/master@{#393971}

[add] https://crrev.com/79157b8712eec171942e96021fcfd0f363e06631/mash/wm/workspace/workspace_layout_manager_unittest.cc

Project Member

Comment 38 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/990b86fe4ea3085e6df6dd58316a2d2c34aad241

commit 990b86fe4ea3085e6df6dd58316a2d2c34aad241
Author: sky <sky@chromium.org>
Date: Tue May 17 18:13:18 2016

Random fixes for mash bridge classes

. MusLayoutManagerAdapter wasn't installed observer correctly
. Updated set of activation parents.
. WmGlobalMus::GetTopLevelAncestor consults set of activation parents.
. WmGlobalMus deals with WindowTreeConnection being deleted while alive.
. WmLookupMus installs itself as the WmLookup.
. WmRootWindowController lookup key is no longer owned (it'll be owned by
  RootController).
. Added WmRootWindowController::NotifyFullscreenStatechanged().
. Wired up WmRootWindowControllerMus observers.
. Changed WmWindowMus shell ids to be stored in WmWindowMus rather than use
  mus::Window's local_id. This way it doesn't conflict with other code that
  wants to use the local id (we store the container in the local id).
. Route WmWindowMus::SetBounds() to the layutmanager appropriately.
. WmWindowMus::GetboundsInScreen() was including the bounds of 'this' resulting
  in double counting the initial offset.
. WmWindowMus::Activate() moves to front.
. WmWindowMus::OnWindowReordered() was notifying the wrong observers.
. WmWindowMus::OnWindowSharedPropertyChanged now calls to WindowState

R=jamescook@chromium.org
BUG= 603369 
TEST=none

Review-Url: https://codereview.chromium.org/1984293002
Cr-Commit-Position: refs/heads/master@{#394170}

[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/components/mus/public/cpp/lib/window_tree_client_impl.cc
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/components/mus/public/cpp/window_tree_connection_observer.h
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/mus_layout_manager_adapter.cc
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_globals_mus.cc
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_globals_mus.h
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_lookup_mus.cc
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_root_window_controller_mus.h
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_window_mus.cc
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/bridge/wm_window_mus.h
[modify] https://crrev.com/990b86fe4ea3085e6df6dd58316a2d2c34aad241/mash/wm/container_ids.cc

Project Member

Comment 39 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afbf7c1f9178c11282c278b7e93f8cb3922b712

commit 7afbf7c1f9178c11282c278b7e93f8cb3922b712
Author: sky <sky@chromium.org>
Date: Tue May 17 23:07:42 2016

Refactors std::vector<Display> out of ScreenMus

This way it's easier to have a test based version that uses similar
code, which I've added here too.

BUG= 603369 
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/1984393002
Cr-Commit-Position: refs/heads/master@{#394259}

[modify] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/mash/wm/BUILD.gn
[add] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/mash/wm/test/DEPS
[add] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/mash/wm/test/wm_test_screen.cc
[add] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/mash/wm/test/wm_test_screen.h
[modify] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/ui/views/mus/BUILD.gn
[add] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/ui/views/mus/display_list.cc
[add] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/ui/views/mus/display_list.h
[add] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/ui/views/mus/display_list_unittest.cc
[modify] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/7afbf7c1f9178c11282c278b7e93f8cb3922b712/ui/views/mus/screen_mus.h

Project Member

Comment 40 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc7d5f22d91a58426dd4de55f5c1117eb71c3919

commit fc7d5f22d91a58426dd4de55f5c1117eb71c3919
Author: sky <sky@chromium.org>
Date: Wed May 18 00:11:53 2016

Creates mus test helper class

Moves class that sets up WindowTreeClientImpl that doesn't talk to mus
to helper so other tests can use it.

BUG= 603369 
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/1983243002
Cr-Commit-Position: refs/heads/master@{#394276}

[modify] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/lib/window_tree_client_impl.cc
[modify] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/tests/BUILD.gn
[add] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/tests/test_window_tree_connection_setup.cc
[add] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/tests/test_window_tree_connection_setup.h
[add] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/tests/window_tree_client_impl_private.cc
[add] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/tests/window_tree_client_impl_private.h
[modify] https://crrev.com/fc7d5f22d91a58426dd4de55f5c1117eb71c3919/components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc

Project Member

Comment 41 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ad2a6e51685cab37866676afcec388c066f30fa

commit 5ad2a6e51685cab37866676afcec388c066f30fa
Author: sky <sky@chromium.org>
Date: Wed May 18 00:29:33 2016

Makes mus::Window and mash::wm::WmWindowMus notify existing observers only

This matches what we do in aura, and is causing problems if I do otherwise.

BUG= 603369 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1983343002
Cr-Commit-Position: refs/heads/master@{#394283}

[modify] https://crrev.com/5ad2a6e51685cab37866676afcec388c066f30fa/components/mus/public/cpp/lib/window.cc
[modify] https://crrev.com/5ad2a6e51685cab37866676afcec388c066f30fa/mash/wm/bridge/wm_window_mus.cc

Project Member

Comment 42 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88028961efbe33410aa37e21160bf2bdbcec0a8b

commit 88028961efbe33410aa37e21160bf2bdbcec0a8b
Author: sky <sky@chromium.org>
Date: Wed May 18 19:17:06 2016

Creates mus implementation of WmShelf

At this point it's just a stub.

BUG= 603369 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/1991553002
Cr-Commit-Position: refs/heads/master@{#394497}

[modify] https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b/mash/wm/BUILD.gn
[add] https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b/mash/wm/bridge/wm_shelf_mus.cc
[add] https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b/mash/wm/bridge/wm_shelf_mus.h
[modify] https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b/mash/wm/shelf_layout_manager.cc
[modify] https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b/mash/wm/shelf_layout_manager.h

Project Member

Comment 43 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/383d818f80838a60c4e9655836f1b243f83ea6ce

commit 383d818f80838a60c4e9655836f1b243f83ea6ce
Author: sky <sky@chromium.org>
Date: Thu May 19 22:34:02 2016

Wires up WorkspaceLayoutManager in mash

Along with enabling a portion of the tests.

BUG= 603369 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1994763002
Cr-Commit-Position: refs/heads/master@{#394887}

[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/components/mus/public/interfaces/window_manager.mojom
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/BUILD.gn
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/test/mash_test_suite.cc
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/test/mash_test_suite.h
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/test/mash_unittests.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/BUILD.gn
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/bridge/wm_window_mus.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/frame/non_client_frame_view_mash.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/non_client_frame_controller.h
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/property_util.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/property_util.h
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/root_window_controller.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/root_window_controller.h
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/test/wm_test_base.cc
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/test/wm_test_base.h
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/test/wm_test_helper.cc
[add] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/test/wm_test_helper.h
[delete] https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68/mash/wm/window_layout.cc
[delete] https://crrev.com/003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68/mash/wm/window_layout.h
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/window_manager.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/window_manager.h
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/window_manager_application.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/window_manager_application.h
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/mash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/383d818f80838a60c4e9655836f1b243f83ea6ce/ui/views/mus/platform_window_mus.cc

Project Member

Comment 44 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/455e12470494c9586e21f669c043157acdceb2a9

commit 455e12470494c9586e21f669c043157acdceb2a9
Author: sky <sky@chromium.org>
Date: Thu May 19 23:16:14 2016

Moves resources used by ash/wm/common to ash/wm/common/resources

BUG= 603369 
TEST=none
R=oshima@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/1994993003
Cr-Commit-Position: refs/heads/master@{#394898}

[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/DEPS
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/ash.gyp
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/ash_resources.gyp
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/resources/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/resources/ash_resources.grd
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/DEPS
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/ash_wm_common.gyp
[add] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/ash_wm_common_resources.gyp
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/dock/docked_window_layout_manager.cc
[add] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/BUILD.gn
[add] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/OWNERS
[add] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/PRESUBMIT.py
[add] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/ash_wm_common_resources.grd
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/multi_window_resize_horizontal.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/multi_window_resize_vertical.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_bottom.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_bottom_left.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_bottom_right.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_center.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_left.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_right.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_top.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_top_left.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/phantom_window_top_right.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_100_percent/common/shelf/shelf_background.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/multi_window_resize_vertical.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_bottom.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_bottom_left.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_bottom_right.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_center.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_left.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_right.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_top.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_top_left.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/phantom_window_top_right.png
[rename] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/resources/default_200_percent/common/shelf/shelf_background.png
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/ash/wm/common/workspace/phantom_window_controller.cc
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_repack_chrome_100_percent.gypi
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_repack_chrome_200_percent.gypi
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_resources.gyp
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_tests.gypi
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/chrome/test/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/mash/wm/BUILD.gn
[modify] https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9/tools/gritsettings/resource_ids

Project Member

Comment 45 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/242453e1ae174aae09cb9324cf6bc38099feffda

commit 242453e1ae174aae09cb9324cf6bc38099feffda
Author: sky <sky@chromium.org>
Date: Fri May 20 01:36:03 2016

Removes |old| parameter from OnWindowPropertyChanged()

It wasn't consistently implemented and is not needed.

BUG= 603369 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/1997633004
Cr-Commit-Position: refs/heads/master@{#394951}

[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/always_on_top_controller.cc
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/always_on_top_controller.h
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/panels/panel_layout_manager.cc
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/panels/panel_layout_manager.h
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/wm_window_observer.h
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/ash/wm/common/workspace/workspace_layout_manager.h
[modify] https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda/mash/wm/bridge/wm_window_mus.cc

Project Member

Comment 46 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a

commit cf67ed5a0802c2d1d5b05a0d87cdd1612317555a
Author: sky <sky@chromium.org>
Date: Mon May 23 19:38:39 2016

Splits ToplevelWindowEventHandler into two

The non event handler and non-aura parts end up in
WmToplevelWindowEventHandler with the rest remaining in
ToplevelWindowEventHandler.

WmToplevelWindowEventHandler is not actually an EventHandler, but I kept
the name to reinforce the expectation is that WmToplevelWindowEventHandler is called from an EventHandler.

BUG= 603369 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2001623003
Cr-Commit-Position: refs/heads/master@{#395387}

[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/shell.cc
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/aura/wm_globals_aura.cc
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/aura/wm_globals_aura.h
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/aura/wm_window_aura.cc
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/aura/wm_window_aura.h
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/common/BUILD.gn
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/common/ash_wm_common.gyp
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/common/wm_display_observer.h
[add] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/common/wm_toplevel_window_event_handler.cc
[add] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/common/wm_toplevel_window_event_handler.h
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/common/wm_window.h
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/mash/wm/bridge/wm_window_mus.cc
[modify] https://crrev.com/cf67ed5a0802c2d1d5b05a0d87cdd1612317555a/mash/wm/bridge/wm_window_mus.h

Project Member

Comment 47 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/532d3841d0bf88a5ee911b561b4c19e7666c2755

commit 532d3841d0bf88a5ee911b561b4c19e7666c2755
Author: sky <sky@chromium.org>
Date: Mon May 23 23:14:04 2016

Gets mash to use WmToplevelWindowEventHandler

And wires up a couple of ash LayoutManagers that the resize code uses.

BUG= 603369 
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2002243002
Cr-Commit-Position: refs/heads/master@{#395453}

[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/ash/wm/common/wm_toplevel_window_event_handler.h
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/BUILD.gn
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/bridge/wm_globals_mus.cc
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/bridge/wm_root_window_controller_mus.cc
[add] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/drag_window_resizer.cc
[add] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/drag_window_resizer.h
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/frame/move_event_handler.cc
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/frame/move_event_handler.h
[delete] https://crrev.com/65f37925f106348f3b2e16c29b73347b990f127c/mash/wm/frame/move_loop.cc
[delete] https://crrev.com/65f37925f106348f3b2e16c29b73347b990f127c/mash/wm/frame/move_loop.h
[delete] https://crrev.com/65f37925f106348f3b2e16c29b73347b990f127c/mash/wm/frame/move_loop_unittest.cc
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/root_window_controller.cc
[modify] https://crrev.com/532d3841d0bf88a5ee911b561b4c19e7666c2755/mash/wm/shelf_layout_manager.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6eb52c4d94fda97fa2492a2044a4339c8f42af9

commit a6eb52c4d94fda97fa2492a2044a4339c8f42af9
Author: erg <erg@chromium.org>
Date: Wed Jun 01 20:09:11 2016

mash: Fix non client cursor display.

After 532d3841d, we need to also check for MOUSE_MOVED, not just
POINTER_MOVED.

BUG= 603369 

Review-Url: https://codereview.chromium.org/2027283002
Cr-Commit-Position: refs/heads/master@{#397219}

[modify] https://crrev.com/a6eb52c4d94fda97fa2492a2044a4339c8f42af9/mash/wm/frame/move_event_handler.cc

Comment 49 by dtapu...@chromium.org, Sep 2 2016

Components: MUS

Comment 50 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS
Labels: Proj-Mustash

Comment 51 by sky@chromium.org, Mar 7 2017

Status: Fixed (was: Started)

Now that mash uses aura this is done. Not everything works, but there are specific bugs filed for the cases that need to be updated.

Comment 52 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 53 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 54 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 55 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 56 by lafo...@chromium.org, Feb 26 2018

Components: -MUS

►

Issue 603369 link

Issue metadata

Make mash use ash wm code

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 14 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 15 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Apr 15 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Apr 15 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Apr 15 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 19 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Apr 20 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 20 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Apr 20 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 20 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Apr 20 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Apr 21 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Apr 22 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Apr 22 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Apr 22 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Apr 25 2016

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Apr 26 2016

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Apr 26 2016

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Apr 26 2016

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Apr 26 2016

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Apr 27 2016

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Apr 27 2016

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Apr 28 2016

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Apr 28 2016

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Apr 29 2016

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Apr 29 2016

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, May 2 2016

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, May 2 2016

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, May 3 2016

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, May 4 2016

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, May 5 2016

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, May 5 2016

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, May 7 2016

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, May 9 2016

Comment 34 Deleted

Comment 35 by mfomitchev@chromium.org, May 12 2016

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, May 13 2016

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, May 16 2016

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, May 17 2016

Comment 38 Deleted