New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603368 link

Starred by 1 user
Status: Verified
Owner:
r...@chromium.org
Closed: Apr 2016
Cc:
snanda@chromium.org
█ mcchou@chromium.org
█ scheib@chromium.org
█ ortuno@chromium.org
█ zelidrag@chromium.org
█ jleong@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Feature

Blocking:
issue 601935



Sign in to add a comment

Use the new x-platform test fixture for Bluetooth for BlueZ tests.

Project Member Reported by r...@chromium.org, Apr 14 2016 
Most Bluetooth tests for platforms other than those using BlueZ have moved to a unified set of test fixtures defined in //device/bluetooth/test/bluetooth_test.h.

BlueZ is the only platform that is not using this fixture. Since we have a lot of legacy tests, it is not feasible to port of them over to this new fixture but any new tests that are being written should use this fixture. For this we need to,

a.) Write a basic BlueZ implementation for this fixture.
b.) Enable some basic tests in bluetooth_adapter_unittest.cc and other places to at least test basic Bluetooth (particularly LE) functionality.
c.) Write new tests using this fixture, implementing more of this fixture as needed.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/519a20c6b2f426c891a987289f4da1527531c032

commit 519a20c6b2f426c891a987289f4da1527531c032
Author: rkc <rkc@chromium.org>
Date: Sat Apr 16 23:18:07 2016

Implement BluetoothTestBlueZ and enable some LE tests.

This CL adds an initial implementation of BluetoothTestBlueZ and enables
some basic x-platform Bluetooth tests. Going foward, any new code written
for Bluetooth, including specifically for BlueZ, should use these test
fixtures.

R=ortuno@chromium.org, scheib@chromium.org
BUG= 603368 

Review URL: https://codereview.chromium.org/1884033002

Cr-Commit-Position: refs/heads/master@{#387819}

[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/BUILD.gn
[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/bluetooth_adapter_bluez.h
[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/bluetooth_adapter_unittest.cc
[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/dbus/fake_bluetooth_device_client.h
[add] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/test/bluetooth_test_bluez.cc
[add] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/test/bluetooth_test_bluez.h
[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/bluetooth/test/bluetooth_test_win.cc
[modify] https://crrev.com/519a20c6b2f426c891a987289f4da1527531c032/device/device_tests.gyp

Comment 2 by mcchou@chromium.org, Apr 18 2016

Cc: mcchou@chromium.org

Comment 3 by ortuno@chromium.org, Apr 25 2016

Components: IO>Bluetooth

Comment 4 by ortuno@chromium.org, Apr 25 2016

Components: -OS>Systems>Bluetooth

Comment 5 by scheib@chromium.org, Apr 27 2016

Blocking: 601935

Comment 6 by r...@chromium.org, Apr 27 2016

Status: Fixed (was: Assigned)
Basic tests are already landed, new tests are using these fixtures. Marking as fixed.

Comment 7 by kathrelk...@chromium.org, May 19 2016 

as per #6

Comment 8 by kathrelk...@chromium.org, May 19 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment