Move SwipeRefreshHandler from chrome to content |
||||
Issue descriptionSteps to reproduce the problem: 1. chrome\android\java\src\org\chromium\chrome\browser\SwipeRefreshHandler.java 2. 3. What is the expected behavior? put this chrome\android\java\src\org\chromium\chrome\browser\SwipeRefreshHandler.java into content\ What went wrong? If we hope to implement Pull to Refresh in other projects, such as WebView or ContentShell, we have make a copy of SwipeRefreshHandler, because it is under chrome\. If it is under content, it will be more easily referred in other projects. BTW, SwipeRefreshHandler has little to do with chrome, except one string R.string.accessibility_swipe_refresh. One more consideration, is it possible put it into components? It seems the current components\ doesn't include or refer any R.string.. So content should be better. Did this work before? No Chrome version: 49.0.2623.112 Channel: stable OS Version: 6.3 Flash Version: Shockwave Flash 21.0 r0
,
Apr 18 2016
,
Apr 18 2016
Do not think it belongs to content/. component for the mechanism seems OK.
,
Apr 18 2016
I don't think it will be used in either webview or content shell, so I don't see a direct need to move it to components either. It is very much chrome UI and not a general browser function, so I'm not convinced it should move at all.
,
Mar 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by raphael....@intel.com
, Apr 14 2016