New issue
Advanced search Search tips

Issue 603316 link

Starred by 2 users
Status: Fixed
Owner:
sadrul@chromium.org
Closed: Jul 2016
Cc:
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
mus

Blocking:
issue 600815
issue 614070



Sign in to add a comment

Change how DPI is reported to mus clients

Project Member Reported by sadrul@chromium.org, Apr 13 2016 
mus::Window currently has a viewport_metrics with information about the display it is on, including the device-scale-factor. But, mus apps currently already know about the displays (and their dimensions, DSF etc.) in gfx::Displays. So instead of duplicating this information in mus::Window, it can instead know about which gfx::Display it is on, and look up the dimension/DSF etc. from that where necessary. i.e. implement the TODO here: https://code.google.com/p/chromium/codesearch#chromium/src/components/mus/public/interfaces/window_tree.mojom&sq=package:chromium&type=cs&l=302

Comment 1 by sky@chromium.org, May 23 2016

Blocking: 614070

Comment 2 by sky@chromium.org, May 23 2016

Labels: mus

Comment 4 by sadrul@chromium.org, May 25 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b39373f9270fed89e53cd658bb3001f2e05849

commit 33b39373f9270fed89e53cd658bb3001f2e05849
Author: sadrul <sadrul@chromium.org>
Date: Fri May 27 18:06:56 2016

mus: Send display-id to client only for the root windows.

Child windows are always in the same display as their parent windows, so
it doesn't make sense to always send the display-id for each window
created.  Instead, notify the client about the display each root-window
is on, and have the client be responsible for tracking that for each
child window afterwards.

BUG= 603316 

Review-Url: https://codereview.chromium.org/2019013002
Cr-Commit-Position: refs/heads/master@{#396511}

[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/public/cpp/lib/window.cc
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/public/cpp/lib/window_tree_client_impl.cc
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/public/cpp/lib/window_tree_client_impl.h
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/public/cpp/tests/window_tree_client_impl_private.cc
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/public/interfaces/window_tree.mojom
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/ws/test_utils.cc
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/ws/test_utils.h
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/ws/window_tree.cc
[modify] https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849/components/mus/ws/window_tree_client_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21c4cdea43a46afbfec9b66455d7cbc35c0f041b

commit 21c4cdea43a46afbfec9b66455d7cbc35c0f041b
Author: sadrul <sadrul@chromium.org>
Date: Fri May 27 19:36:25 2016

mus: Remove ViewportMetrics from mojom.

ViewportMetrics is no longer sent over IPC to the clients, so remove
it from the mojom. Also, simplify the usage a bit, for example, rename
'device pixel ratio' to 'device scale factor', since that's what the
rest of the code (in //ui/display and elsewhere) calls it. Also, remove
GetViewportMetrics() from PlatformDisplay and Display, and introduce
GetDeviceScaleFactor() on PlatformDisplay, since that was the only use
for it.

BUG= 603316 

Review-Url: https://codereview.chromium.org/2021483002
Cr-Commit-Position: refs/heads/master@{#396534}

[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/public/interfaces/window_tree.mojom
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/display.cc
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/display.h
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/platform_display.cc
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/platform_display.h
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/platform_display_delegate.h
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/test_utils.cc
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/window_server.cc
[modify] https://crrev.com/21c4cdea43a46afbfec9b66455d7cbc35c0f041b/components/mus/ws/window_server.h

Comment 7 by sadrul@chromium.org, Jul 25 2016

Status: Fixed (was: Started)

Comment 8 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment