New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603308 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 603851
Owner:
Not on Chrome anymore
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 584266
issue 603851



Sign in to add a comment

Fill space below the last suggestion with whitespace if necessary

Project Member Reported by nepper@chromium.org, Apr 13 2016

Issue description

Currently, the Doodle and Fakebox fade-out can get stuck in transition if there is not enough Zine suggestions (see screenshot).

We should make sure Zine suggestions can always move to the top of the Canvas (even if there is only a single suggestion) - in order to avoid that the transition animation gets stuck in a weird intermediate step.
 
Screenshot_20160414-002827.png
239 KB View Download

Comment 1 by fi...@chromium.org, Apr 22 2016

Blocking: 584266

Comment 2 by dgn@chromium.org, Apr 25 2016

Cc: -dgn@chromium.org mcwilliams@chromium.org
Labels: zine-mr-iter-12
Owner: dgn@chromium.org

Comment 3 by dgn@chromium.org, Apr 28 2016

Mergedinto: 603851
Status: Duplicate (was: Assigned)

Comment 4 by dgn@chromium.org, May 10 2016

Blocking: 603851
Labels: zine-mr-iter-14
Status: Started (was: Duplicate)
Documenting a chat with Nicolas: 

When the user dismisses all snippets, we should stay below the fold and to show the empty state card. 

That looks like this: https://docs.google.com/presentation/d/10RoYrYkofS4CG1AO7Hr5oIPDnZK67ccT7wDX1R2toyg/edit#slide=id.g127ed73201_1_149

Comment 6 by bettes@chromium.org, May 12 2016

If we can, it'd be nice to allow for 32dp of padding between last snippet and bottom of screen when snippet list is full

So to summarize
- allow a single snippet to scroll to the top of the canvas
- when list is full, allow for a 32dp padding at the bottom

Comment 7 by dgn@chromium.org, May 13 2016

Cc: dgn@chromium.org
 Issue 602272  has been merged into this issue.

Comment 8 by dgn@chromium.org, May 16 2016

Issue 612053 has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e047ff07f0e05ec8f9ba0556eeda413e314599e3

commit e047ff07f0e05ec8f9ba0556eeda413e314599e3
Author: dgn <dgn@chromium.org>
Date: Tue May 17 16:52:30 2016

[NTP Snippets] Fill space below the last snippet if necessary

Add a filler item at the end of the recycler view to push the
snippet items to the top of the view when there are not enough
of them.

Preview: https://goo.gl/photos/BDHFexhW8Cvo9Y4v5

BUG= 603308 

Review-Url: https://codereview.chromium.org/1928063002
Cr-Commit-Position: refs/heads/master@{#394147}

[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/res/layout/toolbar.xml
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[add] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingListItem.java
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java_sources.gni
[modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Comment 10 by dgn@chromium.org, May 17 2016

Labels: zine-mr-iter-15
Status: Fixed (was: Started)
Closing, as it should fix the animation and layout issues. There are some UX issues (e.g. what to display when everything is cleared), that should be addressed by  issue 612508 .
Issue 613315 has been merged into this issue.
Labels: zine-mr-MVP
Labels: -zine-mr-mvp
Labels: zine-mr-MVP

Sign in to add a comment