Issue metadata
Sign in to add a comment
|
Fill space below the last suggestion with whitespace if necessary |
||||||||||||||||||||||||
Issue descriptionCurrently, the Doodle and Fakebox fade-out can get stuck in transition if there is not enough Zine suggestions (see screenshot). We should make sure Zine suggestions can always move to the top of the Canvas (even if there is only a single suggestion) - in order to avoid that the transition animation gets stuck in a weird intermediate step.
,
Apr 25 2016
,
Apr 28 2016
,
May 10 2016
,
May 11 2016
Documenting a chat with Nicolas: When the user dismisses all snippets, we should stay below the fold and to show the empty state card. That looks like this: https://docs.google.com/presentation/d/10RoYrYkofS4CG1AO7Hr5oIPDnZK67ccT7wDX1R2toyg/edit#slide=id.g127ed73201_1_149
,
May 12 2016
If we can, it'd be nice to allow for 32dp of padding between last snippet and bottom of screen when snippet list is full So to summarize - allow a single snippet to scroll to the top of the canvas - when list is full, allow for a 32dp padding at the bottom
,
May 13 2016
,
May 16 2016
Issue 612053 has been merged into this issue.
,
May 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e047ff07f0e05ec8f9ba0556eeda413e314599e3 commit e047ff07f0e05ec8f9ba0556eeda413e314599e3 Author: dgn <dgn@chromium.org> Date: Tue May 17 16:52:30 2016 [NTP Snippets] Fill space below the last snippet if necessary Add a filler item at the end of the recycler view to push the snippet items to the top of the view when there are not enough of them. Preview: https://goo.gl/photos/BDHFexhW8Cvo9Y4v5 BUG= 603308 Review-Url: https://codereview.chromium.org/1928063002 Cr-Commit-Position: refs/heads/master@{#394147} [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/res/layout/toolbar.xml [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageListItem.java [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [add] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingListItem.java [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/java_sources.gni [modify] https://crrev.com/e047ff07f0e05ec8f9ba0556eeda413e314599e3/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
May 17 2016
Closing, as it should fix the animation and layout issues. There are some UX issues (e.g. what to display when everything is cleared), that should be addressed by issue 612508 .
,
May 20 2016
Issue 613315 has been merged into this issue.
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by fi...@chromium.org
, Apr 22 2016