New issue
Advanced search Search tips

Issue 603306 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

`git cl upload` crashes in android presubmit on OS X

Project Member Reported by thakis@chromium.org, Apr 13 2016

Issue description

icos-MacBook-Pro:src thakis$ git cl upload --send-mail -r scottmg@chromium.org
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
Traceback (most recent call last):
  File "build/print_python_deps.py", line 104, in <module>
    sys.exit(main())
  File "build/print_python_deps.py", line 86, in main
    imp.load_source('NAME', options.module)
  File "build/android/test_runner.py", line 25, in <module>
    from devil.android import forwarder
  File "/Users/thakis/src/chrome/src/third_party/catapult/devil/devil/android/forwarder.py", line 10, in <module>
    import psutil
ImportError: No module named psutil

** Presubmit ERRORS **
Error running: build/print_python_deps.py --root build/android --output build/android/test_runner.pydeps build/android/test_runner.py --output ""



Looks like https://chromium.googlesource.com/chromium/src/+/f32bcc73dfef6e5d282c6b37fd3e25da441a0c94
 
Status: Started (was: Assigned)
Similar to  bug #600604  (same thing, but for windows)
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bc4200b07bf658369e23928a6a5412ea909a149

commit 9bc4200b07bf658369e23928a6a5412ea909a149
Author: agrieve <agrieve@chromium.org>
Date: Wed May 04 16:33:28 2016

Disable pydeps presumbit on Mac.

On Mac, it fails because "import psutil" does not work (on
Linux it exists under /usr/lib/python2.7/dist-packages).

BUG= 603306 

Review-Url: https://codereview.chromium.org/1943703002
Cr-Commit-Position: refs/heads/master@{#391534}

[modify] https://crrev.com/9bc4200b07bf658369e23928a6a5412ea909a149/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment