New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603305 link

Starred by 3 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
dbeam@chromium.org
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

Show a reasonable number of OnStartup URLS

Project Member Reported by dschuyler@chromium.org, Apr 13 2016 
Alan, Please yay/nay this:

  The On Startup section should display a reasonable
  number of elements in the list (without a scroll bar)
  and then switch to a scrolling list.

Feel free to expand on that if you like.  i.e. maybe
that should apply to lists of things, in general (or
are there UIs where that wouldn't hold true?).

(It doesn't currently switch to a scrolling list, so
that would need to be fixed).

Comment 1 by tbuck...@chromium.org, Apr 14 2016

Labels: -Pri-3 Pri-2
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Yay, I say! I believe we'll want the same list behavior in multiple places. See the internet mocks [1] for an example of how lists should behave.

In particular, 6 rows should be shown before switching to a scrolling list. The scrollbar should have a minimum height of 48dp. A dropshadow should appear on scroll.

[1] https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-cards_internet.png%3Fz=half

Comment 2 by tbuck...@chromium.org, Apr 14 2016

Cc: bettes@chromium.org

Comment 3 by bettes@chromium.org, Apr 20 2016 

Yeah that sounds right, thanks Tom. I suspect we might revisit our magical "6" as we get further along.

Comment 4 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-OnStartup

Comment 5 by dschuyler@chromium.org, Aug 30 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72679618a08ccd653fcca4efab460a5b2ebf0eac

commit 72679618a08ccd653fcca4efab460a5b2ebf0eac
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Aug 30 22:59:24 2016

[MD settings] Show up to six on startup urls without scrolling

This CL changes the height of the container for the On startup list of
URLs to show up to six rows (scrolling to see the remaining rows). This
was requested by Alan.

BUG= 603305 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2298533002
Cr-Commit-Position: refs/heads/master@{#415477}

[modify] https://crrev.com/72679618a08ccd653fcca4efab460a5b2ebf0eac/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

Comment 7 by dschuyler@chromium.org, Aug 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment