New issue
Advanced search Search tips

Issue 603291 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 569709

Blocking:
issue 510287



Sign in to add a comment

bluetooth: WebBluetoothServices should add themselves as observer of BluetoothAdapter

Project Member Reported by ortuno@chromium.org, Apr 13 2016

Issue description

WebBluetoothServices currently use BluetoothAdapterFactoryWrapper to interact with the adapter and add themselves as observers.

BluetoothAdapterFactoryWrapper keeps a copy of a BluetoothAdapter and adds the WebBluetoothService as observer of the current adapter. When the adapter is swapped during tests, BluetoothAdapterFactoryWrapper removes the observers from the old adapter and adds them to the new adapter. When the WebBluetoothService wants to interact with the adapter it acquires this new test adapter.

Rather than using BluetoothAdapterFactoryWrapper to interact with BluetoothAdapter, WebBluetoothServices should acquire the adapter from BluetoothAdapterFactory directly. For this we need to use dynamic mocks so that we can remove the devices/services/characteristics/descriptors from the adapter itself rather than swapping it for another one.
 

Comment 1 by scheib@chromium.org, May 16 2016

Labels: -M-52

Comment 2 by juncai@chromium.org, Jan 13 2017

Is this bug still up to date? Since now the WebBluetoothServiceImpl is already a subclass of device::BluetoothAdapter::Observer:
https://cs.chromium.org/chromium/src/content/browser/bluetooth/web_bluetooth_service_impl.h?sq=package:chromium&l=51

Comment 3 by ortuno@chromium.org, Jan 17 2017

Description: Show this description

Comment 4 by ortuno@chromium.org, Jan 17 2017

It was a bit out of date. I updated the description.
Labels: DeviceService

Comment 6 by juncai@chromium.org, Feb 11 2017

Owner: juncai@chromium.org
Status: Assigned (was: Available)

Comment 7 by juncai@chromium.org, Feb 11 2017

Status: Started (was: Assigned)

Comment 8 by ortuno@chromium.org, Feb 13 2017

@juncai: What did you have in mind for this? We need Dynamic Mocks in order to solve this.

Comment 9 by juncai@chromium.org, Feb 13 2017

Cc: juncai@chromium.org
Owner: ----
Status: Available (was: Started)
hmm... just noticed that this issue is blocked on the dynamic mocks issue 569709. I changed the issue status.
Labels: Pri-3
Issues not modified in last 50 days aren't on track to ship in next release.
Blocking: -508771 510287
Components: Internals>Services>Device
Project Member

Comment 13 by sheriffbot@chromium.org, Nov 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment