bluetooth: WebBluetoothServices should add themselves as observer of BluetoothAdapter |
||||||||||
Issue descriptionWebBluetoothServices currently use BluetoothAdapterFactoryWrapper to interact with the adapter and add themselves as observers. BluetoothAdapterFactoryWrapper keeps a copy of a BluetoothAdapter and adds the WebBluetoothService as observer of the current adapter. When the adapter is swapped during tests, BluetoothAdapterFactoryWrapper removes the observers from the old adapter and adds them to the new adapter. When the WebBluetoothService wants to interact with the adapter it acquires this new test adapter. Rather than using BluetoothAdapterFactoryWrapper to interact with BluetoothAdapter, WebBluetoothServices should acquire the adapter from BluetoothAdapterFactory directly. For this we need to use dynamic mocks so that we can remove the devices/services/characteristics/descriptors from the adapter itself rather than swapping it for another one.
,
Jan 13 2017
Is this bug still up to date? Since now the WebBluetoothServiceImpl is already a subclass of device::BluetoothAdapter::Observer: https://cs.chromium.org/chromium/src/content/browser/bluetooth/web_bluetooth_service_impl.h?sq=package:chromium&l=51
,
Jan 17 2017
,
Jan 17 2017
It was a bit out of date. I updated the description.
,
Jan 26 2017
,
Feb 11 2017
,
Feb 11 2017
,
Feb 13 2017
@juncai: What did you have in mind for this? We need Dynamic Mocks in order to solve this.
,
Feb 13 2017
hmm... just noticed that this issue is blocked on the dynamic mocks issue 569709. I changed the issue status.
,
Apr 20 2017
Issues not modified in last 50 days aren't on track to ship in next release.
,
Nov 7 2017
,
Nov 7
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 7
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by scheib@chromium.org
, May 16 2016