New issue
Advanced search Search tips

Issue 603262 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

git cl format makes a strange change w.r.t. the position of '*'

Project Member Reported by js...@chromium.org, Apr 13 2016

Issue description

git cl upload has an issue with |UChar* dest| and insists that I run 'git cl format'. When 
I ran it, I got the following diff: 

 
   typedef int32_t (*case_conversion_fn)(
-      UChar* dest, int32_t destCapacity, const UChar* src, int32_t srcLength,
+      UChar * dest, int32_t destCapacity, const UChar* src, int32_t srcLength,
       const char* locale, UErrorCode* pErrorCode);

Note that it puts a space *before and after* '*'. That is, it wants 'UChar * dest' instead of 'UChar* dest' or 'Uchar *dest'. It's not consistent, either. In the same line, 'UChar* src'
is not touched. 

I'm not using 'Infra-git' because it automatically adds 'scary-sounding' Release-Block labels. :-). 

 

Comment 1 by js...@chromium.org, Apr 13 2016

"git cl upload has an issue" ==> To be precise, 'pre-submit check' has an issue. 

Comment 2 by hinoka@chromium.org, Apr 13 2016

Labels: -Infra

Comment 3 by aga...@chromium.org, Nov 22 2016

Status: WontFix (was: Untriaged)
'git cl format' is just a call through to clang-format-diff, directly inside the llvm repo:
https://chromium.googlesource.com/chromium/llvm-project/cfe/tools/clang-format/+/master/clang-format-diff.py

I don't think that there's anything Infra can do about this. Take it up with some of the LLVM devs on the team, maybe?

Sign in to add a comment