New issue
Advanced search Search tips

Issue 603251 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Performance impact of shipping try/catch in TurboFan

Project Member Reported by m...@chromium.org, Apr 13 2016

Issue description

See the link to graphs below.
 

Comment 1 by m...@chromium.org, Apr 13 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=603251

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg-LLwsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg-Ob0vAsM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
chromium-rel-win7-x64-dual

Comment 2 by m...@chromium.org, Apr 13 2016

...and on chromium-rel-mac10.

Comment 3 by m...@chromium.org, Apr 14 2016

Blockedon: 603694

Comment 4 by m...@chromium.org, Apr 19 2016

Owner: kojii@chromium.org
Minimum range for regression is only two changes: 386659 or 386660.  The main suspect is:

commit	0a263edeb740bb85eebfe9df27ba5870db1801b6	
author	v8-autoroll <v8-autoroll@chromium.org>	Tue Apr 12 12:34:26 2016
committer	Commit bot <commit-bot@chromium.org>	Tue Apr 12 12:35:54 2016
Update V8 to version 5.2.10.1 (cherry-pick).

Assigning to OWNER for further triage...

Comment 5 by kojii@chromium.org, Apr 20 2016

Cc: kojii@chromium.org
Owner: tkent@chromium.org
tkent@, could you advise? When the suspect is v8-autoroll, who should be the owner?

Comment 6 by tkent@chromium.org, Apr 20 2016

Owner: hablich@chromium.org
Assign hablich@ for triage.

Comment 7 by kojii@chromium.org, Apr 20 2016

Cc: -kojii@chromium.org
Cc: mvstan...@chromium.org hablich@chromium.org
Owner: jarin@chromium.org
Suspecting https://chromium.googlesource.com/v8/v8/+/4dfc6254fb91b0d058f4c10bd88c897833826f3a (ship try/catch for TF).

Jaro & Michael WDYT?
Components: Blink>JavaScript>Compiler
Labels: Performance
Summary: Performance impact of shipping try/catch (was: 22.6%-25.4% regression in blink_perf.layout at 386654:386676)
Summary: Performance impact of shipping try/catch in TurboFan (was: Performance impact of shipping try/catch)

Comment 12 by jarin@chromium.org, Apr 21 2016

Just for completeness: We regress because of Turbofan compilation time - Turbofan is orders of magnitude slower than fullcode. This CL just uses Turbofan for more code.
Labels: TradeOff
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 13 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Perf sheriff ping
Blockedon: -603694
Looks like this was a tradeoff that we accepted -- jarin@, is there anything else that we want to do here, or should this bug be closed?

Comment 18 by jarin@chromium.org, Oct 18 2016

Status: WontFix (was: Assigned)
Yes, we took the trade-off. Closing.

Sign in to add a comment