New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603243 link

Starred by 2 users
Status: Verified
Owner:
msw@chromium.org
Closed: Apr 2016
Cc:
abodenha@chromium.org
█ kuscher@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

status area's layout does not switch when shelf layout is vertical

Project Member Reported by osh...@chromium.org, Apr 13 2016 
Google Chrome	51.0.2704.0 (Official Build) dev (64-bit)
Platform	8172.1.0 (Official Build) dev-channel stumpy

Repro step:
1) login
2) change the shelf layout to left/right
3) lock screen (search - l)

expected:
 status area is shown horizontally

actual:
 status are 's height seem to be set, without layout change?

Comment 1 by msw@chromium.org, Apr 13 2016

Labels: -Type-Bug Type-Bug-Regression
Hmm, I get a crash on desktop when I lock after setting the shelf to left.
I'll take a closer look; sorry for the regression!

Comment 2 by msw@chromium.org, Apr 13 2016

Status: Started (was: Assigned)
Okay, I can repro after syncing to ToT.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67a576240caed1c3783e6465d6c07998a2fc0b07

commit 67a576240caed1c3783e6465d6c07998a2fc0b07
Author: msw <msw@chromium.org>
Date: Mon Apr 18 21:06:13 2016

Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG= 603243 
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1877543002

Cr-Commit-Position: refs/heads/master@{#388021}

[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/ash.gyp
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/mus/shelf_delegate_mus.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf.h
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_bezel_event_filter.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_button.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_layout_manager_unittest.cc
[add] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_locking_manager.cc
[add] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_locking_manager.h
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_types.h
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_util.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_util.h
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/shell.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/date/tray_date.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/tray/system_tray.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/tray/tray_item_view.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/user/tray_user.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/system/web_notification/web_notification_tray.cc
[delete] https://crrev.com/c48b3c39d37d01e41ab7fc2b6b8367f72b78572b/ash/test/shelf_test_api.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/test/shelf_test_api.h
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/ash/wm/window_animations.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/67a576240caed1c3783e6465d6c07998a2fc0b07/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Comment 4 by msw@chromium.org, Apr 19 2016

Cc: osh...@chromium.org
Hey oshima, would you mind helping me verify the fix on ToT for merge?

Comment 5 by msw@chromium.org, Apr 22 2016

Labels: Merge-Request-51
AFAICT, this is fixed on ToT @ #388905 for linux-chromeos (I don't have a test device...), using:
  out/Default/chrome --login-manager --user-data-dir=/tmp/foo 
Requesting merge to M-51 branch 2704.

Comment 6 by tin...@google.com, Apr 22 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 22 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b215eb84a43373060023baca3e3f375e73376e8

commit 2b215eb84a43373060023baca3e3f375e73376e8
Author: Michael Wasserman <msw@chromium.org>
Date: Fri Apr 22 19:26:00 2016

(Merge to M-51) Revise the shelf alignment locking mechanism.

Add a new SHELF_ALIGNMENT_LOCKED, not stored in user prefs.
(similar to existing SHELF_AUTO_HIDE_ALWAYS_HIDDEN behavior)

Add a new Shelf member, ShelfLockingManager.
This locks (bottom) alignment on screen lock and user addition.

Fixes a regression from https://codereview.chromium.org/1851883002

TODO: Move more state tracking (for visibility) out of LayoutManager.

BUG= 603243 
TEST=Locking Chrome OS moves shelf to bottom.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1877543002

Cr-Commit-Position: refs/heads/master@{#388021}
(cherry picked from commit 67a576240caed1c3783e6465d6c07998a2fc0b07)

Review URL: https://codereview.chromium.org/1907363004 .

Cr-Commit-Position: refs/branch-heads/2704@{#190}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/ash.gyp
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf.h
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_bezel_event_filter.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_button.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_layout_manager_unittest.cc
[add] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_locking_manager.cc
[add] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_locking_manager.h
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_types.h
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_util.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_util.h
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/shell.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/date/tray_date.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/tray/system_tray.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/tray/tray_image_item.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/tray/tray_item_view.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/user/tray_user.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/system/web_notification/web_notification_tray.cc
[delete] https://crrev.com/6b7182edc60a06aec387dcde91e35cd9bdca2259/ash/test/shelf_test_api.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/test/shelf_test_api.h
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/ash/wm/window_animations.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/2b215eb84a43373060023baca3e3f375e73376e8/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc

Comment 9 by osh...@chromium.org, Apr 22 2016 

msw@, sorry for delay. I just tested on recent build and there still seems to be an issue with shelf layout in lock screen.

Google Chrome	52.0.2712.0 (Official Build) unknown (64-bit)   (position 388092)
Platform	8222.0.0 (Official Build) dev-channel link test

repro step:
1) login
2) move shelf to left
3) close lid
4) open lid

see the attached screenshot.
Screenshot 2016-04-22 at 14.47.49.png
5.9 MB View Download

Comment 10 by msw@chromium.org, Apr 22 2016 

Yikes, any idea how I can repro/simulate closing the lid on linux-chromeos?

Comment 11 by msw@chromium.org, Apr 22 2016 

Maybe it's easier to test the actions that closing a lid triggers? I'm digging, but advice is greatly appreciated.
https://code.google.com/p/chromium/codesearch#chromium/src/chromeos/dbus/power_policy_controller.h&l=44

Comment 13 by msw@chromium.org, Apr 27 2016 

Oshima, this isn't on cros dev yet, but would you care to test ToT after #389673?

Comment 14 by osh...@chromium.org, Apr 27 2016 

I tested this yesterday and worked fine. (Just forgot to update the bug, sorry)

Comment 15 by msw@chromium.org, Apr 27 2016 

Thanks! I'll merge #389673 to M-51, assuming the prior approval is sufficient.
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81a9c3501848333033c2a2a196bf475da5a8c38

commit f81a9c3501848333033c2a2a196bf475da5a8c38
Author: Michael Wasserman <msw@chromium.org>
Date: Wed Apr 27 18:31:42 2016

(Merge to M-51) Fix Chrome OS shelf locking for chromebook lid open/close.

Do not allow shelf alignment changes while locked.
Fixes a regression from https://codereview.chromium.org/1851883002
Extends my earlier fix https://codereview.chromium.org/1877543002

BUG= 603243 
TEST=Closing/opening chromebook lid with left-aligned shelf works as expected.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1920073002

Cr-Commit-Position: refs/heads/master@{#389673}
(cherry picked from commit 0d806bc979f45e4dfd4c701c9f518bcff52b23c8)

Review URL: https://codereview.chromium.org/1926823003 .

Cr-Commit-Position: refs/branch-heads/2704@{#272}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/f81a9c3501848333033c2a2a196bf475da5a8c38/ash/ash.gyp
[modify] https://crrev.com/f81a9c3501848333033c2a2a196bf475da5a8c38/ash/shelf/shelf.cc
[modify] https://crrev.com/f81a9c3501848333033c2a2a196bf475da5a8c38/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/f81a9c3501848333033c2a2a196bf475da5a8c38/ash/shelf/shelf_locking_manager.cc
[modify] https://crrev.com/f81a9c3501848333033c2a2a196bf475da5a8c38/ash/shelf/shelf_locking_manager.h
[add] https://crrev.com/f81a9c3501848333033c2a2a196bf475da5a8c38/ash/shelf/shelf_locking_manager_unittest.cc

Comment 17 by msw@chromium.org, Apr 27 2016

Status: Fixed (was: Started)
This should be fixed on the next Beta release; please help verify, thanks!

Comment 18 by sdantul...@chromium.org, May 20 2016

Status: Verified (was: Fixed)
Verified on Chrome OS (8350.0.0, 52.0.2739.0 beta) and (8172.39.0, 51.0.2704.55 dev)

Comment 19 by sdantul...@chromium.org, May 20 2016 

Correction: M52 dev and M51 beta
►

Sign in to add a comment