New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603239 link

Starred by 3 users
Status: Verified
Owner:
█ kjellander@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add Chromium trybots that runs the sizes step to WebRTC roll CLs

Project Member Reported by kjellander@chromium.org, Apr 13 2016 
To catch size regressions when rolling WebRTC into Chromium, we should add extra trybots that runs the sizes step to the CL.

This can be done by using the CQ_EXTRA_TRYBOTS= feature in the CL description. It can be used to specify the following bots:
* linux_chromium_archive_rel_ng (https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_archive_rel_ng/)
* mac_chromium_archive_rel_ng (https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_archive_rel_ng)

I'm unable to find such a bot for Windows, but then I also noticed that https://build.chromium.org/p/chromium/builders/Win/ doesn't run the sizes step.

With this, the roll CL will not be committed if anyone of these trybot fails.
We can do this by simply updating the roll script: https://code.google.com/p/chromium/codesearch#chromium/src/tools/roll_webrtc.py
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/698d8a2bcef4f16c3c08427739a1313d25a4d4ec

commit 698d8a2bcef4f16c3c08427739a1313d25a4d4ec
Author: kjellander <kjellander@chromium.org>
Date: Thu Apr 14 11:38:10 2016

Add trybots running the sizes step using CQ_EXTRA_TRYBOTS

This should make it possible to detect size regressions before rolling
in new WebRTC revisions into Chromium.

BUG= 603239 
TESTED=tools/roll_webrtc.py --dry-run -v --ignore-checks
NOTRY=True

Review URL: https://codereview.chromium.org/1877203008

Cr-Commit-Position: refs/heads/master@{#387284}

[modify] https://crrev.com/698d8a2bcef4f16c3c08427739a1313d25a4d4ec/tools/roll_webrtc.py

Comment 2 by kjellander@chromium.org, Apr 18 2016

Status: Started (was: Assigned)
Example of such a regression: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/18163 
caused by https://codereview.chromium.org/1887553003

Comment 3 by kjellander@chromium.org, Apr 18 2016 

https://codereview.chromium.org/1898713002/ is testing the bots (should fail).

FTR: There's also a https://build.chromium.org/p/tryserver.chromium.android/builders/android_archive_rel_ng/ trybot but it's not running the sizes step, so the coverage will be Linux and Mac for now.

Comment 4 by kjellander@chromium.org, Apr 18 2016

Status: Verified (was: Started)
Verified with failing tryjobs (on the sizes step) in https://codereview.chromium.org/1898713002/
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10907ea488ae542ffc52721c7ae029aebb405b43

commit 10907ea488ae542ffc52721c7ae029aebb405b43
Author: kjellander <kjellander@chromium.org>
Date: Mon Apr 18 14:36:45 2016

roll_webrtc.py: Fix syntax error for extra trybots line.

In https://codereview.chromium.org/1877203008 an entry with CQ_EXTRA_TRYBOTS
was added. It contained a syntax error that is now fixed.

BUG= 603239 
NOTRY=True

Review URL: https://codereview.chromium.org/1885413002

Cr-Commit-Position: refs/heads/master@{#387903}

[modify] https://crrev.com/10907ea488ae542ffc52721c7ae029aebb405b43/tools/roll_webrtc.py

Comment 6 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>WebRTC
Labels: -Infra-Client-WebRTC
►

Sign in to add a comment