New issue
Advanced search Search tips

Issue 603230 link

Starred by 3 users
Status: Duplicate
Merged: issue 591468
Owner:
wangxianzhu@chromium.org
Closed: Apr 2016
Cc:
pdr@chromium.org
chrishtr@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Don't need synchronized painting in the lifecycle update before special painting

Project Member Reported by wangxianzhu@chromium.org, Apr 13 2016 
Sometimes we need to paint a frame onto special painting target. Before the special painting we need to update the document lifecycle to be ready for painting. For now we call updateAllLifecyclePhases() which also synchronously paint which is not necessary.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f07d9b4a2ebb30cb77d3cca7d59e1f3c674e81eb

commit f07d9b4a2ebb30cb77d3cca7d59e1f3c674e81eb
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Apr 14 00:50:00 2016

Partly revert https://codereview.chromium.org/1860273003/ where paint follows

Restored updateLifecycleToCompositingCleanPlusScrolling() to
updateAllLifecyclePhases() where paint follows, because some paint
code may depend on the result of lifecycle phases between
CompositingUpdateClean and InPaint. For example, we update
table collapsed borders and layer empty phase information during
paint invalidtion, which are needed by paint.

BUG= 602961 , 591468 , 603230 

Review URL: https://codereview.chromium.org/1890603002

Cr-Commit-Position: refs/heads/master@{#387178}

[modify] https://crrev.com/f07d9b4a2ebb30cb77d3cca7d59e1f3c674e81eb/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/f07d9b4a2ebb30cb77d3cca7d59e1f3c674e81eb/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/f07d9b4a2ebb30cb77d3cca7d59e1f3c674e81eb/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Comment 2 by chrishtr@chromium.org, Apr 20 2016

Mergedinto: 591468
Status: Duplicate (was: Assigned)
►

Sign in to add a comment