New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603217 link

Starred by 15 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature


Sign in to add a comment

Implement pin unlock

Project Member Reported by jdufault@chromium.org, Apr 13 2016

Issue description

Tracking bug for implementing pin unlock

PRD: go/cros-quick-unlock


 
Labels: -Type-Bug Type-Feature
#CBC-RS/TC-watchlist
It would be useful by now too.
Blocking: 605946
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22dfa22df0ddbcab9f47d189207a11bdea820d75

commit 22dfa22df0ddbcab9f47d189207a11bdea820d75
Author: jdufault <jdufault@chromium.org>
Date: Wed May 11 22:03:49 2016

Add a very basic PIN UI implementation that is shared between lock and settings.

Most things are still in flux, but this will help provide some structure for the
rest of the code.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1933913002
Cr-Commit-Position: refs/heads/master@{#393081}

[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/browser_resources.grd
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/compiled_resources.gyp
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/login/custom_elements_lock.html
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/login/lock.html
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/login/screen_container.html
[add] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
[add] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/settings/people_page/people_page.js
[add] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/settings/people_page/pin_keyboard.html
[add] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/settings/people_page/pin_keyboard.js
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/ui/login/resource_loader.js
[modify] https://crrev.com/22dfa22df0ddbcab9f47d189207a11bdea820d75/ui/login/screen_container.css

Well, this is a bit of a turnabout, but I think many users [those that think their new Chromebook should be more Android-ish] will like it.
We could set up a category in Settings>>show advanced settings so that all the unlock options are in one place, rather than separate [that is, Smart Lock is then grouped within this].  Logical.
Blockedon: 612221
Blockedon: 612271
Project Member

Comment 10 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489f430f0a9a61984f4f114bbed9bd6ce1e14c77

commit 489f430f0a9a61984f4f114bbed9bd6ce1e14c77
Author: jdufault <jdufault@chromium.org>
Date: Fri May 20 20:34:28 2016

Implement pin storage backend.

This provides the backend C++ api for managing and authenticating different PINs. It will be used by the lock screen and by the settings.

BUG= 603217 

Review-Url: https://codereview.chromium.org/1977923002
Cr-Commit-Position: refs/heads/master@{#395156}

[add] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc
[add] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/browser/chromeos/login/quick_unlock/pin_storage.h
[add] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.cc
[add] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.h
[add] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc
[modify] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/common/pref_names.cc
[modify] https://crrev.com/489f430f0a9a61984f4f114bbed9bd6ce1e14c77/chrome/common/pref_names.h

Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8

commit c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8
Author: jdufault <jdufault@chromium.org>
Date: Mon May 23 17:55:21 2016

Fix opacity transition of pin keyboard on lockscreen.

Before, the opacity would get adjusted before the keyboard had been completely
loaded into the DOM. This patch makes the opacity adjustment wait until after
the pin keyboard has layout information available.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2004553002
Cr-Commit-Position: refs/heads/master@{#395359}

[modify] https://crrev.com/c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8/ui/login/resource_loader.js

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e48526a8fd621cf8f3291df98100dbc2772010b6

commit e48526a8fd621cf8f3291df98100dbc2772010b6
Author: jdufault <jdufault@chromium.org>
Date: Wed Jun 01 17:07:24 2016

Fix loadAssetsOnIdle not loading when document.readyState is 'interactive'.

BUG= 603217 

Review-Url: https://codereview.chromium.org/2028113002
Cr-Commit-Position: refs/heads/master@{#397165}

[modify] https://crrev.com/e48526a8fd621cf8f3291df98100dbc2772010b6/ui/login/resource_loader.js

Blockedon: 616674
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a09c41969d298d918f6f0824f619617ad9587b9e

commit a09c41969d298d918f6f0824f619617ad9587b9e
Author: jdufault <jdufault@chromium.org>
Date: Thu Jun 16 00:19:48 2016

Enable the PIN keyboard on the lockscreen.

The PIN keyboard will now show up if a user has the PIN keyboard enabled and has authenticated against the cryptohome recently (currently 24 hours).

The PIN keyboard is shown per-user, so this approach will scale to multiple user pods; however, the per-pod UI has not been completed yet.

The PIN keyboard is hidden after there are too many incorrect attempts.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2015413002
Cr-Commit-Position: refs/heads/master@{#400058}

[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/chromeos/login/lock/screen_locker.h
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.cc
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/chromeos/login/quick_unlock/pin_storage_factory.h
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/resources/chromeos/login/lock.js
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/ui/login/account_picker/screen_account_picker.js
[modify] https://crrev.com/a09c41969d298d918f6f0824f619617ad9587b9e/ui/login/account_picker/user_pod_row.js

Blockedon: 622785
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e7ed2d59374a27f3b9922ac078f39f8ec05cb5

commit 70e7ed2d59374a27f3b9922ac078f39f8ec05cb5
Author: jdufault <jdufault@chromium.org>
Date: Thu Jun 23 18:37:48 2016

Expose some internal PIN keyboard state.

Specifically, a change event is now raised whenever the entered PIN changes.

The PIN input field can now be modified externally.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2084013003
Cr-Commit-Position: refs/heads/master@{#401658}

[modify] https://crrev.com/70e7ed2d59374a27f3b9922ac078f39f8ec05cb5/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/70e7ed2d59374a27f3b9922ac078f39f8ec05cb5/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/422a5b1d21c2f099e656d63050e1322245e8ed8e

commit 422a5b1d21c2f099e656d63050e1322245e8ed8e
Author: jdufault <jdufault@chromium.org>
Date: Fri Jun 24 01:56:08 2016

Implement the private API for quick unlock.

The design doc is at go/cros-quick-unlock-design.

BUG= 603217 

Review-Url: https://codereview.chromium.org/1968083004
Cr-Commit-Position: refs/heads/master@{#401780}

[add] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[add] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
[add] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/common/extensions/api/_api_features.json
[add] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/common/extensions/api/quick_unlock_private.idl
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/chrome/common/extensions/api/schemas.gypi
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/extensions/browser/api_test_utils.cc
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/extensions/browser/api_test_utils.h
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/422a5b1d21c2f099e656d63050e1322245e8ed8e/tools/metrics/histograms/histograms.xml

Blockedon: 623622
Blockedon: 624190
Blockedon: 624191
Blockedon: 624193
Blockedon: 624517
Project Member

Comment 25 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7982a71bf7df88606e941c00cbedf62a10077a38

commit 7982a71bf7df88606e941c00cbedf62a10077a38
Author: jdufault <jdufault@chromium.org>
Date: Wed Jun 29 23:12:32 2016

Add the authenticate screen for the quick unlock settings.

The authenticate screen verifies the user's account password, since the quick
unlock settings control how the device is unlocked from the lock screen after
the user has signed in.

This also adds the entry-point for quick unlock settings to the people page.

The authenticate screen is available from the /quickUnlock/authenticate
endpoint.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2091143002
Cr-Commit-Position: refs/heads/master@{#402984}

[modify] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/people_page.js
[add] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.html
[add] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.js
[add] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.html
[add] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.js
[modify] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/7982a71bf7df88606e941c00cbedf62a10077a38/chrome/browser/resources/settings/settings_resources.grd

Comment 26 by willg...@gmail.com, Jun 30 2016

Question: Is this restricted to the lock screen or will this apply to login as well?
Re #26: This is lock screen only.
Blockedon: 626079
Labels: -M-53 M-54
Blockedon: 627928
Blockedon: 627937
Blockedon: 627938
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df378cb5f75628d6fac7d889aaa61614ba0cfd1c

commit df378cb5f75628d6fac7d889aaa61614ba0cfd1c
Author: jdufault <jdufault@chromium.org>
Date: Wed Jul 13 20:01:06 2016

Add a settings screen that lets the user choose how they unlock their device.

Currently, the user can unlock their device using one of three methods:
  - their password,
  - a PIN or password,
  - no authentication.

The setup pin screen is in a dependent CL.

The choose-method screen is available from the /quickUnlock/chooseMethod
endpoint.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2097673002
Cr-Commit-Position: refs/heads/master@{#405249}

[modify] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/people_page/people_page.html
[add] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.html
[add] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[add] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/people_page/quick_unlock_password_detect_behavior.html
[add] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/people_page/quick_unlock_password_detect_behavior.js
[modify] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/df378cb5f75628d6fac7d889aaa61614ba0cfd1c/chrome/browser/resources/settings/settings_resources.grd

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67cc9c5013f62aeb24b87a3a513bd590cdfc186c

commit 67cc9c5013f62aeb24b87a3a513bd590cdfc186c
Author: jdufault <jdufault@chromium.org>
Date: Wed Jul 13 23:34:51 2016

Add settings screen that lets a user setup a PIN to unlock their device with.

When a PIN is enabled, when the user locks their device (but *only* when they
are signed in), the lockscreen will show a PIN keyboard they can use to
authenticate against.

The setup-pin screen is accessed from the choose method screen (added in a
dependency CL). It is available from the /quickUnlock/setupPin endpoint.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2098663002
Cr-Commit-Position: refs/heads/master@{#405348}

[modify] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/people_page/quick_unlock_routing_behavior.js
[add] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.html
[add] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js
[modify] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/67cc9c5013f62aeb24b87a3a513bd590cdfc186c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Blockedon: 629662
Blockedon: 630384
Blockedon: 630385
Project Member

Comment 38 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9eeec1132cd9cf699523c79c36150b9b699eefb

commit f9eeec1132cd9cf699523c79c36150b9b699eefb
Author: jdufault <jdufault@chromium.org>
Date: Fri Jul 22 23:27:23 2016

Enable PIN configuration settings.

BUG= 603217 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150763002
Cr-Commit-Position: refs/heads/master@{#407296}

[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/about_flags.cc
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/chromeos/login/quick_unlock/pin_storage.h
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc
[add] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.cc
[add] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/common/chrome_features.cc
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/chrome/common/chrome_features.h
[modify] https://crrev.com/f9eeec1132cd9cf699523c79c36150b9b699eefb/tools/metrics/histograms/histograms.xml

Blockedon: 632055
Blockedon: 632383
Cc: dchan@chromium.org krishna...@chromium.org
Blockedon: 632797
Project Member

Comment 43 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b85bf3da4dce1a0eece3b5763adb6b2861ee3a9a

commit b85bf3da4dce1a0eece3b5763adb6b2861ee3a9a
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jul 28 21:45:47 2016

libchromeos-ui: Add Chromium --enable-features support.

Add ChromiumCommandBuilder::AddFeatureEnableOverride() and a
"enable-features=" directive to chrome_dev.conf, either of
which may be used to list features that should be passed via
Chromium's --enable-features flag.

BUG= chromium:603217 
TEST=added unit tests

Change-Id: Ie4e6abd7b0217116243fc5e73fb07ff81c18a3bf
Reviewed-on: https://chromium-review.googlesource.com/364241
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>

[modify] https://crrev.com/b85bf3da4dce1a0eece3b5763adb6b2861ee3a9a/login_manager/chrome_dev.conf
[modify] https://crrev.com/b85bf3da4dce1a0eece3b5763adb6b2861ee3a9a/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/b85bf3da4dce1a0eece3b5763adb6b2861ee3a9a/libchromeos-ui/chromeos/ui/chromium_command_builder.h
[modify] https://crrev.com/b85bf3da4dce1a0eece3b5763adb6b2861ee3a9a/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc

 Issue 623344  has been merged into this issue.
Merging  Issue 623344  into this one seems (to me) to conflict with the question & response given in comments #26 & #27 where it was stated that the PIN code was for the lock screen only.

It may be that the intended application has been expanded but could we get a clarification on this please?
The current plan is for lock screen only. It'd be great to support login as well, but there are some security considerations that have to be thought through and addressed first.
Cc: trapti@chromium.org
Agreed that we should keep  issue 623344  to track login.

Comment 49 by berg...@gmail.com, Aug 5 2016

Well even if I have to login with the 38 character password once when rebooting the Chromebook, that would be ok, but every time I wake it from sleep? Couldn’t that be given a pin?
> Well even if I have to login with the 38 character password once when rebooting the Chromebook, that would be ok, but every time I wake it from sleep? Couldn’t that be given a pin?

Yes, that's when PIN will work - when waking from sleep. You can use it to unlock a device you've already signed into (ie, the lock screen by hitting Search-L). You cannot use it to sign into a device (ie, from a boot).

Comment 51 by dchan@google.com, Aug 17 2016

Labels: MovedFrom-54
Cc: dhadd...@chromium.org
Blockedon: -616674
Project Member

Comment 55 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3056b258be9b7bfcc125199e2d909aa2c2455b81

commit 3056b258be9b7bfcc125199e2d909aa2c2455b81
Author: jdufault <jdufault@chromium.org>
Date: Thu Dec 15 20:47:03 2016

Enable PIN unlock by default.

Approved for m57 in crbug.com/666899.

BUG= 603217 

Review-Url: https://codereview.chromium.org/2418983004
Cr-Commit-Position: refs/heads/master@{#438918}

[modify] https://crrev.com/3056b258be9b7bfcc125199e2d909aa2c2455b81/chrome/common/chrome_features.cc

Status: Fixed (was: Started)

Comment 57 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 58 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 59 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
Verified on ChromeOS 9592.22.0, 60.0.3112.34

Sign in to add a comment