Large, high-entropy compressed messages sometimes span >1 framed message. |
|||
Issue descriptionThe Zlib compressor implementation code does not reliably fit large, incompressible BlimpMessages into the preallocated buffer, which can result in messages missing up to three bytes from the end. The missing bytes are found in the beginning of the subsequent message.
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/581a3f83eeb9241f698095f552813c355f2426c2 commit 581a3f83eeb9241f698095f552813c355f2426c2 Author: kmarshall <kmarshall@chromium.org> Date: Wed Apr 13 23:46:59 2016 Blimp: add padding for zlib framing to buffer preallocation calculations. Without the padding, messages with very low compression rates can exceed the size of the preallocated buffer, causing some trailing bytes to be written to subsequent messages. R=wez@chromium.org BUG= 603213 Review URL: https://codereview.chromium.org/1882043003 Cr-Commit-Position: refs/heads/master@{#387152} [modify] https://crrev.com/581a3f83eeb9241f698095f552813c355f2426c2/blimp/net/compressed_packet_unittest.cc [modify] https://crrev.com/581a3f83eeb9241f698095f552813c355f2426c2/blimp/net/compressed_packet_writer.cc
,
Apr 13 2016
,
Dec 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kmarshall@chromium.org
, Apr 13 2016