mojom() should not declare .mojom.js as data |
||
Issue descriptionSince mojom.js files are often packaged within .pak files, it's not always correct to list them as data. Instead, clients that use them as such should list them explicitly via: data = ["$target_gen_dir/target_name.mojom.js"]
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a commit 9e737bfc5e4d818bc14f8282c4a0c241ef810c0a Author: yzshen <yzshen@chromium.org> Date: Wed Jun 21 19:38:23 2017 Mojo JS bindings: introduce new targets "foo_js"/"foo_js_data_deps" for mojom("foo"). foo_js: JavaScript bindings; used as compile-time deps. foo_js_data_deps: JavaScript bindings; used as run-time deps. The target "foo" no longer generates the JS code or declare the JS code as runtime deps. BUG= 603212 Review-Url: https://codereview.chromium.org/2944153002 Cr-Commit-Position: refs/heads/master@{#481277} [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/chrome/browser/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/chrome/renderer/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/content/test/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/extensions/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/headless/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/ios/web/test/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/edk/js/tests/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/public/interfaces/bindings/tests/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/public/js/BUILD.gn [modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/public/tools/bindings/mojom.gni
,
Jun 21 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8b216bbd914a0e91b66d13b2030735c2ee2d964 commit c8b216bbd914a0e91b66d13b2030735c2ee2d964 Author: yzshen <yzshen@chromium.org> Date: Thu Jun 22 19:22:11 2017 Remove the speical case that we don't push mojom.js data deps to device on Android. The mojom("foo") GN template now only marks generated mojom.js files as data deps for the "foo_js_data_deps" target. So it is no longer an issue. For example, now $grep '\.mojom\.js' out/Debug/gen/content/test/content_unittests_apk.native.runtimedeps | wc -l 2 (The two mojom.js files are from //mojo/public/js/bindings, which is going to be removed soon.) BUG= 603212 Review-Url: https://codereview.chromium.org/2952223002 Cr-Commit-Position: refs/heads/master@{#481623} [modify] https://crrev.com/c8b216bbd914a0e91b66d13b2030735c2ee2d964/build/android/pylib/utils/device_dependencies.py |
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Apr 14 2017Status: Untriaged (was: Available)