New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603212 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mojom() should not declare .mojom.js as data

Project Member Reported by agrieve@chromium.org, Apr 13 2016

Issue description

Since mojom.js files are often packaged within .pak files, it's not always correct to list them as data. Instead, clients that use them as such should list them explicitly via:

data = ["$target_gen_dir/target_name.mojom.js"]
 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a

commit 9e737bfc5e4d818bc14f8282c4a0c241ef810c0a
Author: yzshen <yzshen@chromium.org>
Date: Wed Jun 21 19:38:23 2017

Mojo JS bindings: introduce new targets "foo_js"/"foo_js_data_deps" for  mojom("foo").

foo_js: JavaScript bindings; used as compile-time deps.
foo_js_data_deps: JavaScript bindings; used as run-time deps.

The target "foo" no longer generates the JS code or declare the JS code as runtime deps.

BUG= 603212 

Review-Url: https://codereview.chromium.org/2944153002
Cr-Commit-Position: refs/heads/master@{#481277}

[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/chrome/browser/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/chrome/renderer/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/content/test/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/extensions/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/headless/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/ios/web/test/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/edk/js/tests/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/public/js/BUILD.gn
[modify] https://crrev.com/9e737bfc5e4d818bc14f8282c4a0c241ef810c0a/mojo/public/tools/bindings/mojom.gni

Comment 3 by yzshen@chromium.org, Jun 21 2017

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8b216bbd914a0e91b66d13b2030735c2ee2d964

commit c8b216bbd914a0e91b66d13b2030735c2ee2d964
Author: yzshen <yzshen@chromium.org>
Date: Thu Jun 22 19:22:11 2017

Remove the speical case that we don't push mojom.js data deps to device on Android.

The mojom("foo") GN template now only marks generated mojom.js files as
data deps for the "foo_js_data_deps" target. So it is no longer an
issue.

For example, now
$grep '\.mojom\.js'
out/Debug/gen/content/test/content_unittests_apk.native.runtimedeps | wc
-l
2

(The two mojom.js files are from //mojo/public/js/bindings, which is
going to be removed soon.)

BUG= 603212 

Review-Url: https://codereview.chromium.org/2952223002
Cr-Commit-Position: refs/heads/master@{#481623}

[modify] https://crrev.com/c8b216bbd914a0e91b66d13b2030735c2ee2d964/build/android/pylib/utils/device_dependencies.py

Sign in to add a comment