New issue
Advanced search Search tips

Issue 603206 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Agree on Dimension Terminology and Introduce Strong Types for Rect, Size, and Point

Project Member Reported by robliao@chromium.org, Apr 13 2016

Issue description

It's very easy to pass in a DIP point to a function that needs physical points. The terminology used in scaling also collides with coordinate systems (e.g. a point in the screen coordinate system (origin reference) or a point using screen dimensional measurement (actual physical pixel size).

First we should agree on the terminology to use for actual pixels on the screen (e.g. Native, Physical) and for virtualized pixels (e.g. DIP, Logical).

With this naming scheme, clean up Chromium to be consistent with the naming and introduce types that make it difficult to accidentally pass in a DIP point to a function that expects physical points (e.g. NativePoint or PhysicalPoint and DIPPoint or LogicalPoint).
 
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Status: Assigned (was: Available)

Sign in to add a comment