New issue
Advanced search Search tips

Issue 603186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 354261



Sign in to add a comment

in gn builds, app_mode_app_support target doesn't become clean, at least on Windows

Project Member Reported by thakis@chromium.org, Apr 13 2016

Issue description

https://codereview.chromium.org/1026833004/diff/20001/chrome/common/BUILD.gn?context=25&column_width=80&tab_spaces=8 added the app_mode_app_support static_library() target. On non-Mac, all sources are filtered out.

On Windows, lib.exe silently and successfully does nothing when run with no inputs. So app_mode_app_support.lib never is written and the edge stays dirty always.

Maybe the best fix is to make that target a source_set.

(see also https://llvm.org/bugs/show_bug.cgi?id=27335)

My gn args are just `is_component_build=true`, and I build with `ninja -C out\gn app_mode_app_support`.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06e0b2d518ba42ecc50b773d49a64620b9498ee

commit b06e0b2d518ba42ecc50b773d49a64620b9498ee
Author: pcc <pcc@chromium.org>
Date: Wed Apr 13 21:24:47 2016

Make app_mode_app_support a source_set.

BUG= 603186 
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1882773003

Cr-Commit-Position: refs/heads/master@{#387098}

[modify] https://crrev.com/b06e0b2d518ba42ecc50b773d49a64620b9498ee/chrome/common/BUILD.gn

Comment 2 by thakis@chromium.org, Apr 13 2016

Status: Fixed (was: Assigned)
Thanks!

Sign in to add a comment