New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603183 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature

Blocking:
issue 364359
issue 609064



Sign in to add a comment

bluetooth: mac: Implement service scanning

Project Member Reported by jlebel@chromium.org, Apr 13 2016

Issue description

Need implementation for service scanning.
 

Comment 1 by jlebel@chromium.org, Apr 13 2016

Cc: scheib@chromium.org fbeaufort@chromium.org

Comment 2 by scheib@chromium.org, Apr 15 2016

Status: Available (was: Untriaged)

Comment 3 by scheib@chromium.org, Apr 16 2016

Blocking: 364359
Blocking: 609064
Labels: M-52
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4b0978fd188d5eed6b8804ec39455bee19011eb

commit c4b0978fd188d5eed6b8804ec39455bee19011eb
Author: jlebel <jlebel@chromium.org>
Date: Tue May 10 00:31:58 2016

Support for scanning services, update and remove services.

Adding classes:
+ BluetoothLowEnergyPeripheralDelegate
+ BluetoothRemoteGattServiceMac
+ MockBluetoothCBServiceMac

Adding tests for the gatt services.

BUG= 603183 

Review-Url: https://codereview.chromium.org/1948763003
Cr-Commit-Position: refs/heads/master@{#392490}

[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/BUILD.gn
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/BUILD.gn
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth.gyp
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_low_energy_device_mac.h
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_low_energy_device_mac.mm
[add] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_low_energy_peripheral_delegate.h
[add] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm
[add] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_remote_gatt_service_mac.h
[add] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_remote_gatt_service_mac.mm
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/bluetooth_remote_gatt_service_unittest.cc
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/test/bluetooth_test_mac.h
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/test/bluetooth_test_mac.mm
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm
[add] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/test/mock_bluetooth_cbservice_mac.h
[add] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/bluetooth/test/mock_bluetooth_cbservice_mac.mm
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/device/device_tests.gyp
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c4b0978fd188d5eed6b8804ec39455bee19011eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2016

Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1640ea3d56ce7cfc6a4936525f8bf401d40bb1d7

commit 1640ea3d56ce7cfc6a4936525f8bf401d40bb1d7
Author: jlebel <jlebel@chromium.org>
Date: Tue May 10 22:45:35 2016

Finishing: https://codereview.chromium.org/1948763003

Adding DCHECK to make sure a service has been added when it has been discovered.

BUG= 603183 

Review-Url: https://codereview.chromium.org/1965023002
Cr-Commit-Position: refs/heads/master@{#392756}

[modify] https://crrev.com/1640ea3d56ce7cfc6a4936525f8bf401d40bb1d7/device/bluetooth/bluetooth_low_energy_device_mac.mm

Status: Fixed (was: Available)
Fixed in Chrome Canary for Mac 52.0.2734.0

Sign in to add a comment