Bulk-labelling blocking bugs for  Issue 603372 

bulk-tagging Phase1 for M52

migrating Phase2 stuff to M53

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I can take this one on.

Chatted with sky@:

NativeWidgetMac should listen for the system notification (NSControlTintDidChange, etc) and send off OnNativeThemeChanged to the view hierarchy. Should not actually be that difficult to do.

Three separate grayscaling algorithms attached. I think luminance looks best.

https://codereview.chromium.org/2251123002/

Deleted: aqua.png 7.9 KB

	aqua.png 7.9 KB View Download

Deleted: graphite linear.png 8.2 KB

	graphite linear.png 8.2 KB View Download

Deleted: graphite minmax.png 8.3 KB

	graphite minmax.png 8.3 KB View Download

Deleted: graphite luminance.png 8.3 KB

	graphite luminance.png 8.3 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c887d72b8386e9a40ad5c983c6b68fa6025471f1

commit c887d72b8386e9a40ad5c983c6b68fa6025471f1
Author: ellyjones <ellyjones@chromium.org>
Date: Mon Aug 22 21:57:04 2016

macviews: honor system control tint setting

This change:
1. Registers for the NSControlTintDidChange notification
2. Propagates OnNativeThemeChanged to all Views when that notification happens
3. Adds support for color tinting in NativeThemeMac
4. Changes NativeThemeMac to use tinted colors for buttons

BUG= 603176 

Review-Url: https://codereview.chromium.org/2251123002
Cr-Commit-Position: refs/heads/master@{#413547}

[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/native_theme/native_theme_mac.h
[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/native_theme/native_theme_mac.mm
[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/views/cocoa/views_nswindow_delegate.h
[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/views/cocoa/views_nswindow_delegate.mm
[modify] https://crrev.com/c887d72b8386e9a40ad5c983c6b68fa6025471f1/ui/views/controls/button/label_button.cc

estade@ recently fixed the radio button/checkbox focus ring drawing. When I run views_examples_with_content_exe in graphite mode the ring is still blue.

Also when I run views_examples_with_content_exe in normal mode the radio buttons/checkboxes draw with a dark gray. Is that a result of your change? This is on my Retina MacBook Pro.

Deleted: Screen Shot 2016-08-22 at 4.11.53 PM.png 13.3 KB

	Screen Shot 2016-08-22 at 4.11.53 PM.png 13.3 KB View Download

Deleted: Screen Shot 2016-08-22 at 4.12.17 PM.png 18.6 KB

	Screen Shot 2016-08-22 at 4.12.17 PM.png 18.6 KB View Download

I should've said that the dark gray (possibly black) is being used in graphite mode also. It's too dark.

I have not yet changed the colors on radiobuttons or focus rings; the change I landed just added wiring and changed buttons. I'll have a look at why the radio buttons are drawing in black like that, since they shouldn't be.

I figured estade@'s change bypassed your change so I was just letting you know. Radio button is a subclass of checkbox I think, so I expected your change to appear in both places. Even though I included radio button screenshots the checkbox control has the same problem with drawing in black.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c92845aeb1ed03fa761e87c4fb26061253e2a7d

commit 6c92845aeb1ed03fa761e87c4fb26061253e2a7d
Author: ellyjones <ellyjones@chromium.org>
Date: Wed Aug 31 10:52:27 2016

macviews: apply graphite tint to button colors when needed

BUG= 603176 

Review-Url: https://codereview.chromium.org/2292233002
Cr-Commit-Position: refs/heads/master@{#415605}

[modify] https://crrev.com/6c92845aeb1ed03fa761e87c4fb26061253e2a7d/ui/native_theme/native_theme_mac.h
[modify] https://crrev.com/6c92845aeb1ed03fa761e87c4fb26061253e2a7d/ui/native_theme/native_theme_mac.mm

Marking this as Fixed now. If you spot any controls that do not get graphite-ized, please file individual bugs for them :)

The Primary button is a solid block of gray in graphite mode - I'm thinking this may be too much, but I can't tell until we have Harmony panels up-and-running. So we may need to tweak their gray fill.