ChromeOS Hw and VM Tests failing due to extensions_to_load attribute error |
||||||||
Issue description
AttributeError: BrowserFinderOptions instance has no attribute 'extensions_to_load'
Traceback (most recent call last):
File "/usr/local/autotest/common_lib/test.py", line 804, in _call_test_function
return func(*args, **dargs)
File "/usr/local/autotest/common_lib/test.py", line 461, in execute
dargs)
File "/usr/local/autotest/common_lib/test.py", line 347, in _call_run_once_with_retry
postprocess_profiled_run, args, dargs)
File "/usr/local/autotest/common_lib/test.py", line 376, in _call_run_once
self.run_once(*args, **dargs)
File "/usr/local/autotest/tests/login_Cryptohome/login_Cryptohome.py", line 22, in run_once
with chrome.Chrome() as cr:
File "/usr/local/autotest/common_lib/cros/chrome.py", line 79, in __init__
extensions_to_load = finder_options.extensions_to_load
AttributeError: BrowserFinderOptions instance has no attribute 'extensions_to_load'
,
Apr 13 2016
Ethan, can you fix this? https://codereview.chromium.org/1874473006
,
Apr 13 2016
,
Apr 13 2016
Actually, this looks like it may need to be a fix in chromeos repo
,
Apr 13 2016
All you need is to replace finder_options.extensions_to_load with finder_options.browser_options.extensions_to_load
,
Apr 13 2016
Yup, though the code needs to work with old catapult and new catapult. It's doable.
,
Apr 13 2016
Ilja, please review: https://chromium-review.googlesource.com/#/c/338891/
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/531a62ab82e7f925959f5554de2ea80ae5d497bf commit 531a62ab82e7f925959f5554de2ea80ae5d497bf Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Apr 13 18:09:43 2016 extensions_to_load has moved to browser_options. BUG= chromium:603169 TEST=login_Cryptohome Change-Id: I96c0f91c64576a08fe19aed6fcb8803e477e42d8 Reviewed-on: https://chromium-review.googlesource.com/338891 Trybot-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ilja Friedel <ihf@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/531a62ab82e7f925959f5554de2ea80ae5d497bf/client/common_lib/cros/chrome.py
,
Apr 14 2016
Keeping this bug open because some code needs to be removed from chrome.py once the PFQ greens.
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2d706d8c2fd72cd74a076b2cf815f498f4ee3d73 commit 2d706d8c2fd72cd74a076b2cf815f498f4ee3d73 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Apr 15 19:53:17 2016 Remove cruft in gaia_id and extensions_to_load. BUG= chromium:603169 TEST=VM tests and HW tests Change-Id: I7671d66783ac8935e1458cf6b3f831d303fe468a Reviewed-on: https://chromium-review.googlesource.com/339251 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ilja Friedel <ihf@chromium.org> [modify] https://crrev.com/2d706d8c2fd72cd74a076b2cf815f498f4ee3d73/client/common_lib/cros/chrome.py
,
Apr 15 2016
,
Apr 18 2016
Should we also update the ebuild? I still see old telemetry after repo sync and rebuild.
,
Apr 18 2016
Where are you seeing the failure? I may have been too hasty in removing the WAR. You don't need to update the ebuild.
,
Apr 19 2016
I'm seeing the problem locally. And I found crbug.com/604134 having similar problem. We don't need to update ebuild for the telemetry change?
,
May 23 2016
Bulk verified
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6f4acccf48cb1dcdd0a5b45fc88e423f4fef14f0 commit 6f4acccf48cb1dcdd0a5b45fc88e423f4fef14f0 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Aug 23 21:03:44 2016 Cleanup chrome.py BUG= chromium:603169 TEST=hwtests Change-Id: Ieeb5cb895023db6938c9010d5aa7cdb95bc049b7 Reviewed-on: https://chromium-review.googlesource.com/374442 Commit-Ready: Ned Nguyen <nednguyen@google.com> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/6f4acccf48cb1dcdd0a5b45fc88e423f4fef14f0/client/common_lib/cros/chrome.py |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by achuith@chromium.org
, Apr 13 2016