New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603152 link

Starred by 2 users
Status: Verified
Owner:
shivanisha@chromium.org
Closed: May 2016
Cc:
█ bmcquade@chromium.org
jkarlin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Metrics for document.write script blocking

Project Member Reported by shivanisha@chromium.org, Apr 13 2016 
This metric is to answer the question: Is the document.write blocking work leading to page breaks?

Percentage of pages in slow networks that are blocked on third-party scripts invoked via document.write and hit reload at least once.

Comment 1 by shivanisha@chromium.org, Apr 13 2016 

Feature Bug: 599875

Comment 2 by shivanisha@chromium.org, Apr 26 2016

Summary: Metrics for document.write script blocking (was: page reloads for pages affected by doc.write blocking in UMA)
Log the metrics to see the impact of document.write script blocking
feature. The metrics are specifically for pages that have a blockable
document.written script.
This also includes a metric to count the number of reloads for such pages to
check if there is any increase in number of reloads possibly implying
page breaks.
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6340ed747c7d4dbeedff9c963b6bd27825dd03d

commit e6340ed747c7d4dbeedff9c963b6bd27825dd03d
Author: shivanisha <shivanisha@chromium.org>
Date: Wed May 04 16:08:22 2016

This CL logs the metrics to see the impact of document.write script blocking
feature. The metrics are specifically for pages that have a blockable
document.written script.
The CL also has a metric to count the number of reloads for such pages to
check if there is any increase in number of reloads possibly implying
page breaks.
BUG= 603152 

Review-Url: https://codereview.chromium.org/1918373002
Cr-Commit-Position: refs/heads/master@{#391526}

[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[add] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/test/data/page_load_metrics/document_write_async_script.html
[add] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/chrome/test/data/page_load_metrics/document_write_script_block.html
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/components/page_load_metrics/browser/page_load_metrics_util.cc
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/components/page_load_metrics/browser/page_load_metrics_util.h
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h
[modify] https://crrev.com/e6340ed747c7d4dbeedff9c963b6bd27825dd03d/tools/metrics/histograms/histograms.xml

Comment 4 by shivanisha@chromium.org, May 4 2016

Status: Verified (was: Assigned)

Comment 5 by bmcquade@chromium.org, May 5 2016

Labels: Merge-Request-51 OS-All

Comment 6 by tin...@google.com, May 5 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 7 by bugdroid1@chromium.org, May 6 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/373eee852ecbc50c9421f464133a4b0e0b93419e

commit 373eee852ecbc50c9421f464133a4b0e0b93419e
Author: Josh Karlin <jkarlin@chromium.org>
Date: Fri May 06 17:32:18 2016

This CL logs the metrics to see the impact of document.write script blocking feature. The metrics are specifically for pages that have a blockable document.written script. The CL also has a metric to count the number of reloads for such pages to check if there is any increase in number of reloads possibly implying page breaks. BUG= 603152 

Review-Url: https://codereview.chromium.org/1918373002
Cr-Commit-Position: refs/heads/master@{#391526}
(cherry picked from commit e6340ed747c7d4dbeedff9c963b6bd27825dd03d)

BUG= 603152 

Review URL: https://codereview.chromium.org/1957703002 .

Cr-Commit-Position: refs/branch-heads/2704@{#425}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[add] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/test/data/page_load_metrics/document_write_async_script.html
[add] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/chrome/test/data/page_load_metrics/document_write_script_block.html
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/components/page_load_metrics/browser/page_load_metrics_util.cc
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/components/page_load_metrics/browser/page_load_metrics_util.h
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h
[modify] https://crrev.com/373eee852ecbc50c9421f464133a4b0e0b93419e/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment