Make it easier to get to Physical Web settings from within Physical Web Activity |
|||||
Issue descriptionToday if you see a PW notification and decide you want to mute/disable it, its hard to know where to look. Several users have reported not knowing where to disable notifications, and may resort to turning off all notifications for the Chrome app instead. Naturally users seem to expect that they can disable the feature from within the PW Activity after tapping on the notification. Most apps have a menu with a settings link. For now, we can probably just link out to the existing Privacy settings.
,
May 23 2016
We should have mocks, see comment from nyquist at https://codereview.chromium.org/2003023003/
,
May 23 2016
I'll check with UI review
,
May 23 2016
Just saw the codereview ping -- seems like uploading screenshot is OK.
,
May 24 2016
Ani, Scott, would you all be fine with moving the X to the left? https://codereview.chromium.org/2005113002
,
May 24 2016
I really think X should be rightmost. If it is not rightmost, it does not feel like a "close" button but instead some sort of "stop/cancel" button.
,
May 24 2016
+1 -- the Android convention is to put the X on the right, so I think we should follow that pattern.
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72065e5edc05138c0e0a5cb95bc573a6bf93909b commit 72065e5edc05138c0e0a5cb95bc573a6bf93909b Author: cco3 <cco3@chromium.org> Date: Thu May 26 01:09:06 2016 Add a settings button to Physical Web activity Users currently don't have an easy way to get to the Physical Web settings apart from navigating through the privacy preferences. This change gives them an easy way directly from the ListUrlsActivity. BUG= 603132 Review-Url: https://codereview.chromium.org/2003023003 Cr-Commit-Position: refs/heads/master@{#396068} [modify] https://crrev.com/72065e5edc05138c0e0a5cb95bc573a6bf93909b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
,
May 26 2016
,
May 26 2016
Reopening...I misread note about the icon order.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c87ec1b2118585a557696b4f963df0f5d975c44 commit 7c87ec1b2118585a557696b4f963df0f5d975c44 Author: cco3 <cco3@chromium.org> Date: Tue May 31 23:46:42 2016 Use onOptionsItemSelected in Physical Web activity Using onOptionsItemsSelected will let us handle menu items click more nicely without a bunch of anonymous classes. BUG= 603132 Review-Url: https://codereview.chromium.org/2018593002 Cr-Commit-Position: refs/heads/master@{#396979} [modify] https://crrev.com/7c87ec1b2118585a557696b4f963df0f5d975c44/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/7c87ec1b2118585a557696b4f963df0f5d975c44/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13ff7bc554389e439c997f8f5122200b2c123193 commit 13ff7bc554389e439c997f8f5122200b2c123193 Author: cco3 <cco3@chromium.org> Date: Fri Jun 03 17:59:07 2016 Move close button to right in the PW Activity This change moves the close button to the far right in the Physical Web ListUrlsActivity. BUG= 603132 Review-Url: https://codereview.chromium.org/2027033002 Cr-Commit-Position: refs/heads/master@{#397751} [modify] https://crrev.com/13ff7bc554389e439c997f8f5122200b2c123193/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
,
Jun 3 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cco3@chromium.org
, May 13 2016