startup.large_profile.cold.blank_page failing on multiple platforms |
|||||||
Issue description
,
Apr 13 2016
,
Apr 13 2016
Firt one was going too slow, started a second one on a different platform here: https://chromeperf.appspot.com/buildbucket_job_status/9015472099179531920 I forgot to fill in the bug number, I'll keep an eye on it and report results here.
,
Apr 13 2016
@@@STEP_LOG_LINE@json.output@ "culprit_data": {@@@
@@@STEP_LOG_LINE@json.output@ "author": "gurrrik", @@@
@@@STEP_LOG_LINE@json.output@ "cl": "70390020b54d46b4d34f96429c1db62b1f0629c4", @@@
@@@STEP_LOG_LINE@json.output@ "cl_date": "Wed Apr 13 09:15:43 2016", @@@
@@@STEP_LOG_LINE@json.output@ "commit_info": "\nThere will be a separate review for removing this logic from SharedPageState.\nMore info: https://codereview.chromium.org/1871033002/\n\nBUG=\n\nReview URL: https://codereview.chromium.org/1884493002\n\nCr-Commit-Position: refs/heads/master@{#386943}", @@@
@@@STEP_LOG_LINE@json.output@ "email": "gurrrik@yandex-team.ru", @@@
@@@STEP_LOG_LINE@json.output@ "revisions_links": [], @@@
@@@STEP_LOG_LINE@json.output@ "subject": "Move profile handling code to a child class of SharedPageState"@@@
@@@STEP_LOG_LINE@json.output@ }, @@@
Reverting now. Cannot assign ownership to gurrrik though "Issue owner must be a project member"
revert: https://codereview.chromium.org/1879193005/
,
Apr 14 2016
Bots are starting to green up. Keeping this bug open until gurrrik@yandex-team.ru has a chance to weigh in on it. Downgrading to p2
,
Apr 15 2016
Oops, sorry for breaking the tests. Looks like I messed up in that CL when renaming variables. I'll correct those mistakes and submit a new CL. Thanks for letting me know.
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a99b2a7e905842c5ac80617ef666aff8459d541 commit 7a99b2a7e905842c5ac80617ef666aff8459d541 Author: gurrrik <gurrrik@yandex-team.ru> Date: Fri Apr 15 21:18:43 2016 Move profile handling code to a child class of SharedPageState There will be a separate review for removing this logic from SharedPageState. More info: https://codereview.chromium.org/1871033002/ BUG= 603121 Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4 Cr-Commit-Position: refs/heads/master@{#386943} Review URL: https://codereview.chromium.org/1884493002 Cr-Commit-Position: refs/heads/master@{#387697} [modify] https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541/tools/perf/page_sets/pregenerated_large_profile_shared_state.py [add] https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541/tools/perf/page_sets/pregenerated_profile_shared_state.py
,
Apr 15 2016
CCing current perfbot sherrif.
,
May 5 2016
I think this can be considered fixed now, as bots are green again. Thanks gurrrik! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rnep...@chromium.org
, Apr 13 2016