New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603121 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

startup.large_profile.cold.blank_page failing on multiple platforms

Project Member Reported by rnep...@chromium.org, Apr 13 2016

Issue description

Cc: sullivan@chromium.org nednguyen@chromium.org
Bisect here:
https://chromeperf.appspot.com/buildbucket_job_status/9015488693838037072
Labels: -Pri-3 Performance-BotHealth Pri-2
Cc: rnep...@chromium.org
Labels: -Pri-2 Pri-1
Firt one was going too slow, started a second one on a different platform here:
https://chromeperf.appspot.com/buildbucket_job_status/9015472099179531920

I forgot to fill in the bug number, I'll keep an eye on it and report results here.
Cc: gurr...@yandex-team.ru
@@@STEP_LOG_LINE@json.output@    "culprit_data": {@@@
@@@STEP_LOG_LINE@json.output@      "author": "gurrrik", @@@
@@@STEP_LOG_LINE@json.output@      "cl": "70390020b54d46b4d34f96429c1db62b1f0629c4", @@@
@@@STEP_LOG_LINE@json.output@      "cl_date": "Wed Apr 13 09:15:43 2016", @@@
@@@STEP_LOG_LINE@json.output@      "commit_info": "\nThere will be a separate review for removing this logic from SharedPageState.\nMore info: https://codereview.chromium.org/1871033002/\n\nBUG=\n\nReview URL: https://codereview.chromium.org/1884493002\n\nCr-Commit-Position: refs/heads/master@{#386943}", @@@
@@@STEP_LOG_LINE@json.output@      "email": "gurrrik@yandex-team.ru", @@@
@@@STEP_LOG_LINE@json.output@      "revisions_links": [], @@@
@@@STEP_LOG_LINE@json.output@      "subject": "Move profile handling code to a child class of SharedPageState"@@@
@@@STEP_LOG_LINE@json.output@    }, @@@

Reverting now. Cannot assign ownership to gurrrik though "Issue owner must be a project member"

revert: https://codereview.chromium.org/1879193005/
Labels: -Pri-1 Pri-2
Bots are starting to green up. Keeping this bug open until gurrrik@yandex-team.ru has a chance to weigh in on it. Downgrading to p2
Oops, sorry for breaking the tests.

Looks like I messed up in that CL when renaming variables. I'll correct those mistakes and submit a new CL. Thanks for letting me know.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a99b2a7e905842c5ac80617ef666aff8459d541

commit 7a99b2a7e905842c5ac80617ef666aff8459d541
Author: gurrrik <gurrrik@yandex-team.ru>
Date: Fri Apr 15 21:18:43 2016

Move profile handling code to a child class of SharedPageState

There will be a separate review for removing this logic from SharedPageState.
More info: https://codereview.chromium.org/1871033002/

BUG= 603121 

Committed: https://crrev.com/70390020b54d46b4d34f96429c1db62b1f0629c4
Cr-Commit-Position: refs/heads/master@{#386943}

Review URL: https://codereview.chromium.org/1884493002

Cr-Commit-Position: refs/heads/master@{#387697}

[modify] https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541/tools/perf/page_sets/pregenerated_large_profile_shared_state.py
[add] https://crrev.com/7a99b2a7e905842c5ac80617ef666aff8459d541/tools/perf/page_sets/pregenerated_profile_shared_state.py

Cc: dtu@chromium.org
CCing current perfbot sherrif.
Cc: qyears...@chromium.org
Status: Fixed (was: Untriaged)
I think this can be considered fixed now, as bots are green again. Thanks gurrrik!

Sign in to add a comment