New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 603026 link

Starred by 3 users
Status: Fixed
Owner:
█ sfiera@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ n...@chromium.org
█ bauerb@chromium.org
█ markusheintz@chromium.org
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 583289
issue 607111
issue 619585
issue 514752
issue 590196
issue 617966
issue 619570
issue 619584



Sign in to add a comment

Move MostVisitedSites into component "ntp_tiles"

Project Member Reported by treib@chromium.org, Apr 13 2016 
There is a class MostVisitedSites (at chrome/browser/android/ntp/most_visited_sites.h) which populates the tile grid on the Android NTP. It gets suggestions from MostLikely or TopSites, mixes in Popular Sites and Whitelists if appropriate, and passes everything to the native Java UI.

This class should be split into the Android-specific part (Java bindings) and the logic. Then the logic should be moved into a new components, called maybe "ntp_tiles" or something like that.

The users of the new component will be:
- (immediately) The Android NTP.
- (soon) components/ntp_snippets.
- (soon) The (local) desktop NTP.

Comment 1 by treib@chromium.org, Apr 13 2016

Summary: Move MostVisitedSites into a component ("ntp_tiles"?) (was: Move MostVisitedSites into a components ("ntp_tiles"?))

Comment 2 by sfiera@chromium.org, Apr 15 2016

Labels: zine-mr-iter-11
One CL in review, N to go.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e7993c61536d7cd7ad7eeaa8e60ff07994c0c46

commit 1e7993c61536d7cd7ad7eeaa8e60ff07994c0c46
Author: sfiera <sfiera@chromium.org>
Date: Mon Apr 18 09:43:26 2016

NTP tiles: split methods into C++ and Java parts.

This should be basically all of the "code change" necessary to split out
the component, though there will be a lot more code movement. For now,
C++ and Java methods remain as overloads in the same class.

BUG= 603026 

Review URL: https://codereview.chromium.org/1884203002

Cr-Commit-Position: refs/heads/master@{#387878}

[modify] https://crrev.com/1e7993c61536d7cd7ad7eeaa8e60ff07994c0c46/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/1e7993c61536d7cd7ad7eeaa8e60ff07994c0c46/chrome/browser/android/ntp/most_visited_sites.h

Comment 5 by sfiera@chromium.org, Apr 22 2016

Labels: zine-mr-iter-12
Making progress. Next up is the move to components/, for which I will have to actually understand components.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8df7b38b9f5e4d19e7db9b62a2e4f2ae2a83c6eb

commit 8df7b38b9f5e4d19e7db9b62a2e4f2ae2a83c6eb
Author: sfiera <sfiera@chromium.org>
Date: Tue Apr 26 14:06:33 2016

Update MostVisitedSites observer interface.

Move MostVisitedSitesObserver to MostVisitedSites::Observer. Define its
methods in terms of MostVisitedSites::Suggestion and PopularSites::Site.
This is nicer than coordinated lists of strings.

The Java interface remains unchanged, because lists of strings are
easier to pass across the JNI barrier.

BUG= 603026 

Review URL: https://codereview.chromium.org/1919823002

Cr-Commit-Position: refs/heads/master@{#389775}

[modify] https://crrev.com/8df7b38b9f5e4d19e7db9b62a2e4f2ae2a83c6eb/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/8df7b38b9f5e4d19e7db9b62a2e4f2ae2a83c6eb/chrome/browser/android/ntp/most_visited_sites.h
[modify] https://crrev.com/8df7b38b9f5e4d19e7db9b62a2e4f2ae2a83c6eb/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/8df7b38b9f5e4d19e7db9b62a2e4f2ae2a83c6eb/chrome/browser/android/ntp/most_visited_sites_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1f161a43ad6973cdc3494a132e5c18e7874db50

commit e1f161a43ad6973cdc3494a132e5c18e7874db50
Author: sfiera <sfiera@chromium.org>
Date: Wed Apr 27 08:20:47 2016

More consistency in m_v_s_bridge.cc.

Vectors by reservation only. No pushing.

BUG= 603026 

Review URL: https://codereview.chromium.org/1921933004

Cr-Commit-Position: refs/heads/master@{#390020}

[modify] https://crrev.com/e1f161a43ad6973cdc3494a132e5c18e7874db50/chrome/browser/android/ntp/most_visited_sites.h
[modify] https://crrev.com/e1f161a43ad6973cdc3494a132e5c18e7874db50/chrome/browser/android/ntp/most_visited_sites_bridge.cc

Comment 8 by treib@chromium.org, Apr 27 2016

Blocking: 607111
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f7106fdd0ea5329422ccf7af6d4a90d691635b

commit c6f7106fdd0ea5329422ccf7af6d4a90d691635b
Author: sfiera <sfiera@chromium.org>
Date: Thu Apr 28 12:45:16 2016

Remove Profile dependency from PopularSites.

Still depends on FileDownloader, but that's more difficult to work around, and it's lightweight enough that it could and probably should go into components itself.

BUG= 603026 

Review-Url: https://codereview.chromium.org/1919043005
Cr-Commit-Position: refs/heads/master@{#390357}

[modify] https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b/chrome/browser/android/ntp/popular_sites.h
[modify] https://crrev.com/c6f7106fdd0ea5329422ccf7af6d4a90d691635b/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dc4da510e5dbbf2a6197c0eb03500d64568652a

commit 0dc4da510e5dbbf2a6197c0eb03500d64568652a
Author: sfiera <sfiera@chromium.org>
Date: Fri Apr 29 09:23:05 2016

Create //components/ntp_tiles.

Move its prefs and switches in immediately. Later will follow
//chrome/browser/android/ntp/{most_visited_sites,popular_sites}*, as the
work to refactor out their dependencies is ongoing.

BUG= 603026 

Review-Url: https://codereview.chromium.org/1928913002
Cr-Commit-Position: refs/heads/master@{#390605}

[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/browser/BUILD.gn
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/browser/about_flags.cc
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/chrome_browser.gypi
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/common/chrome_switches.cc
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/common/chrome_switches.h
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/common/pref_names.cc
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/chrome/common/pref_names.h
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/OWNERS
[modify] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/components.gyp
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles.gypi
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles/BUILD.gn
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles/OWNERS
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles/pref_names.cc
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles/pref_names.h
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles/switches.cc
[add] https://crrev.com/0dc4da510e5dbbf2a6197c0eb03500d64568652a/components/ntp_tiles/switches.h
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/728962fd55a559c3ca9ca4004c59abde173367f7

commit 728962fd55a559c3ca9ca4004c59abde173367f7
Author: sfiera <sfiera@chromium.org>
Date: Fri Apr 29 11:04:02 2016

Invoke factories once in MostVisitedSites().

Instances will be injected from outside in the future. For now,
initialize them once in the constructor.

BUG= 603026 

Review-Url: https://codereview.chromium.org/1930353002
Cr-Commit-Position: refs/heads/master@{#390615}

[modify] https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/728962fd55a559c3ca9ca4004c59abde173367f7/chrome/browser/android/ntp/most_visited_sites.h

Comment 12 by sfiera@chromium.org, Apr 29 2016

Labels: zine-mr-iter-13

Comment 14 by sfiera@chromium.org, May 3 2016

Summary: Move MostVisitedSites into component "ntp_tiles" (was: Move MostVisitedSites into a component ("ntp_tiles"?))
The component exists; the name is no longer in question.
Project Member

Comment 15 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e952d4bf6eb67eee34c97264eed9d65b323fd75

commit 7e952d4bf6eb67eee34c97264eed9d65b323fd75
Author: sfiera <sfiera@chromium.org>
Date: Wed May 04 17:56:33 2016

Remove most of the dependencies on //chrome/...

Pull them in from the Java bridge.

Remaining are SupervisedUserService and FileDownloader. The former will
require more non-trivial work, and the latter doesn't really make sense
to stub out.

Put URLDataSource registration in bridge. It won't fit into a component,
and it can only be allowed to happen on Android, because other code is
responsible for it on other platforms. It doesn't really belong in
either place, but it has to go somewhere for now.

BUG= 603026 

Review-Url: https://codereview.chromium.org/1941713002
Cr-Commit-Position: refs/heads/master@{#391556}

[modify] https://crrev.com/7e952d4bf6eb67eee34c97264eed9d65b323fd75/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/7e952d4bf6eb67eee34c97264eed9d65b323fd75/chrome/browser/android/ntp/most_visited_sites.h
[modify] https://crrev.com/7e952d4bf6eb67eee34c97264eed9d65b323fd75/chrome/browser/android/ntp/most_visited_sites_bridge.cc

Comment 16 by sfiera@chromium.org, May 6 2016

Labels: zine-mr-iter-14
Third-to-last (?) CL out for review.
Project Member

Comment 17 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685a987e98a2f1d4ae54fcb526a923602bf9b998

commit 685a987e98a2f1d4ae54fcb526a923602bf9b998
Author: sfiera <sfiera@chromium.org>
Date: Thu May 12 17:08:47 2016

Remove PopularSites' dependencies on //chrome/....

1.  Fetch popular sites directly from PopularSites.

2.  Move chrome paths dependency out of PopularSites.

    Also, add better error-handling for if PathService::Get() fails. In that
    case, immediately bail in PopularSites with failure.

3.  Sanitize JSON before writing it to file.

    Rather than downloading directly to a temporary file, download to a
    string and sanitize it before writing to the file. When reading from a
    cached file, don't bother sanitizing it.

BUG= 603026 

Review-Url: https://codereview.chromium.org/1957313003
Cr-Commit-Position: refs/heads/master@{#393278}

[modify] https://crrev.com/685a987e98a2f1d4ae54fcb526a923602bf9b998/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/685a987e98a2f1d4ae54fcb526a923602bf9b998/chrome/browser/android/ntp/most_visited_sites.h
[modify] https://crrev.com/685a987e98a2f1d4ae54fcb526a923602bf9b998/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/685a987e98a2f1d4ae54fcb526a923602bf9b998/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/685a987e98a2f1d4ae54fcb526a923602bf9b998/chrome/browser/android/ntp/popular_sites.h
[modify] https://crrev.com/685a987e98a2f1d4ae54fcb526a923602bf9b998/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
Project Member

Comment 18 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79e643bb8dec304b745f91e83a112d19c2a62eb7

commit 79e643bb8dec304b745f91e83a112d19c2a62eb7
Author: sfiera <sfiera@chromium.org>
Date: Fri May 13 16:52:49 2016

Remove MostVisitedSites => SupervisedUserService dep.

Replace SupervisedUserService in MostVisitedSites with an interface.
Implement it in most_visited_sites_bridge.cc on top of
SupervisedUserService.

BUG= 603026 

Review-Url: https://codereview.chromium.org/1954973004
Cr-Commit-Position: refs/heads/master@{#393553}

[modify] https://crrev.com/79e643bb8dec304b745f91e83a112d19c2a62eb7/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/79e643bb8dec304b745f91e83a112d19c2a62eb7/chrome/browser/android/ntp/most_visited_sites.h
[modify] https://crrev.com/79e643bb8dec304b745f91e83a112d19c2a62eb7/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/79e643bb8dec304b745f91e83a112d19c2a62eb7/chrome/browser/android/ntp/most_visited_sites_bridge.h
Project Member

Comment 19 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e0b88bd66abcb8ab5a649ac9c41479737819ad8

commit 3e0b88bd66abcb8ab5a649ac9c41479737819ad8
Author: sfiera <sfiera@chromium.org>
Date: Fri May 27 12:28:38 2016

Remove NTP dependency on //content/...

Provide threads to MostVisitedSites from MostVisitedSitesBridge; provide
those threads in turn to PopularSites. These classes are moving to
components, and the //content/... dep needs to be broken to compile on
iOS.

Moves the thumbnail read that was previously on the DB thread onto the
blocking thread pool so as to avoid needing to pass the DB thread in in
addition to the blocking pool.

BUG= 603026 

Review-Url: https://codereview.chromium.org/2012473002
Cr-Commit-Position: refs/heads/master@{#396445}

[modify] https://crrev.com/3e0b88bd66abcb8ab5a649ac9c41479737819ad8/chrome/browser/android/ntp/most_visited_sites.cc
[modify] https://crrev.com/3e0b88bd66abcb8ab5a649ac9c41479737819ad8/chrome/browser/android/ntp/most_visited_sites.h
[modify] https://crrev.com/3e0b88bd66abcb8ab5a649ac9c41479737819ad8/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/3e0b88bd66abcb8ab5a649ac9c41479737819ad8/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/3e0b88bd66abcb8ab5a649ac9c41479737819ad8/chrome/browser/android/ntp/popular_sites.h
[modify] https://crrev.com/3e0b88bd66abcb8ab5a649ac9c41479737819ad8/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da97c63efbc08e4056c686e9ad6db8393749d9f7

commit da97c63efbc08e4056c686e9ad6db8393749d9f7
Author: sfiera <sfiera@chromium.org>
Date: Thu Jun 02 14:29:28 2016

In PopularSites, parse (not sanitize) JSON safely.

All that JSON sanitization does is to parse it safely and then
reserialize it. For supporting unsafe JSON on iOS, it makes more sense
to me to inject a JSON parser (as we do in ntp_snippets), rather than a
JSON sanitizer. Then, we do the reserialization ourselves.

(this doesn't yet make the parser injectable)

BUG= 603026 

Review-Url: https://codereview.chromium.org/2031603002
Cr-Commit-Position: refs/heads/master@{#397394}

[modify] https://crrev.com/da97c63efbc08e4056c686e9ad6db8393749d9f7/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/da97c63efbc08e4056c686e9ad6db8393749d9f7/chrome/browser/android/ntp/popular_sites.h
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4eb2a57c8667ab31903237e3c316fcaf4afe718

commit e4eb2a57c8667ab31903237e3c316fcaf4afe718
Author: sfiera <sfiera@chromium.org>
Date: Tue Jun 07 13:22:06 2016

Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG= 603026 

Review-Url: https://codereview.chromium.org/2045563002
Cr-Commit-Position: refs/heads/master@{#398287}

[modify] https://crrev.com/e4eb2a57c8667ab31903237e3c316fcaf4afe718/chrome/browser/android/ntp/popular_sites.cc

Comment 22 by sfiera@chromium.org, Jun 7 2016

Blocking: 617966
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f8b53fd1b00bc82609c731bfea77e50cd123d51

commit 2f8b53fd1b00bc82609c731bfea77e50cd123d51
Author: sfiera <sfiera@chromium.org>
Date: Fri Jun 10 11:46:05 2016

Revert "Parse PopularSites JSON on iOS too."

This reverts commit e4eb2a57c8667ab31903237e3c316fcaf4afe718. We'll
switch to a callback after the move.

BUG= 603026 

Review-Url: https://codereview.chromium.org/2052213002
Cr-Commit-Position: refs/heads/master@{#399157}

[modify] https://crrev.com/2f8b53fd1b00bc82609c731bfea77e50cd123d51/chrome/browser/android/ntp/popular_sites.cc

Comment 24 by mastiz@chromium.org, Jun 13 2016

Blocking: 619570

Comment 25 by sfiera@chromium.org, Jun 13 2016

Blocking: 619584

Comment 26 by sfiera@chromium.org, Jun 13 2016

Blocking: 619585
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff01c0dd7b7b6955dafda763cbc120718dc00ef

commit 3ff01c0dd7b7b6955dafda763cbc120718dc00ef
Author: sfiera <sfiera@chromium.org>
Date: Mon Jun 13 15:33:38 2016

Move classes to //components/ntp_tiles.

Move MostVisitedSites and PopularSites; leave behind ChromePopularSites,
which depends on Chrome paths.

In the short term, there are no changes introduced by this CL; the same
code builds as before against the same dependencies. In the future,
multiple platforms' versions of the new tab page will share this part of
their implementation. (Android's NTP currently is all native code; on
other platforms we use HTML)

BUG= 603026 

Review-Url: https://codereview.chromium.org/1983063002
Cr-Commit-Position: refs/heads/master@{#399455}

[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/android/BUILD.gn
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/most_visited_sites_bridge.h
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/popular_sites.h
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/chrome.gyp
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/chrome_browser.gypi
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/BUILD.gn
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/components_tests.gyp
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles.gypi
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/BUILD.gn
[add] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/DEPS
[rename] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/most_visited_sites.cc
[rename] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/most_visited_sites.h
[rename] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/most_visited_sites_unittest.cc
[add] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/popular_sites.cc
[add] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/popular_sites.h
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f8b53fd1b00bc82609c731bfea77e50cd123d51

commit 2f8b53fd1b00bc82609c731bfea77e50cd123d51
Author: sfiera <sfiera@chromium.org>
Date: Fri Jun 10 11:46:05 2016

Revert "Parse PopularSites JSON on iOS too."

This reverts commit e4eb2a57c8667ab31903237e3c316fcaf4afe718. We'll
switch to a callback after the move.

BUG= 603026 

Review-Url: https://codereview.chromium.org/2052213002
Cr-Commit-Position: refs/heads/master@{#399157}

[modify] https://crrev.com/2f8b53fd1b00bc82609c731bfea77e50cd123d51/chrome/browser/android/ntp/popular_sites.cc
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff01c0dd7b7b6955dafda763cbc120718dc00ef

commit 3ff01c0dd7b7b6955dafda763cbc120718dc00ef
Author: sfiera <sfiera@chromium.org>
Date: Mon Jun 13 15:33:38 2016

Move classes to //components/ntp_tiles.

Move MostVisitedSites and PopularSites; leave behind ChromePopularSites,
which depends on Chrome paths.

In the short term, there are no changes introduced by this CL; the same
code builds as before against the same dependencies. In the future,
multiple platforms' versions of the new tab page will share this part of
their implementation. (Android's NTP currently is all native code; on
other platforms we use HTML)

BUG= 603026 

Review-Url: https://codereview.chromium.org/1983063002
Cr-Commit-Position: refs/heads/master@{#399455}

[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/android/BUILD.gn
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/most_visited_sites_bridge.h
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/android/ntp/popular_sites.h
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/chrome.gyp
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/chrome_browser.gypi
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/BUILD.gn
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/components_tests.gyp
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles.gypi
[modify] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/BUILD.gn
[add] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/DEPS
[rename] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/most_visited_sites.cc
[rename] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/most_visited_sites.h
[rename] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/most_visited_sites_unittest.cc
[add] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/popular_sites.cc
[add] https://crrev.com/3ff01c0dd7b7b6955dafda763cbc120718dc00ef/components/ntp_tiles/popular_sites.h

Comment 30 by sfiera@chromium.org, Jun 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment