content/shell/BUILD.gn is missing stuff |
||||
Issue descriptionIt doesn't include shell/app/shell.rc, and it has some comment about msvs_large_module_debug_link_mode missing. Looks like gn supports both of these by now, and it just needs to be added.
,
Apr 20 2016
,
Apr 28 2016
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4fde4c33b8edceab35991d0ffa4a79092cf4845 commit d4fde4c33b8edceab35991d0ffa4a79092cf4845 Author: brucedawson <brucedawson@chromium.org> Date: Mon May 02 19:03:58 2016 content_shell fixes for gn content_shell is big enough, in non-component builds, that incremental linking is not reliable. Therefore incremental linking needs to be conditionally disabled. This is the equivalent of GYP's msvs_large_module_debug_link_mode. The GYP build disabled incremental linking for content_shell_lib as well but this is meaningless and is sanely prohibited by gn. Also, chrome.dll had a redundant check of is_component_build which this change removes. Finally, this adds shell.rc to the build, necessary for dialogs and menus, thus finishing all of the Windows TODO(GYP) items in this file. BUG= 603015 Review-Url: https://codereview.chromium.org/1930073002 Cr-Commit-Position: refs/heads/master@{#391018} [modify] https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845/chrome/BUILD.gn [modify] https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845/content/shell/BUILD.gn
,
May 3 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Apr 15 2016Labels: -Pri-2 Pri-1
Status: Available (was: Untriaged)