New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 603015 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 354261



Sign in to add a comment

content/shell/BUILD.gn is missing stuff

Project Member Reported by thakis@chromium.org, Apr 13 2016

Issue description

It doesn't include shell/app/shell.rc, and it has some comment about msvs_large_module_debug_link_mode missing. Looks like gn supports both of these by now, and it just needs to be added.
 
Cc: brettw@chromium.org brucedaw...@chromium.org
Labels: -Pri-2 Pri-1
Status: Available (was: Untriaged)
Components: Build
Owner: brucedaw...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4fde4c33b8edceab35991d0ffa4a79092cf4845

commit d4fde4c33b8edceab35991d0ffa4a79092cf4845
Author: brucedawson <brucedawson@chromium.org>
Date: Mon May 02 19:03:58 2016

content_shell fixes for gn

content_shell is big enough, in non-component builds, that incremental
linking is not reliable. Therefore incremental linking needs to be
conditionally disabled. This is the equivalent of GYP's
msvs_large_module_debug_link_mode.

The GYP build disabled incremental linking for content_shell_lib as well
but this is meaningless and is sanely prohibited by gn.

Also, chrome.dll had a redundant check of is_component_build which this
change removes.

Finally, this adds shell.rc to the build, necessary for dialogs and
menus, thus finishing all of the Windows TODO(GYP) items in this file.

BUG= 603015 

Review-Url: https://codereview.chromium.org/1930073002
Cr-Commit-Position: refs/heads/master@{#391018}

[modify] https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845/chrome/BUILD.gn
[modify] https://crrev.com/d4fde4c33b8edceab35991d0ffa4a79092cf4845/content/shell/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment