New issue
Advanced search Search tips

Issue 603011 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add win-clang bots to v8

Project Member Reported by machenb...@chromium.org, Apr 13 2016

Issue description

Need to catch errors early in v8 that'd later get caught by chromium:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/
 
See  issue 82385 
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0da17134e2f492e7593ca6e62b554125fb923df7

commit 0da17134e2f492e7593ca6e62b554125fb923df7
Author: machenbach <machenbach@chromium.org>
Date: Wed Apr 13 16:51:04 2016

[build] Port latest vs_toolchain script.

BUG= chromium:603011 , chromium:603131 
LOG=n

Review URL: https://codereview.chromium.org/1880383003

Cr-Commit-Position: refs/heads/master@{#35452}

[modify] https://crrev.com/0da17134e2f492e7593ca6e62b554125fb923df7/build/vs_toolchain.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8f8dd7150f39f9067f4f7493a32931b296e6d9b6

commit 8f8dd7150f39f9067f4f7493a32931b296e6d9b6
Author: machenbach <machenbach@chromium.org>
Date: Thu Apr 14 07:58:21 2016

[build] New VS 2013 toolchain with setenv.*.json

Port https://codereview.chromium.org/1886493002

BUG= chromium:603011 ,  chromium:603131 
LOG=n
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1880423003

Cr-Commit-Position: refs/heads/master@{#35470}

[modify] https://crrev.com/8f8dd7150f39f9067f4f7493a32931b296e6d9b6/build/vs_toolchain.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a1fa6d0be514ea3dbeac04de8652e3a13e671418

commit a1fa6d0be514ea3dbeac04de8652e3a13e671418
Author: machenbach <machenbach@chromium.org>
Date: Thu Apr 14 13:30:47 2016

[build] Port options to support win-clang

BUG= chromium:603011 
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1886293002

Cr-Commit-Position: refs/heads/master@{#35495}

[modify] https://crrev.com/a1fa6d0be514ea3dbeac04de8652e3a13e671418/build/standalone.gypi

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f569b921bb3228ccd0dfb632bfdeb28b7f6b3704

commit f569b921bb3228ccd0dfb632bfdeb28b7f6b3704
Author: machenbach <machenbach@chromium.org>
Date: Fri Apr 15 12:14:13 2016

clang update.py: Make DIA backwards compatible

Fix after https://codereview.chromium.org/1879753002/ to
continue supporting MSVS 2013.

BUG= 603011 

Review URL: https://codereview.chromium.org/1888883004

Cr-Commit-Position: refs/heads/master@{#387580}

[modify] https://crrev.com/f569b921bb3228ccd0dfb632bfdeb28b7f6b3704/tools/clang/scripts/update.py

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6ef4bd8aa72899ad73e4a84241f8e54ceb60c7ad

commit 6ef4bd8aa72899ad73e4a84241f8e54ceb60c7ad
Author: machenbach <machenbach@chromium.org>
Date: Fri Apr 15 13:56:34 2016

[build] Tweak configuration for win-clang

Unports parts of https://codereview.chromium.org/1828543003
as per suggestion in
https://codereview.chromium.org/1886293002/

Ports https://codereview.chromium.org/1532723003

Also restores -fmsc-version=1800 to support win-clang with
MSVS 2013.

BUG= chromium:603011 
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1895453002

Cr-Commit-Position: refs/heads/master@{#35535}

[add] https://crrev.com/6ef4bd8aa72899ad73e4a84241f8e54ceb60c7ad/build/set_clang_warning_flags.gypi
[modify] https://crrev.com/6ef4bd8aa72899ad73e4a84241f8e54ceb60c7ad/build/standalone.gypi

Comment 9 by thakis@chromium.org, Apr 15 2016

Nice! :-)
Components: Infra>Client>V8
Labels: -Infra-Client-V8
Labels: -Pri-1 Pri-2
What's left to do here and can CIT help?
Status: Verified (was: Assigned)
This was done.

Sign in to add a comment