Issue metadata
Sign in to add a comment
|
Sending audio is stopped when AudioSendStreams are recreated |
||||||||||||||||||||||
Issue descriptionVersion: M51 OS: All The AudioSendStream's associated voe::Channel is stopped when the AudioSendStream is destroyed: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/call/call.cc&rcl=1460474258&l=340 If this happens as a result of recreating an AudioSendStream, e.g. on pc.setRemoteDescription(), an already sending stream will be stopped but not started again.
,
Apr 13 2016
Issue 602642 has been merged into this issue.
,
Apr 13 2016
,
Apr 13 2016
,
Apr 14 2016
Per webrtc:5772, it looks like a WebRTC fix has landed, but we're waiting to get it rolled into Chrome and verified in the next Canary.
,
Apr 15 2016
WebRTC #12347 was rolled in yesterday in https://codereview.chromium.org/1884093002/ (#387269) it should be possible to test soon. Right now http://omahaproxy.appspot.com/ shows an older branch_base_position though, so I guess we'll have to wait a little longer.
,
Apr 15 2016
I've verified this problem is fixed in Chromium Canary 52.0.2709.0.
,
Apr 15 2016
The fix was submitted to the WebRTC repository as refs/heads/master@{#12347} - (https://codereview.webrtc.org/1881793006) together with a regression test.
I have intentionally kept the fix as small as possible to make it easy to merge.
,
Apr 16 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 18 2016
Please merge your change to M51 branch 2704 ASAP (before 5:00 PM PST, today) so we can take it in for M51 last Dev release tomorrow.
,
Apr 18 2016
+Ted - can you help with getting this merged?
,
Apr 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/30990b38c8e6aa984782f6cb4f78eb63110d39e1 commit 30990b38c8e6aa984782f6cb4f78eb63110d39e1 Author: solenberg <solenberg@google.com> Date: Mon Apr 18 19:07:02 2016 Fix bug causing audio to stop being sent when AudioSendStreams are recreated. BUG= chromium:602989 , webrtc:5772 Review URL: https://codereview.webrtc.org/1881793006 Cr-Commit-Position: refs/heads/master@{#12347} (cherry picked from commit 6d6e7c5e1ac4b033e919cf562cc34ccc3b37f201) NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.webrtc.org/1891163002 Cr-Commit-Position: refs/branch-heads/51@{#2} Cr-Branched-From: 5045337133d1da4a657b99e0590eb401515163bd-refs/heads/master@{#12279} [modify] https://crrev.com/30990b38c8e6aa984782f6cb4f78eb63110d39e1/webrtc/media/engine/webrtcvoiceengine.cc [modify] https://crrev.com/30990b38c8e6aa984782f6cb4f78eb63110d39e1/webrtc/media/engine/webrtcvoiceengine_unittest.cc
,
Apr 18 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tnakamura@chromium.org
, Apr 13 2016