New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Started
Owner:
OOO until 4th
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

Implement 'SiteBoundCredential' interface.

Project Member Reported by mkwst@chromium.org, Apr 13 2016

Issue description

We don't currently have 'SiteBoundCredential', which has no practical effect on developers, but might be a little bit confusing since it's in the spec.

So we should implement it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be6cc81fc74f63c8e134525bbf15ea966c8403d5

commit be6cc81fc74f63c8e134525bbf15ea966c8403d5
Author: mkwst <mkwst@chromium.org>
Date: Mon Apr 25 14:51:12 2016

CREDENTIAL: Implement 'SiteBoundCredential'.

This patch shims 'SiteBoundCredential' between 'Credential' and
'{Password,Federated}Credential'. I don't see any need to push this noop
up the stack, however, so it does not introduce a similar concept at
the platform layer, nor does //content need to learn about this
indirection.

As a drive-by, this patch adds some IDL tests for 'CredentialsContainer'
since it was adding IDL tests for 'PasswordCredential' and
'FederatedCredential' anyway.

BUG=602980

Review URL: https://codereview.chromium.org/1880393002

Cr-Commit-Position: refs/heads/master@{#389475}

[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl-expected.txt
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/Credential.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.cpp
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.h
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be6cc81fc74f63c8e134525bbf15ea966c8403d5

commit be6cc81fc74f63c8e134525bbf15ea966c8403d5
Author: mkwst <mkwst@chromium.org>
Date: Mon Apr 25 14:51:12 2016

CREDENTIAL: Implement 'SiteBoundCredential'.

This patch shims 'SiteBoundCredential' between 'Credential' and
'{Password,Federated}Credential'. I don't see any need to push this noop
up the stack, however, so it does not introduce a similar concept at
the platform layer, nor does //content need to learn about this
indirection.

As a drive-by, this patch adds some IDL tests for 'CredentialsContainer'
since it was adding IDL tests for 'PasswordCredential' and
'FederatedCredential' anyway.

BUG=602980

Review URL: https://codereview.chromium.org/1880393002

Cr-Commit-Position: refs/heads/master@{#389475}

[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl-expected.txt
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/Credential.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.cpp
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.h
[add] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.idl
[modify] https://crrev.com/be6cc81fc74f63c8e134525bbf15ea966c8403d5/third_party/WebKit/Source/modules/modules.gypi

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment