New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602959 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Presence of -webkit-font-feature-settings always make Font comparison fail

Reported by r...@opera.com, Apr 13 2016

Issue description

This causes unnecessary style recalc of descendants for inheritance when an element with such a property gets its style recalculated.

 

Comment 1 by r...@opera.com, Apr 13 2016

Components: Blink>Fonts
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b6513eaede077dc4171f5a05157a8658279a68a

commit 3b6513eaede077dc4171f5a05157a8658279a68a
Author: rune <rune@opera.com>
Date: Wed Apr 13 15:58:35 2016

Compare font-feature-settings as part of Font::operator==().

We only did a pointer comparison which always failed when doing a style
recalc since a style recalc always creates a new FontFeatureSetting
object.

R=eae@chromium.org
BUG= 602802 , 602959 

Review URL: https://codereview.chromium.org/1887613002

Cr-Commit-Position: refs/heads/master@{#387001}

[add] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/LayoutTests/fast/css/font-feature-settings-assert-expected.txt
[add] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/LayoutTests/fast/css/font-feature-settings-assert.html
[add] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/LayoutTests/fast/css/invalidation/font-feature-settings-expected.txt
[add] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/LayoutTests/fast/css/invalidation/font-feature-settings.html
[modify] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/Source/platform/fonts/FontDescription.h
[modify] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/Source/platform/fonts/FontFeatureSettings.cpp
[modify] https://crrev.com/3b6513eaede077dc4171f5a05157a8658279a68a/third_party/WebKit/Source/platform/fonts/FontFeatureSettings.h

Comment 4 by r...@opera.com, Apr 13 2016

Status: Fixed (was: Started)

Comment 5 by r...@opera.com, Jun 21 2016

Cc: chrishtr@chromium.org brajkumar@chromium.org r...@opera.com
 Issue 612656  has been merged into this issue.

Sign in to add a comment