New issue
Advanced search Search tips

Issue 602944 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 498120
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Script src error in imported/web-platform-tests/dom/events/EventTarget-dispatchEvent.html

Project Member Reported by alancutter@chromium.org, Apr 13 2016

Issue description

LayoutTest: imported/web-platform-tests/dom/events/EventTarget-dispatchEvent.html

Test output:
CONSOLE ERROR: line 20: Uncaught ReferenceError: aliases is not defined
This is a testharness.js-based test.
PASS Calling dispatchEvent(null). 
Harness: the test ran to completion.


It seems the definition for aliases in <script src="/dom/nodes/Document-createEvent.js"></script> isn't being loaded correctly. This may be related to how we execute imported web-platform-tests.
 

Comment 1 by tkent@chromium.org, Apr 13 2016

In such case, the test should be skipped by adding it to  crbug.com/498120  section of LayoutTests/W3CImportExpectations.

Owner: sriram...@samsung.com
Status: Assigned (was: Available)
When i run the test locally, it is not failing (The test ran as expected) because there is ["allow_uncaught_exception": true] defined in the test which is suppressing the uncaught reference errors.
So do we still need to add it to skip list?
Correct, the test is not failing on the bots because script errors get ignored in testharness.js tests if they occur before the test harness has loaded.
This bug is about the fact that an error is occurring at all.
Mergedinto: 498120
Status: Duplicate (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce75c8846c5b041fc5dc27c0eab1c19700f7c87

commit 3ce75c8846c5b041fc5dc27c0eab1c19700f7c87
Author: srirama.m <srirama.m@samsung.com>
Date: Mon Apr 18 07:17:13 2016

Add EventTarget-dispatchEvent.html test to skip list

There is a script src error in
imported/web-platform-tests/dom/events/EventTarget-dispatchEvent.html.
so adding it to the skip list for now.

BUG= 602944 ,  498120 

Review URL: https://codereview.chromium.org/1898663002

Cr-Commit-Position: refs/heads/master@{#387865}

[modify] https://crrev.com/3ce75c8846c5b041fc5dc27c0eab1c19700f7c87/third_party/WebKit/LayoutTests/W3CImportExpectations

Comment 8 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest>W3C Blink>ToolsTest

Comment 9 by sshru...@google.com, Apr 18 2016

Components: -Blink>ToolsTest Blink>Infra
Blink>ToolsTest renamed to Blink>Infra

Sign in to add a comment