New issue
Advanced search Search tips

Issue 602942 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Sensors


Sign in to add a comment

window-orientationchange-event LayoutTests failing to execute

Project Member Reported by alancutter@chromium.org, Apr 13 2016

Issue description

The check "window.internals && internals.runtimeFlags.orientationEventEnabled" is failing in:
screen_orientation/window-orientationchange-event-subframe.html
screen_orientation/window-orientationchange-event.html

The tests are passing in run-webkit-tests despite the precondition failing.

Test output:
CONSOLE ERROR: line 82: This test requires window.internals and the orientationchange event to be enabled.
This is a testharness.js-based test.
PASS Test that window's orientationchange event is fired when the orientation changes. 
PASS Test that window's orientationchange event is not fired when the orientation does not change. 
Harness: the test ran to completion.

I think OrientationEvent in RuntimeEnabledFeatures.in should be set to status=test.

 
FWIW, the test is made to silently pass if things are not properly enabled. It is meant to run on Android where OrientationEvent is enabled. Maybe the console.error() should be a console.warning?

Comment 2 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Comment 3 by sshru...@google.com, May 18 2016

Components: -Blink>LayoutTests Blink
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead. Merging these to component:Blink for the Blink rotation to pick up and re-triage as appropriate. 
Components: -Blink IO>DeviceOrientation
Components: -IO>DeviceOrientation Blink>Sensor
Components: -Blink>Sensor Blink>ScreenOrientation
Owner: ----
Status: Untriaged (was: Assigned)
Owner no longer has a chromium account

Sign in to add a comment