Chromium crashes
Reported by
matthew...@yandex-team.ru,
Apr 13 2016
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/601.4.4 (KHTML, like Gecko) Version/9.0.3 Safari/601.4.4 Steps to reproduce the problem: We receive a lot of crashes crash signature extensions::`anonymous namespace'::GetFeatureFromProviderByName called from extensions::FeatureProvider::GetBehaviorFeature. What is the expected behavior? What went wrong? Browser crashed. Crashed report ID: No Report ID, unable to reproduce locally How much crashed? Whole browser Is it a problem with a plugin? No Did this work before? No Chrome version: 49.0.2623.112 Channel: stable OS Version: OS X 10.11.3 Flash Version: Shockwave Flash 20.0 r0 I've tried to inspect the crashes found interesting patches that prevent same type of crashes for other type of extesnion features: api, manifest, permission. Those patches belong to https://bugs.chromium.org/p/chromium/issues/detail?id=176381 According to bug - there're flaky JSONReader failures and the best way is to work around such failures. So I've made a similar patch to prevent crashes for behavior features: https://codereview.chromium.org/1835863002/
,
Apr 13 2016
There're more then one code path, so just top frames: logging::LogMessage::~LogMessage extensions::`anonymous namespace'::GetFeatureFromProviderByName extensions::FeatureProvider::GetBehaviorFeature extensions::util::`anonymous namespace'::IsWhitelistedForIncognito extensions::util::IsIncognitoEnabled extensions::ExtensionSystemImpl::RegisterExtensionWithRequestContexts ExtensionService::NotifyExtensionLoaded ExtensionService::AddExtension Actually this one is the most popular, but there're 2 more(checking for other features, not incognito whitelising), but much more rare. I fix them in my CL, but I'm unable to find the corresponding stack traces right now :(
,
Apr 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/604a2ac93c3427d614e100a699e16567dae14ef9 commit 604a2ac93c3427d614e100a699e16567dae14ef9 Author: matthewtff <matthewtff@yandex-team.ru> Date: Fri Apr 15 09:56:52 2016 Added check for behavior feature existense Sometimes JSONReader fails to read json from resources(or resources are broken). So add some error checking to prevent browser crash in such cases. See https://bugs.chromium.org/p/chromium/issues/detail?id=176381 for more details BUG= 602936 Review URL: https://codereview.chromium.org/1835863002 Cr-Commit-Position: refs/heads/master@{#387565} [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/chrome/browser/extensions/extension_util.cc [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/chrome/browser/ui/extensions/application_launch.cc [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/chrome/common/extensions/sync_helper.cc [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/extensions/browser/extension_zoom_request_client.cc [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/extensions/common/features/feature_provider.cc [modify] https://crrev.com/604a2ac93c3427d614e100a699e16567dae14ef9/extensions/common/features/feature_provider.h
,
Jul 1 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Apr 13 2016Status: Assigned (was: Unconfirmed)