New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 602921 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

VideoDecodeAccelerator unittest crash in GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy

Project Member Reported by wuchengli@chromium.org, Apr 13 2016

Issue description

Version: chrome tot synced on Apr 12.
OS: Chrome

What steps will reproduce the problem?
(1) Run video_decode_accelerator_unittest on CrOS.

What do you see instead?
Crashed at the end of the test in GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy()


https://codereview.chromium.org/1865603002 broke it. I'm working on a CL.


[0413/135318:FATAL:ref_counted.h(315)] Assert failed: ptr_ != __null. 
#0 0x0000f58b8b6e base::debug::StackTrace::StackTrace()
#1 0x0000f57fb24e logging::LogMessage::~LogMessage()
#2 0x0000f57a8384 scoped_refptr<>::operator->()
#3 0x0000f596f38a gfx::(anonymous namespace)::GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy()
#4 0x0000f596f436 gfx::(anonymous namespace)::GLSurfaceOzoneSurfacelessSurfaceImpl::~GLSurfaceOzoneSurfacelessSurfaceImpl()
#5 0x0000f596f4a0 gfx::(anonymous namespace)::GLSurfaceOzoneSurfacelessSurfaceImpl::~GLSurfaceOzoneSurfacelessSurfaceImpl()
#6 0x0000f57ac8fa base::RefCounted<>::Release()
#7 0x0000f57aa000 scoped_refptr<>::Release()
#8 0x0000f57a88b8 scoped_refptr<>::operator=()
#9 0x0000f57a4630 content::RenderingHelper::UnInitialize()
#10 0x0000f57d9f5e _ZN4base8internal15RunnableAdapterIMN7content15RenderingHelperEFvjEE3RunIJRKjEEEvPS3_DpOT_
#11 0x0000f57d7dfe _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN7content15RenderingHelperEFvjEEEE8MakeItSoIJPS4_RKjEEEvS7_DpOT_
#12 0x0000f57d6a2e _ZN4base8internal7InvokerINS_13IndexSequenceIJLj0ELj1EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content15RenderingHelperEFvPNS_13WaitableEventEEEEFvPS7_S9_EJNS0_17UnretainedWrapperIS7_EES9_EEENS0_12InvokeHelperILb0EvSC_EEFvvEE3RunEPNS0_13BindStateBaseE
#13 0x0000f57a7a20 base::Callback<>::Run()
#14 0x0000f58bb76e base::debug::TaskAnnotator::RunTask()
#15 0x0000f5802964 base::MessageLoop::RunTask()

 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f663de43634c1197a7a2ed8afc12cb6dc565bd0

commit 2f663de43634c1197a7a2ed8afc12cb6dc565bd0
Author: wuchengli <wuchengli@chromium.org>
Date: Wed Apr 13 14:57:09 2016

ozone: fix crash when running video decode unittests.

In GLSurfaceOzoneSurfacelessSurfaceImpl::Destroy, if the previous
context was NULL, do not make it current.

BUG= chromium:602921 
TEST=Run vda unittests on oak.

Review URL: https://codereview.chromium.org/1887563002

Cr-Commit-Position: refs/heads/master@{#386988}

[modify] https://crrev.com/2f663de43634c1197a7a2ed8afc12cb6dc565bd0/ui/gl/gl_surface_ozone.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment