segmentation fault after clicking items in context menu |
|||||||||
Issue description<b>Version: <Kenneth, what is the frequency?></b> <b>OS: <please tell me it's not XP></b> What steps will reproduce the problem? (1)Build the system to chrome os (2)open chrome os. Open chrome. right click chrome icon in the shelf. (3)choose "autohide shelf" item, I get segmentation fault and application crashes. What is the expected output? No crashes after clicking on any items from context menu What do you see instead? segmentation fault Please use labels and text to provide additional information. When I choose autohide shelf, it tries to execute ExtensionLauncherContextMenu::ExecuteCommand, and command autohide shelf is not defined.
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ebd2ffdf5c5973d95632e25e544cde378828bda commit 6ebd2ffdf5c5973d95632e25e544cde378828bda Author: lgcheng <lgcheng@google.com> Date: Wed Apr 13 17:18:12 2016 Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 Review URL: https://codereview.chromium.org/1888513002 Cr-Commit-Position: refs/heads/master@{#387013} [modify] https://crrev.com/6ebd2ffdf5c5973d95632e25e544cde378828bda/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
,
Apr 13 2016
,
Apr 13 2016
This will need to be patched in M-51 branch, correct?
,
Apr 13 2016
Yes, I think so. Otherwise chrome crashed after clicking launcher context menu item.
,
Apr 13 2016
#5, right. I think the fix is quite straightforward so I would request a merge. You may need to wait to see it verified on the next canary before actually merging.
,
Apr 14 2016
Looks fixed on ToT, can now see it on samus in Dev (51.0.2704.0). Crash ID 8f2f0fc400000000.
,
Apr 14 2016
Issue 603282 has been merged into this issue.
,
Apr 14 2016
Issue 602791 has been merged into this issue.
,
Apr 18 2016
Issue 604139 has been merged into this issue.
,
Apr 27 2016
Should this be merged to M51?
,
Apr 27 2016
Yes, I think so. Do I need to request for merge anywhere?
,
Apr 27 2016
Here should do the trick, consider it approved merge at your leisure.
,
May 1 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 4 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 4 2016
Reopening the bug, did some form of this ever get merged to R51?
,
May 4 2016
How should I merge it to R51? Is there any instructions? Thanks
,
May 4 2016
You should be able to use Drover (go/drover).
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99e16b550ddbbf0874c5a9e25b0c1f55fe8c5af4 commit 99e16b550ddbbf0874c5a9e25b0c1f55fe8c5af4 Author: Yusuke Sato <yusukes@google.com> Date: Wed May 04 19:27:35 2016 Fix segment fault issue bring by last cl https://codereview.chromium.org/1857213004/ Fix segment fault issue related to launcher context menu. BUG= 602918 Review URL: https://codereview.chromium.org/1888513002 Cr-Commit-Position: refs/heads/master@{#387013} (cherry picked from commit 6ebd2ffdf5c5973d95632e25e544cde378828bda) Review URL: https://codereview.chromium.org/1951073002 . Cr-Commit-Position: refs/branch-heads/2704@{#376} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/99e16b550ddbbf0874c5a9e25b0c1f55fe8c5af4/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
,
May 4 2016
Merged to M51 on behalf of Long :)
,
May 4 2016
Issue 607600 has been merged into this issue.
,
May 4 2016
Issue 604125 has been merged into this issue.
,
May 9 2016
Verified on ChromeOS (8297.0.0, 52.0.2727.0) and (8172.25.0, 51.0.2704.37) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by varkha@chromium.org
, Apr 13 2016Components: UI>Shell>Shelf
Labels: -Pri-3 ReleaseBlock-Stable M-51 Pri-1