[MacVIews] Popup's menu does not appear when you click and hold the mouse |
||||||||
Issue descriptionVersion: 52.0.2705.0 OS: 10.11 What steps will reproduce the problem? (1) Enable Toolkit-Views App Info Dialog. Mac (2) Go to chrome://extensions (3) Click Details under the Google Docs extension (4) Click and hold the popup in the middle of the panel that appears What is the expected output? The popup menu should immediately appear. What do you see instead? The menu appears only after releasing the mouse. Please use labels and text to provide additional information.
,
Apr 14 2016
,
Apr 14 2016
bulk-tagging Phase1 for M52
,
Apr 20 2016
,
May 31 2016
migrating Phase2 stuff to M53
,
May 31 2016
,
May 31 2016
ugh - this should be an easy fix
,
Jun 3 2016
Hey tapted, is this being worked on atm? If not, can I take this?
,
Jun 6 2016
Oh yeah! Go for it. Although I think I realised that the thing I thought would be an "easy fix" was actually Issue 616650 :). This one should still be straightforward though.
,
Jun 8 2016
I just started looking into this and I'm having trouble replicating this. I can't get the popup menu to appear at all?
,
Jun 8 2016
Or are you talking about the combobox's menu?
,
Jun 8 2016
Yup - it's the combobox. The same will apply for views::MenuButton, but most occurrences of these might be comboboxes when we launch, since that's often what they really should be [exception: hotdog menu, bookmarks toolbar - but they're a later Phase]. We need logic on Mac to activate on MouseDown rather than MouseUp. But, then, in places we are using native menus, NSMenu might just take care of the rest (i.e. if you keep the mousedown long enough and highlight an item, it should activate rather than having to click again. It might be as simple as having the TransparentButton constructor in combobox.cc call CustomButton::set_triggerable_event_flags(..). - but only on Mac.
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7b6e52dc0b0259c67dac9ded5c385739d36c7fc commit a7b6e52dc0b0259c67dac9ded5c385739d36c7fc Author: spqchan <spqchan@chromium.org> Date: Thu Jul 07 00:30:33 2016 [MacViews] Show combobox menu popup at mouse press. Create a PlatformStyle variable for the combobox button's NotifyAction value. The variable is set to NOTIFY_ON_PRESS on Mac, and NOTIFY_ON_RELEASE for other platforms. Placed TransparentButton's OnMousePressed() override behind #if defined guards for Mac. BUG= 602912 Review-Url: https://codereview.chromium.org/2070623003 Cr-Commit-Position: refs/heads/master@{#404012} [modify] https://crrev.com/a7b6e52dc0b0259c67dac9ded5c385739d36c7fc/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/a7b6e52dc0b0259c67dac9ded5c385739d36c7fc/ui/views/controls/combobox/combobox_unittest.cc [modify] https://crrev.com/a7b6e52dc0b0259c67dac9ded5c385739d36c7fc/ui/views/style/platform_style.cc [modify] https://crrev.com/a7b6e52dc0b0259c67dac9ded5c385739d36c7fc/ui/views/style/platform_style.h [modify] https://crrev.com/a7b6e52dc0b0259c67dac9ded5c385739d36c7fc/ui/views/style/platform_style_mac.mm
,
Jul 9 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tapted@chromium.org
, Apr 13 2016Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)