Issue metadata
Sign in to add a comment
|
Gerrit bot_update doesn't apply DEPS patches before gclient sync |
||||||||||||||||||||||||
Issue descriptionIn ensure_checkout function, DEPS is expected to be updated before gclient sync. ensure_checkout does that for svn and rietveld, but it does not do anything for gerrit. As a result, third_party modules in DEPS are not updated by gclient sync. Since BUILD.gn is updated by gclient sync, build would fail with missing files in third_party.
,
Apr 13 2016
It sounds like bot_update.py will need to be fixed to run gclient sync after checking out a gerrit ref. For example, see https://uberchromegw.corp.google.com/i/client.goma/builders/Goma%20Goobuntu%20Presubmit/builds/26 . Search for "refs/changes/98/254498/3" in https://uberchromegw.corp.google.com/i/client.goma/builders/Goma%20Goobuntu%20Presubmit/builds/26/steps/bot_update/logs/stdio . ===Running git retry fetch https://chrome-internal.googlesource.com/goma/client refs/changes/98/254498/3 ===Running git checkout FETCH_HEAD After this, we should run gclient sync, but currently don't.
,
Apr 15 2016
Just summarize what we discussed in other threads. Naive way to solve this issue is running gclient sync once again after DEPS update. However, it clears update in third_party. blink and v8 may have patches in chromium to apply to third_party, and the naive way won't work.
,
Apr 15 2016
For svn and rietveld, it works like: 1. only apply patch to DEPS. 2. gclient sync 3. apply patches to others. They have whitelist / blacklist features on applying a patch. I could not find the good way to do the same with gerrit. The workaround I come up with is: 1. apply gerrit ref to third_party.git 2. git diff --name-only HEAD^1 to list up all files updated, and copy (or move?) them to temporary directory. 3. gclient sync 4. move what we have preserved in Step 2 to where it should be. What do you think?
,
Apr 15 2016
,
Apr 15 2016
Re #4: I thought that bot_updpate for Rietveld applies the patch twice exactly for this reason. First apply, the sync, then apply again. See for example https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Precise%2032%20Tester/builds/1545/steps/bot_update/logs/stdio, whcih contains this: ===Running apply_issue --root_dir infra --issue 1888993002 --server https://codereview.chromium.org --force --ignore_deps -v -v --no-auth --patchset 1 --whitelist DEPS (attempt #1)=== In directory: /mnt/data/b/build/slave/infra/build and then again but with DEPS blacklisted. ===Running apply_issue --root_dir infra --issue 1888993002 --server https://codereview.chromium.org --force --ignore_deps -v -v --no-auth --patchset 1 --blacklist DEPS (attempt #1)=== In directory: /mnt/data/b/build/slave/infra/build Can't we adopt the same thing for Gerrit? I don't have time for the full fix aom, but this must be solved for Gerrit CQ to replace Rietveld.
,
Apr 18 2016
#6 > Can't we adopt the same thing for Gerrit? To do the same, we need to have the mechanism for whitelist / blacklist. However, when I asked advice on this issue to the goma team members, they suggested that third_party would not be patched when gerrit is used. If so, the issue would be fixed by move apply_patch before gclient sync. Do you have any examples on third_party is patched after gclient sync?
,
Apr 19 2016
,
Apr 19 2016
tentatively assigned to Pawel, who've expressed willingness to help.
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/3f0ac2bde4494b32f87a029b9250a87ce9297652 commit 3f0ac2bde4494b32f87a029b9250a87ce9297652 Author: phajdan.jr@chromium.org <phajdan.jr@chromium.org> Date: Tue Apr 19 15:11:08 2016 depot_tools: expose path to gn.py BUG= chromium:602906 Review URL: https://codereview.chromium.org/1902043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300016 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/3f0ac2bde4494b32f87a029b9250a87ce9297652/recipe_modules/depot_tools/api.py
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/32f90020c1bf8118331046aaf3045fcd6a56a054 commit 32f90020c1bf8118331046aaf3045fcd6a56a054 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Tue Apr 19 15:15:30 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/3f0ac2bde4494b32f87a029b9250a87ce9297652 depot_tools: expose path to gn.py (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG= chromium:602906 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1899943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300017 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/32f90020c1bf8118331046aaf3045fcd6a56a054/infra/config/recipes.cfg
,
Apr 20 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86833 ------------------------------------------------------------------ r86833 | phajdan@google.com | 2016-04-20T10:29:22.410214Z -----------------------------------------------------------------
,
Apr 20 2016
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/76a4900e2e88d1a6ae56b98265131c98e35be490 commit 76a4900e2e88d1a6ae56b98265131c98e35be490 Author: phajdan.jr@chromium.org <phajdan.jr@chromium.org> Date: Fri Apr 22 11:26:38 2016 bot_update: call gclient sync after checking out a gerrit ref BUG= chromium:602906 Review URL: https://codereview.chromium.org/1904663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300109 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/76a4900e2e88d1a6ae56b98265131c98e35be490/recipe_modules/bot_update/resources/bot_update.py
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/30b94928cde1f682089eff8fe94cf201d88dcac5 commit 30b94928cde1f682089eff8fe94cf201d88dcac5 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Fri Apr 22 11:35:47 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/76a4900e2e88d1a6ae56b98265131c98e35be490 bot_update: call gclient sync after checking out a gerrit ref (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG= chromium:602906 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1912093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300111 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/30b94928cde1f682089eff8fe94cf201d88dcac5/infra/config/recipes.cfg
,
Apr 25 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86982 ------------------------------------------------------------------ r86982 | yyanagisawa@google.com | 2016-04-25T04:19:18.198699Z -----------------------------------------------------------------
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/a69d56c8ac00bc1138200281e5a66af148f41ad0 commit a69d56c8ac00bc1138200281e5a66af148f41ad0 Author: tandrii@chromium.org <tandrii@chromium.org> Date: Mon Apr 25 19:20:59 2016 Revert of bot_update: call gclient sync after checking out a gerrit ref (patchset #1 id:1 of https://codereview.chromium.org/1904663002/ ) Reason for revert: I believe this is mostly likely to have broken Angle, but this is speculative. http://crbug.com/606150 Original issue's description: > bot_update: call gclient sync after checking out a gerrit ref > > BUG= chromium:602906 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300109 TBR=hinoka@chromium.org,yyanagisawa@chromium.org,hinoka@google.com,phajdan.jr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= chromium:602906 Review URL: https://codereview.chromium.org/1918903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300159 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/a69d56c8ac00bc1138200281e5a66af148f41ad0/recipe_modules/bot_update/resources/bot_update.py
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3ef4df958f49330219ff9dc68b2ea7c5806edbb6 commit 3ef4df958f49330219ff9dc68b2ea7c5806edbb6 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Mon Apr 25 19:26:32 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/a69d56c8ac00bc1138200281e5a66af148f41ad0 Revert of bot_update: call gclient sync after checking out a gerrit ref (patchset #1 id:1 of https://codereview.chromium.org/1904663002/ ) (tandrii@chromium.org) R=hinoka@google.com,phajdan.jr@chromium.org,hinoka@chromium.org,yyanagisawa@chromium.org,tandrii@chromium.org BUG= chromium:602906 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1914893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300162 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/3ef4df958f49330219ff9dc68b2ea7c5806edbb6/infra/config/recipes.cfg
,
Apr 25 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87004 ------------------------------------------------------------------ r87004 | recipe-roller@chromium.org | 2016-04-25T19:43:28.982615Z -----------------------------------------------------------------
,
Apr 26 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87029 ------------------------------------------------------------------ r87029 | yyanagisawa@google.com | 2016-04-26T01:16:51.435809Z -----------------------------------------------------------------
,
Apr 26 2016
,
Apr 26 2016
,
Apr 27 2016
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/116286a64acc62a1adab07e2eddd490f65c092e4 commit 116286a64acc62a1adab07e2eddd490f65c092e4 Author: phajdan.jr@chromium.org <phajdan.jr@chromium.org> Date: Fri May 06 14:54:12 2016 depot_tools: add debug logic to bot_update for gerrit patches BUG= 606150 , 602906 Review-Url: https://codereview.chromium.org/1954083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300466 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/116286a64acc62a1adab07e2eddd490f65c092e4/recipe_modules/bot_update/resources/bot_update.py
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/bc204fb2ce6f6b11a254a141dee539f3104fd791 commit bc204fb2ce6f6b11a254a141dee539f3104fd791 Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Fri May 06 15:01:00 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/116286a64acc62a1adab07e2eddd490f65c092e4 depot_tools: add debug logic to bot_update for gerrit patches (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG= 606150 , 602906 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1953253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300467 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/bc204fb2ce6f6b11a254a141dee539f3104fd791/infra/config/recipes.cfg
,
May 6 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87498 ------------------------------------------------------------------ r87498 | recipe-roller@chromium.org | 2016-05-06T15:03:12.429891Z -----------------------------------------------------------------
,
May 25 2016
Can I ask you the status of this issue? Do we still need to have the workaround?
,
Jun 15 2016
,
Jun 21 2016
,
Jun 27 2016
,
Jun 27 2016
,
Jul 11 2016
What‘s the status on this? Pawel, are you actively working on this or the blocking bug ( issue 606150 )? If not, then we should clear you as owner and triage appropriately.
,
Jul 12 2016
Oh, I wasn't able to make progress on this. It seems too many things are tangled here, and I'm not sure what'd be best way to test changes before deploying them. It all seems very risky, so I was focusing more on making such changes safer.
,
Jul 12 2016
,
Aug 9 2016
,
Aug 18 2016
,
Aug 18 2016
This needs to be like Pri-0.25. The infra tree closure today was due to this. It turns out we haven't actually tested a luci-py roll for months, despite one landing every week or so. And we 100% can't switch anyone else to Gerrit until this is fixed.
,
Aug 18 2016
Andy or Pawel, can one of you treat this as Pri-0.25? And if not, please tell me why :)
,
Aug 18 2016
I’m on it. I simply was unaware of its severity given the bug’s history. Thanks, Aaron for pointing out the _real_ priority :)
,
Aug 19 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b commit 088b74bcd1e9e95b5bbff42f507bf2b07634ba7b Author: Andrew Bonventre <andybons@chromium.org> Date: Fri Aug 19 20:27:37 2016 Rebase & sync after Gerrit patch is applied in infra_repo_trybot BUG= 602906 Change-Id: I20adc80338e57c0ac97e6c957a01748579713dd5 Reviewed-on: https://chromium-review.googlesource.com/373142 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/basic.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/basic_gerrit.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/infra_internal.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/infra_internal_gerrit.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/only_DEPS.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/only_glyco_python.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/only_go.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/only_js.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/only_python.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/rietveld_tests.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.expected/rietveld_tests_on_win.json [modify] https://crrev.com/088b74bcd1e9e95b5bbff42f507bf2b07634ba7b/recipes/recipes/infra_repo_trybot.py
,
Aug 19 2016
Landed change for Infra, so moving this down to P1. Next step is to set the flag as on by default. Then will mark complete with Andrii’s blessing.
,
Aug 30 2016
,
Aug 30 2016
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/6911b067504584996204cf0b2535508ac4207106 commit 6911b067504584996204cf0b2535508ac4207106 Author: andybons <andybons@chromium.org> Date: Wed Aug 31 19:10:44 2016 Make rebase and sync the default for Gerrit updates. BUG= 602906 R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: tandrii@ takes responsibility. Review-Url: https://codereview.chromium.org/2298883002 [modify] https://crrev.com/6911b067504584996204cf0b2535508ac4207106/recipe_modules/bot_update/api.py [modify] https://crrev.com/6911b067504584996204cf0b2535508ac4207106/recipe_modules/bot_update/example.expected/apply_gerrit_ref.json [rename] https://crrev.com/6911b067504584996204cf0b2535508ac4207106/recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json [modify] https://crrev.com/6911b067504584996204cf0b2535508ac4207106/recipe_modules/bot_update/example.py [modify] https://crrev.com/6911b067504584996204cf0b2535508ac4207106/recipe_modules/bot_update/resources/apply_gerrit.py [modify] https://crrev.com/6911b067504584996204cf0b2535508ac4207106/recipe_modules/bot_update/resources/bot_update.py
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b14b6aaa26cda052c59eb2908943353e24213bb0 commit b14b6aaa26cda052c59eb2908943353e24213bb0 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 19:34:26 2016 Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/6911b067504584996204cf0b2535508ac4207106 Make rebase and sync the default for Gerrit updates. (andybons@chromium.org) R=andybons@chromium.org TBR=rmistry@chromium.org BUG= 602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2295303002 [modify] https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0/infra/config/recipes.cfg [modify] https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json [modify] https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit.json [modify] https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0/scripts/slave/recipes/skia/swarm_infra.expected/Infra-PerCommit_try_gerrit.json [modify] https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0/scripts/slave/recipes/skia/swarm_trigger.expected/recipe_with_gerrit_patch.json
,
Aug 31 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/f8b92b4abc41515a12b206946d0f0e51a53cf898 commit f8b92b4abc41515a12b206946d0f0e51a53cf898 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 19:41:20 2016
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f136ae3cfb42853783a92e1a7c54d021652432b commit 2f136ae3cfb42853783a92e1a7c54d021652432b Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 19:48:59 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0 Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/6911b067504584996204cf0b2535508ac4207106 Make rebase and sync the default for Gerrit updates. (andybons@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2299523005 Cr-Commit-Position: refs/heads/master@{#415726} [modify] https://crrev.com/2f136ae3cfb42853783a92e1a7c54d021652432b/infra/config/recipes.cfg
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/50bd0c2f545a5cff594a628ca45182915632dd82 commit 50bd0c2f545a5cff594a628ca45182915632dd82 Author: andybons <andybons@chromium.org> Date: Wed Aug 31 21:02:48 2016 Remove gerrit_rebase_patch_ref from run_presubmit.py BUG= 602906 Review-Url: https://codereview.chromium.org/2294423002 [modify] https://crrev.com/50bd0c2f545a5cff594a628ca45182915632dd82/scripts/slave/recipes/run_presubmit.py
,
Aug 31 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/842c6661d8cf7f08ce02710a56177a24e25aef44 commit 842c6661d8cf7f08ce02710a56177a24e25aef44 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 21:14:37 2016
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10c054ffcaa155724bd589cc9a2a6ae0a7f447d1 commit 10c054ffcaa155724bd589cc9a2a6ae0a7f447d1 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 21:21:45 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/50bd0c2f545a5cff594a628ca45182915632dd82 Remove gerrit_rebase_patch_ref from run_presubmit.py (andybons@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2303453002 Cr-Commit-Position: refs/heads/master@{#415756} [modify] https://crrev.com/10c054ffcaa155724bd589cc9a2a6ae0a7f447d1/infra/config/recipes.cfg
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630 commit 5c0b4804fd900e6a5f2ef3634c893cdbcd56c630 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 23:28:33 2016 Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b14b6aaa26cda052c59eb2908943353e24213bb0 Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/6911b067504584996204cf0b2535508ac4207106 Make rebase and sync the default for Gerrit updates. (andybons@chromium.org) R=andybons@chromium.org,recipe-roller@chromium.org BUG= 602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2297353002 [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/infra/config/recipes.cfg [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/basic.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/basic_gerrit.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/infra_internal.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/infra_internal_gerrit.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/only_DEPS.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/only_glyco_python.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/only_go.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/only_js.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/only_python.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/rietveld_tests.json [modify] https://crrev.com/5c0b4804fd900e6a5f2ef3634c893cdbcd56c630/recipes/recipes/infra_repo_trybot.expected/rietveld_tests_on_win.json
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/52e067497e5720a3fda6fd65fb0c9c04462a3c4e commit 52e067497e5720a3fda6fd65fb0c9c04462a3c4e Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 31 23:44:39 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/50bd0c2f545a5cff594a628ca45182915632dd82 Remove gerrit_rebase_patch_ref from run_presubmit.py (andybons@chromium.org) https://crrev.com/f835a9107ae607130e9c658067a23c7334b22f83 Revert of lightweight builds archiving for mac and win64 (patchset #8 id:140001 of https://codereview.chromium.org/2279953002/ ) (miimnk@google.com) https://crrev.com/6c9d33b2cad5e6ac88718541b140ba551cb36f37 Add use_sysroot=false to Linux PDFium bots. (thestig@chromium.org) https://crrev.com/fa5cf81426f1a18b24af9ba4283e6d598435debe Only find Xcode on iOS builders if something is being compiled (smut@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=598405, 602906 ,604452 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2299053002 [modify] https://crrev.com/52e067497e5720a3fda6fd65fb0c9c04462a3c4e/infra/config/recipes.cfg
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/1b28f8d3f360454fc0e87dc08a2ec06588b669b3 commit 1b28f8d3f360454fc0e87dc08a2ec06588b669b3 Author: Andrew Bonventre <andybons@chromium.org> Date: Wed Aug 31 20:53:25 2016 Remove usage of flag gerrit_rebase_patch_ref from infra/infra BUG= 602906 Change-Id: Iba198785727c57567bcd5598fb391f45176c5838 Reviewed-on: https://chromium-review.googlesource.com/378817 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/1b28f8d3f360454fc0e87dc08a2ec06588b669b3/recipes/recipes/infra_repo_trybot.py
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168 commit 4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168 Author: tandrii <tandrii@chromium.org> Date: Thu Sep 01 22:35:41 2016 bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects. R=machenbach@chromium.org,andybons@chromium.org BUG= 602906 TEST=manual run of Angle recipe locally Review-Url: https://codereview.chromium.org/2299693003 [modify] https://crrev.com/4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168/recipe_modules/bot_update/resources/bot_update.py
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168 commit 4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168 Author: tandrii <tandrii@chromium.org> Date: Thu Sep 01 22:35:41 2016 bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects. R=machenbach@chromium.org,andybons@chromium.org BUG= 602906 TEST=manual run of Angle recipe locally Review-Url: https://codereview.chromium.org/2299693003 [modify] https://crrev.com/4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168/recipe_modules/bot_update/resources/bot_update.py
,
Sep 1 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/aaa785952999f115f5daee2bcf1f44acfd9bac75 commit aaa785952999f115f5daee2bcf1f44acfd9bac75 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 22:54:51 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/ececcdf321bffa3e8a6ff1ee082200996ec3712c commit ececcdf321bffa3e8a6ff1ee082200996ec3712c Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 23:04:29 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f03dcf76bde5299dc00cdc1cbec721014acf46de Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168 bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects. (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2306563004 [modify] https://crrev.com/ececcdf321bffa3e8a6ff1ee082200996ec3712c/infra/config/recipes.cfg
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7736dc19727d81d818824ad153a3ab55e4c8ae91 commit 7736dc19727d81d818824ad153a3ab55e4c8ae91 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 01 23:06:52 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f03dcf76bde5299dc00cdc1cbec721014acf46de Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/4cb6fb7fbd7800b4fd2e3dca62ca9fcd7a00c168 bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects. (tandrii@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2303093002 Cr-Commit-Position: refs/heads/master@{#416108} [modify] https://crrev.com/7736dc19727d81d818824ad153a3ab55e4c8ae91/infra/config/recipes.cfg
,
Sep 6 2016
,
Sep 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/8c533aea29ca68cf1933732173c57e163388db88 commit 8c533aea29ca68cf1933732173c57e163388db88 Author: yyanagisawa <yyanagisawa@google.com> Date: Mon Sep 12 07:16:09 2016 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by yyanagisawa@chromium.org
, Apr 13 2016